From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gregor Herburger <gregor.herburger@linutronix.de>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Eric Anholt <eric@anholt.net>, Stefan Wahren <wahrenst@gmx.net>,
Srinivas Kandagatla <srini@kernel.org>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: broadcom: bcm2712: Add the otp nodes to firmware
Date: Thu, 9 Apr 2026 15:05:16 +0200 [thread overview]
Message-ID: <ee06d877-a1df-40b2-8922-94e68a0e90b5@kernel.org> (raw)
In-Reply-To: <adejoCVSpOW5wygD@gregor-framework>
On 09/04/2026 15:03, Gregor Herburger wrote:
>>>
>>> If I drop the binding patch how to distinguish the variants? Should I
>>> add a SoC specific compatible? e.g. `raspberrypi,bcm2712-firmware` and
>>> use it in the firmware/raspberrypi driver to add the second otp region?
>>
>> So you have different devices/variants? What is the "variant" here?
>
> Seems so. I suppose there is at least a bcm2712 variant and a non-bcm2712
> variant (which is currently confusingly named 'raspberrypi,bcm2835-firmware').
>>
>> Writing-bindings asks you to have per device compatible. Why standard
>> rules do not apply here? (see also DTS101)
>
> I am not arguing that the rules do not apply here. I want to find out
> what is the correct way to do it.
>
> Should there then be a 'raspberrypi,bcm2712-firmware' compatible with
> 'raspberrypi,bcm2835-firmware' fallback?
Yes, most likely. Let's wait a bit - maybe someone from Raspberry or
Broadcom will clarify things here.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-04-09 13:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 8:00 [PATCH 0/3] nvmem: Add Raspberry Pi OTP nvmem driver Gregor Herburger
2026-04-08 8:00 ` [PATCH 1/3] dt-bindings: nvmem: Add a binding for the RPi Firmware OTP register Gregor Herburger
2026-04-09 8:13 ` Krzysztof Kozlowski
2026-04-08 8:00 ` [PATCH 2/3] nvmem: Add the Raspberry Pi OTP driver Gregor Herburger
2026-04-08 16:52 ` Stefan Wahren
2026-04-08 19:47 ` Gregor Herburger
2026-04-08 20:03 ` Stefan Wahren
2026-04-09 8:05 ` Gregor Herburger
2026-04-09 15:21 ` Stefan Wahren
2026-04-09 8:17 ` Krzysztof Kozlowski
2026-04-08 8:00 ` [PATCH 3/3] arm64: dts: broadcom: bcm2712: Add the otp nodes to firmware Gregor Herburger
2026-04-09 8:15 ` Krzysztof Kozlowski
2026-04-09 12:02 ` Gregor Herburger
2026-04-09 12:15 ` Krzysztof Kozlowski
2026-04-09 13:03 ` Gregor Herburger
2026-04-09 13:05 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee06d877-a1df-40b2-8922-94e68a0e90b5@kernel.org \
--to=krzk@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=florian.fainelli@broadcom.com \
--cc=gregor.herburger@linutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=srini@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox