From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C20C3DA7D for ; Thu, 29 Dec 2022 10:58:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbiL2K6F (ORCPT ); Thu, 29 Dec 2022 05:58:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbiL2K6C (ORCPT ); Thu, 29 Dec 2022 05:58:02 -0500 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 573C96575 for ; Thu, 29 Dec 2022 02:58:01 -0800 (PST) Received: by mail-lf1-x129.google.com with SMTP id p36so27019058lfa.12 for ; Thu, 29 Dec 2022 02:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dfIpZeybmiTXSCTrfCMEUJqrNv84QBe465sGsNxFGUU=; b=ZP2IDJ6NBFhWnSdLhWKsB0VhP8lSxXn+KWaPKyH5+iUWKLI98+vuyFhG2k9bbuutoX AXZB8biU5wSagbBk8/yBi864c2cfaZLaeByDG8i0tE2QUSt8LAgyylRUCEM9UWCthrIy 1/EZcnzWHkm98Hg+tskczggF/X/ie/4hOhhAiu22w+XxnB6FGI7Lpkus27RyrNUx+jhz MRZjhRi0X20QG2l+GNYcqHfKf70OuPsqBgK65gsipuRKUtuPo4sSDTjF1YTuHB9ABOp7 wVHMWRoDFJ7b82zUKoI5C4g2XlSeJ1LZU/o9EaAx8Y+rufGjpt+TALcpLQjWq/HkD5D4 B7Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dfIpZeybmiTXSCTrfCMEUJqrNv84QBe465sGsNxFGUU=; b=hpNBIqy3vcj5a1U3wq9hxgjlIgjFvxV6RrfUnBCFWaShXS2wRbaNYADgdFrhKFIMsg r7uRfYa9wF0ObZfDM/pPC5Q/NXejR3pSHzBkMTJYd0O8+dHcADC+eq+5v77P3majKp22 TYS9hw5HzEaKN/8p7pGCtrFAx2yVUYPIKdtwVquDsiYQ6jkSoBpJZdo5w5/jPGN6Vlwf hgdyj/6E20ObEjhwT1OcOiGGScDl6YQ3E2wjbEaFf8HmvOSvD/BVdlEuJC/QvVNBbDov YttM7lTJuSC1dDuQVoLm7K4zLRR83QgVFuuMpbNRmblsvK1Y+vw9zAWqetvd5wOJpqYJ TEEA== X-Gm-Message-State: AFqh2kqF781sfN76dYs1hgSruT5UFeDI2jPLC31XTjAGI4IC+MTf+kgI 8hmIi4HAuc3r4eV5Nt4kSH19GQ== X-Google-Smtp-Source: AMrXdXvkzxOlUdpBAw57XiBPPqCO/gw/o2BkN3GgIRVbn07WOme0rLgjoR4JmWvz9j/WuM8Xu+fhIQ== X-Received: by 2002:a05:6512:1688:b0:4ca:fa75:a64a with SMTP id bu8-20020a056512168800b004cafa75a64amr6519282lfb.0.1672311479697; Thu, 29 Dec 2022 02:57:59 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id p11-20020a19f00b000000b004b6e157d326sm3007498lfc.168.2022.12.29.02.57.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Dec 2022 02:57:59 -0800 (PST) Message-ID: Date: Thu, 29 Dec 2022 11:57:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 1/7] arm64: dts: qcom: sm8450: add spmi node Content-Language: en-US To: Konrad Dybcio , linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Vinod Koul , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221229103212.984324-1-konrad.dybcio@linaro.org> <7b32e414-96a9-7265-efee-f872badb32b2@linaro.org> <71d7a162-569d-1443-9e53-3ba374d06ccd@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <71d7a162-569d-1443-9e53-3ba374d06ccd@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/12/2022 11:45, Konrad Dybcio wrote: > > > On 29.12.2022 11:42, Krzysztof Kozlowski wrote: >> On 29/12/2022 11:32, Konrad Dybcio wrote: >>> From: Vinod Koul >>> >>> Add the spmi bus as found in the SM8450 SoC >>> >>> Signed-off-by: Vinod Koul >>> Reviewed-by: Konrad Dybcio >>> [Konrad: 0x0 -> 0, move #cells down, make reg-names a vertical list] >>> Signed-off-by: Konrad Dybcio >>> --- >>> v1 -> v2: >>> No changes >>> >>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 22 ++++++++++++++++++++++ >>> 1 file changed, 22 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> index 570475040d95..b9b59c5223eb 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> @@ -2715,6 +2715,28 @@ aoss_qmp: power-controller@c300000 { >>> #clock-cells = <0>; >>> }; >>> >>> + spmi_bus: spmi@c42d000 { >> >> Hmm looks different than reg. >> >>> + compatible = "qcom,spmi-pmic-arb"; >>> + reg = <0 0x0c400000 0 0x00003000>, >>> + <0 0x0c500000 0 0x00400000>, >>> + <0 0x0c440000 0 0x00080000>, >>> + <0 0x0c4c0000 0 0x00010000>, >>> + <0 0x0c42d000 0 0x00010000>; >> x > Hm, my guess would be that Vinod chose to put the "cnfg" reg > instead of "core" in the unit address, as 8450 has 2 SPMI bus > hosts and they both share the core reg, so it would have been > impossible to have two spmi@core nodes.. Eh? SM8450 has 2 SPMI hosts both using 0x0c400000? How does that work? Usually address can be mapped only once. Where is the second SPMI? I cannot find it in linux-next. Best regards, Krzysztof