devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH 1/3] dt-bindings: arm: qcom: stop describing individual boards
Date: Sat, 23 Jul 2022 19:49:09 +0200	[thread overview]
Message-ID: <ee2aaa0e-d14d-4d71-81d9-cbb297f34d45@linaro.org> (raw)
In-Reply-To: <20220723090942.1637676-2-dmitry.baryshkov@linaro.org>

On 23/07/2022 11:09, Dmitry Baryshkov wrote:
> Describing each compatible board in DT schema seems wrong to me. It
> means that each new board is incompatible by default, until added to the
> DT schema. If any of the vendors for whatever reasons tries to validate
> their new device's DT, they will be stuck with it being incompatible
> with arm/qcom.yaml until the file is expanded to include such devices.
> 
> Rework simple cases by dropping individual board compatible strings and
> replacing them with the empty schema.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../devicetree/bindings/arm/qcom.yaml         | 203 ++++--------------
>  1 file changed, 39 insertions(+), 164 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index fb1d00bcc847..d4d945a43178 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -107,60 +107,39 @@ properties:
>    compatible:
>      oneOf:
>        - items:
> -          - enum:
> -              - qcom,apq8016-sbc
> +          - {}
>            - const: qcom,apq8016
>  

No, this removes documentation of compatibles thus removes part
documenting the ABI.


Best regards,
Krzysztof

  reply	other threads:[~2022-07-23 17:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-23  9:09 [PATCH 0/3] dt-bindings: arm: qcom: define schema, not devices Dmitry Baryshkov
2022-07-23  9:09 ` [PATCH 1/3] dt-bindings: arm: qcom: stop describing individual boards Dmitry Baryshkov
2022-07-23 17:49   ` Krzysztof Kozlowski [this message]
2022-07-23  9:09 ` [PATCH 2/3] dt-bindings: arm: qcom: merge simple platform definitions Dmitry Baryshkov
2022-07-23 17:50   ` Krzysztof Kozlowski
2022-07-23  9:09 ` [PATCH 3/3] dt-bindings: arm: qcom: drop individual descriptions of Google devices Dmitry Baryshkov
2022-07-23 17:51   ` Krzysztof Kozlowski
2022-07-23 17:48 ` [PATCH 0/3] dt-bindings: arm: qcom: define schema, not devices Krzysztof Kozlowski
2022-07-23 22:50   ` Dmitry Baryshkov
2022-07-25 16:18     ` Krzysztof Kozlowski
2022-07-25 17:13       ` Dmitry Baryshkov
2022-07-25 17:25         ` Krzysztof Kozlowski
2022-07-25 16:25     ` Doug Anderson
2022-07-25 16:41       ` Krzysztof Kozlowski
2022-07-25 16:54         ` Doug Anderson
2022-07-25 17:07           ` Krzysztof Kozlowski
2022-07-25 17:09             ` Doug Anderson
2022-07-25 17:14               ` Krzysztof Kozlowski
2022-07-25 17:22                 ` Doug Anderson
2022-07-25 17:29                   ` Krzysztof Kozlowski
2022-07-25 17:35                     ` Doug Anderson
2022-07-25 16:56         ` Krzysztof Kozlowski
2022-07-25 17:30     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee2aaa0e-d14d-4d71-81d9-cbb297f34d45@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).