From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FAF3C4332F for ; Thu, 13 Oct 2022 12:39:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229723AbiJMMjC (ORCPT ); Thu, 13 Oct 2022 08:39:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbiJMMi6 (ORCPT ); Thu, 13 Oct 2022 08:38:58 -0400 Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CAC011D99D for ; Thu, 13 Oct 2022 05:38:56 -0700 (PDT) Received: by mail-qt1-x82b.google.com with SMTP id g11so880420qts.1 for ; Thu, 13 Oct 2022 05:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5kz9tUsFqTbeOstAmkjMnqXNuAGfE9Jg+Fa6WSlHaXY=; b=ZK8VDKTZB/G6KzUx18/x7iGXsNCnhmsEUHjFq/DOGq3C+2rzQ/onKPlyoiLxY3kr6u vmvmQTeAHzrP7zl8Cq8dRTULBmrnfhxqFAi2p74AvAI/iw89aODcguStpcU8iM0RAC4l i0WtaMk1sA7rak0Go/GCe7uQYyXkVU3nJ39s17YsxyblW0OHO6ltbHSHwTc+0QaH0iNL XFap/X+b5TxlTZPpUzZcWR1leFsj6UF0ApCD11XqHYW5BDM4tJdzENUx1dnvo+NaDHhW 9YCg/g6zV/tYFGch21jEvfbTGotqlXqbVKw2ZUxtF98WTzs7jx3k7tqe8qvZxama4pi7 zJdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5kz9tUsFqTbeOstAmkjMnqXNuAGfE9Jg+Fa6WSlHaXY=; b=c2t3LzmSeZn5FeDsD6wx13XT5Ayrvg0/QhFVECyMe9nE5a3a7u8qv76t00qW9VA8os Y9buRgrPIQPPcGTJYH91EgsnhjPSRKu8iBntpZ5/VfnoUdcCw5lcoIlmhEC0rLEI2rI6 NLC9AuoLEemBXcxVpJUMx6M/qx4GSyRDrOR9g7t/J/x46wGeVSFiFTdqxv/8b3WmsADQ KIcm3z7DpyQwSo7tx7gaWFrcFo3E7+6E9FsGqK1BaivIMzPO43Np04bJM//H0anSieqA 7N+rFNzs4ucCS+qf/PHZfJnaXTi1bJJgrcgv6O0NrjI8pKEEs/axrsjYRF2O9I++7gq/ W2uw== X-Gm-Message-State: ACrzQf1N6Bp3AYoL4dK3WDZv9PVMFuzAhFMSHyVZPJUAikNgLPDXn7Yl 9xSh9R8RNx17tdAQEoYgbMfF4w== X-Google-Smtp-Source: AMsMyM7QGWwq2TvteduWwhCjLEthvj2mVj02Nsr1AAZ/3O3uzKlIbcCYr5JBhY8RY7/i+vnIKYW/Sg== X-Received: by 2002:ac8:7d45:0:b0:396:ce08:4b49 with SMTP id h5-20020ac87d45000000b00396ce084b49mr25163847qtb.650.1665664734315; Thu, 13 Oct 2022 05:38:54 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id o15-20020a05620a2a0f00b006ce40fbb8f6sm18877024qkp.21.2022.10.13.05.38.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Oct 2022 05:38:53 -0700 (PDT) Message-ID: Date: Thu, 13 Oct 2022 08:36:42 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 2/2] dt-bindings: pinctrl: qcom,sc7180: convert to dtschema Content-Language: en-US To: Doug Anderson Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221007145116.46554-1-krzysztof.kozlowski@linaro.org> <20221007145116.46554-2-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/10/2022 13:42, Doug Anderson wrote: > Hi, > > On Fri, Oct 7, 2022 at 7:51 AM Krzysztof Kozlowski > wrote: >> >> + drive-strength: >> + enum: [2, 4, 6, 8, 10, 12, 14, 16] >> + default: 2 >> + description: >> + Selects the drive strength for the specified pins, in mA. > > The "default" of 2 is not correct. Please see commit 768f8d8e45f9 > ("dt-bindings: pinctrl: drive-strength doesn't default to 2 if > unspecified") Uh, you're right. This was copied to one binding and then I copied to another, and another... > > In fact, are you sure this even needs to be replicated here? This is > part of the common "qcom,tlmm-common.yaml" bindings file, isn't it? If the value was correct, it might be per-SoC specific, but that's another question. The default value is actually unknown, so I'll remove it. Best regards, Krzysztof