From: Georgi Djakov <georgi.djakov@linaro.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: gregkh@linuxfoundation.org, linux-pm@vger.kernel.org,
rjw@rjwysocki.net, robh+dt@kernel.org, mturquette@baylibre.com,
khilman@baylibre.com, vincent.guittot@linaro.org,
skannan@codeaurora.org, bjorn.andersson@linaro.org,
amit.kucheria@linaro.org, seansw@qti.qualcomm.com,
daidavid1@codeaurora.org, evgreen@chromium.org,
dianders@chromium.org, mark.rutland@arm.com,
lorenzo.pieralisi@arm.com, abailon@baylibre.com,
maxime.ripard@bootlin.com, arnd@arndb.de,
thierry.reding@gmail.com, ksitaraman@nvidia.com,
sanjayc@nvidia.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v11 5/8] interconnect: qcom: Add sdm845 interconnect provider driver
Date: Sat, 8 Dec 2018 02:24:03 +0200 [thread overview]
Message-ID: <ee392578-2dbc-7e60-be37-483729e922d1@linaro.org> (raw)
In-Reply-To: <20181207233010.GE14307@google.com>
Hi Matthias,
Thanks for looking into this.
On 8.12.18 1:30, Matthias Kaehlcke wrote:
> Hi Georgi,
>
> not a full review, only one thing I just stumbled across:
>
> On Fri, Dec 07, 2018 at 05:29:14PM +0200, Georgi Djakov wrote:
>> From: David Dai <daidavid1@codeaurora.org>
>>
>> Introduce Qualcomm SDM845 specific provider driver using the
>> interconnect framework.
>>
>> Signed-off-by: David Dai <daidavid1@codeaurora.org>
>> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
>> ---
>> .../bindings/interconnect/qcom,sdm845.txt | 24 +
>> drivers/interconnect/Kconfig | 5 +
>> drivers/interconnect/Makefile | 1 +
>> drivers/interconnect/qcom/Kconfig | 13 +
>> drivers/interconnect/qcom/Makefile | 5 +
>> drivers/interconnect/qcom/sdm845.c | 836 ++++++++++++++++++
>> .../dt-bindings/interconnect/qcom,sdm845.h | 143 +++
>> 7 files changed, 1027 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt
>> create mode 100644 drivers/interconnect/qcom/Kconfig
>> create mode 100644 drivers/interconnect/qcom/Makefile
>> create mode 100644 drivers/interconnect/qcom/sdm845.c
>> create mode 100644 include/dt-bindings/interconnect/qcom,sdm845.h
>>
>> ...
>>
>> diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c
>> new file mode 100644
>> index 000000000000..f594dd6f500f
>> --- /dev/null
>> +++ b/drivers/interconnect/qcom/sdm845.c
>>
>> ...
>>
>> +static int qcom_icc_bcm_init(struct qcom_icc_bcm *bcm, struct device *dev)
>> +{
>> + struct qcom_icc_node *qn;
>> + int ret, i;
>> +
>> + bcm->addr = cmd_db_read_addr(bcm->name);
>> + if (!bcm->addr) {
>> + dev_err(dev, "%s could not find RPMh address\n",
>> + bcm->name);
>> + return -EINVAL;
>> + }
>> +
>> + if (cmd_db_read_aux_data_len(bcm->name) < sizeof(struct bcm_db)) {
>> + dev_err(dev, "%s command db missing or partial aux data\n",
>> + bcm->name);
>> + return -EINVAL;
>> + }
>
> cmd_db_read_aux_data_len() is in the process of being removed, see
> ed3cafa79ea7 ("soc: qcom: cmd-db: Stop memcpy()ing in
> cmd_db_read_aux_data()") in arm-soc/for-next
>
> https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/commit/?h=for-next&id=ed3cafa79ea756be653d22087c017af95ea78a49
Yes, exactly. I have a fix that lives as a separate patch [8/8] and will squash it here.
BR,
Georgi
next prev parent reply other threads:[~2018-12-08 0:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 15:29 [PATCH v11 0/8] Introduce on-chip interconnect API Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 1/8] interconnect: Add generic " Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 2/8] dt-bindings: Introduce interconnect binding Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 3/8] interconnect: Allow endpoints translation via DT Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 4/8] interconnect: Add debugfs support Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 5/8] interconnect: qcom: Add sdm845 interconnect provider driver Georgi Djakov
2018-12-07 23:30 ` Matthias Kaehlcke
2018-12-08 0:24 ` Georgi Djakov [this message]
2018-12-07 15:29 ` [PATCH v11 6/8] arm64: dts: sdm845: Add interconnect provider DT nodes Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 7/8] MAINTAINERS: add a maintainer for the interconnect API Georgi Djakov
2018-12-07 15:29 ` [PATCH v11 8/8] interconnect: sdm845: Fix build failure after cmd_db API change Georgi Djakov
2018-12-07 16:27 ` Quentin Perret
2018-12-07 16:47 ` Georgi Djakov
2018-12-07 17:14 ` Quentin Perret
2018-12-07 21:29 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee392578-2dbc-7e60-be37-483729e922d1@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=abailon@baylibre.com \
--cc=amit.kucheria@linaro.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@baylibre.com \
--cc=ksitaraman@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sanjayc@nvidia.com \
--cc=seansw@qti.qualcomm.com \
--cc=skannan@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).