From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Yinbo Zhu <zhuyinbo@loongson.cn>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Wolfram Sang <wsa@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Jean Delvare <jdelvare@suse.de>,
William Zhang <william.zhang@broadcom.com>,
Conor Dooley <conor.dooley@microchip.com>,
Jan Dabros <jsd@semihalf.com>,
Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Tyrone Ting <kfting@nuvoton.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] i2c: loongson: add bus driver for the loongson i2c controller
Date: Mon, 28 Nov 2022 15:12:54 +0100 [thread overview]
Message-ID: <ee52f463-f54c-70cb-5a31-5748f26f40bc@linaro.org> (raw)
In-Reply-To: <Y4S/dh9lztpOHxkD@smile.fi.intel.com>
On 28/11/2022 15:02, Andy Shevchenko wrote:
> On Mon, Nov 28, 2022 at 09:00:24PM +0800, Yinbo Zhu wrote:
>> This bus driver supports the Loongson i2c hardware controller in the
>> Loongson platforms and supports to use DTS and ACPI framework to
>> register i2c adapter device resources.
>>
>> The Loongson i2c controller supports operating frequencty is 50MHZ
>> and supports the maximum transmission rate is 400kbps.
>
> ...
> Why not using the usual pattern, i.e.
>
> if (!(...))
> return IRQ_NONE;
>
> ?
>
> It seems you ignored some of my comments...
> I stopped here, please check what was given against v1 and try again.
I propose to wait with wasting more time on reviews because you might do
the same work twice:
https://lore.kernel.org/all/822356908305580d601e5b3e424371ed7f220b85.1669359515.git.zhoubinbin@loongson.cn/
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-28 14:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 13:00 [PATCH v2 1/2] i2c: loongson: add bus driver for the loongson i2c controller Yinbo Zhu
2022-11-28 13:00 ` [PATCH v2 2/2] dt-bindings: i2c: add loongson i2c Yinbo Zhu
2022-11-28 14:11 ` Krzysztof Kozlowski
2022-11-28 23:51 ` Yinbo Zhu
2022-11-29 6:56 ` Yinbo Zhu
2022-11-28 14:02 ` [PATCH v2 1/2] i2c: loongson: add bus driver for the loongson i2c controller Andy Shevchenko
2022-11-28 14:12 ` Krzysztof Kozlowski [this message]
2022-11-28 14:26 ` Andy Shevchenko
2022-11-29 7:04 ` Yinbo Zhu
2022-12-05 8:40 ` Wolfram Sang
2022-12-05 8:56 ` Yinbo Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee52f463-f54c-70cb-5a31-5748f26f40bc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=jsd@semihalf.com \
--cc=kfting@nuvoton.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=phil.edworthy@renesas.com \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tharunkumar.pasumarthi@microchip.com \
--cc=william.zhang@broadcom.com \
--cc=wsa@kernel.org \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).