From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62AE5C433FE for ; Mon, 28 Nov 2022 14:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232327AbiK1ONE (ORCPT ); Mon, 28 Nov 2022 09:13:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232399AbiK1ONB (ORCPT ); Mon, 28 Nov 2022 09:13:01 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B8C6205CC for ; Mon, 28 Nov 2022 06:13:00 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id q7so13268598ljp.9 for ; Mon, 28 Nov 2022 06:13:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xTh1nEEe1sZRF8M0HBvSAqoj/WogzsicuLZxTaiVtEk=; b=cnGclIVTIKCjEAuQSzJYnC7wk8mdlCiLluFSrAmgb0ybDl4nhlr9Gd6tNHSrPiflp3 lnbpE+R1iEXEC+yLedMHs0Z6SkiDoVBj+nMrZ90QuQGiLmHBTp7HVlqM8AIxddxP2KAT sbIzJFvNJxy+LP0qB7aZE1xNlmQIvtlruGRIyYNP6OVSeSI7GaG/D2FhVUKQW01qWWIs SRxx8WGbcISDj7VNirmDOQizwfl9+7Z5AUpkDLchFrNSVAgDF2FAG2+BcH+WSMh3CXH3 /VX/u3om6/wPKoK0W4U7VSXZf62Pf1dn9EdnPRQBhwK2gULy06Ya1uVZNQAus7l+uhHz f+sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xTh1nEEe1sZRF8M0HBvSAqoj/WogzsicuLZxTaiVtEk=; b=ClCs37Mrqrrx4oySR/80TRV3wtZpD4ATUVXu/k+2WfqmDlgJU7bTlvNfpEwIcbm4wV phoKnUP0sGGz5V4GFtx31HmdARQWtQlkFq5vKuo4umUaSy2XXQyUa5Sh4fSZdE8EVtnr vzV43vWjXPpBN1bm39QtBSTFu7qs8EDVL5HUXJSrO21vzUoae+rCHNZ13BdKuHxNnMVE Uki6gKLVPXDsmy6V0E6X9LbDB38uqHoKVlenNUlY4bimw0HS6L7vc06Ytt9eIfsgzQU3 6OMd5tu4wyD3e3zF07zogW8/rTkhivhhhVwqbJ/Won4IYOT+/B9wErvwTZVCjUMsFgLm kctQ== X-Gm-Message-State: ANoB5pkpVgnQN7W/b6UxzMnSdcTFFuuvcqIfKM1eHEUS0b5RHJe11g7b m/Lz62UjEyMmrVDDKbo44BveJw== X-Google-Smtp-Source: AA0mqf4RTqCSdVc2fh4P/K+7P/sOstE+KCYSuuoGYLYuBYboJ4/i1E5DomK6dGz+ooHuSLU2nOY2XQ== X-Received: by 2002:a05:651c:12c7:b0:26f:c03d:f99b with SMTP id 7-20020a05651c12c700b0026fc03df99bmr17132650lje.190.1669644776127; Mon, 28 Nov 2022 06:12:56 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id m1-20020a056512114100b004972b0bb426sm1759227lfg.257.2022.11.28.06.12.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 06:12:55 -0800 (PST) Message-ID: Date: Mon, 28 Nov 2022 15:12:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 1/2] i2c: loongson: add bus driver for the loongson i2c controller Content-Language: en-US To: Andy Shevchenko , Yinbo Zhu Cc: Rob Herring , Krzysztof Kozlowski , Wolfram Sang , Florian Fainelli , Jarkko Nikula , Jean Delvare , William Zhang , Conor Dooley , Jan Dabros , Tharun Kumar P , Phil Edworthy , Sam Protsenko , Tyrone Ting , Philipp Zabel , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221128130025.23184-1-zhuyinbo@loongson.cn> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/11/2022 15:02, Andy Shevchenko wrote: > On Mon, Nov 28, 2022 at 09:00:24PM +0800, Yinbo Zhu wrote: >> This bus driver supports the Loongson i2c hardware controller in the >> Loongson platforms and supports to use DTS and ACPI framework to >> register i2c adapter device resources. >> >> The Loongson i2c controller supports operating frequencty is 50MHZ >> and supports the maximum transmission rate is 400kbps. > > ... > Why not using the usual pattern, i.e. > > if (!(...)) > return IRQ_NONE; > > ? > > It seems you ignored some of my comments... > I stopped here, please check what was given against v1 and try again. I propose to wait with wasting more time on reviews because you might do the same work twice: https://lore.kernel.org/all/822356908305580d601e5b3e424371ed7f220b85.1669359515.git.zhoubinbin@loongson.cn/ Best regards, Krzysztof