devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	Marek Vasut <marex@denx.de>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v1 0/3] gpio: Add gpio-delay support
Date: Sun, 16 Apr 2023 13:04:54 +0200	[thread overview]
Message-ID: <ee53f7cf-b94a-ba0f-1e28-5ffa2c0f5e78@linaro.org> (raw)
In-Reply-To: <CAHp75VdRjCvcwjVO8GZfrVhFqJmO+WaqmJ63A2vVK4iELx=OXg@mail.gmail.com>

On 16/04/2023 11:36, Andy Shevchenko wrote:
> On Sun, Apr 16, 2023 at 10:42 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> On 15/04/2023 17:06, Andy Shevchenko wrote:
>>> On Fri, Apr 14, 2023 at 9:37 AM Alexander Stein
>>> <alexander.stein@ew.tq-group.com> wrote:
>>>> Am Dienstag, 11. April 2023, 11:34:16 CEST schrieb Andy Shevchenko:
>>>>> On Tue, Apr 11, 2023 at 10:19 AM Alexander Stein
>>>>> <alexander.stein@ew.tq-group.com> wrote:
> 
> ...
> 
>>>>> So, taking the above into consideration, why is it GPIO property to
>>>>> begin with? This is PCB property of the certain platform design that
>>>>> needs to be driven by a specific driver, correct?
>>>>
>>>> True this is induced by the PCB, but this property applies to the GPIO,
>>>> neither the GPIO controller output, nor the GPIO consumer is aware of.
>>>> So it has to be added in between. The original idea to add a property for the
>>>> consumer driver is also rejected, because this kind of behavior is not limited
>>>> to this specific driver.
>>>> That's why the delay is inserted in between the GPIO output and GPIO consumer.
>>>>
>>>>> At the very least this is pin configuration (but external to the SoC),
>>>>> so has to be a _separate_ pin control in my opinion.
>>>>
>>>> Sorry, I don't get what you mean by _separate_ pin control.
>>>
>>> As you mentioned above this can be applied theoretically to any pin of
>>> the SoC, That pin may or may not be a GPIO or a pin that can be
>>> switched to the GPIO mode. Hence this entire idea shouldn't be part of
>>> the existing _in-SoC_ pin control driver if any. This is a purely
>>> separate entity, but at the same time it adds a property to a pin,
>>> hence pin control.
>>> At the same time, it's not an SoC related one, it's a PCB. Hence _separate_.
>>
>> I don't think that anything here is related to pin control. Pin control
>> is specific function of some device which allows different properties or
>> different functions of a pin.
> 
> Sorry, but from a hardware perspective I have to disagree with you.
> It's a property of the _pin_ and not of a GPIO. Any pin might have the
> same property. That's why it's definitely _not_ a property of GPIO,
> but wider than that.

I did not say this is a property of GPIO. I said this is nothing to do
with pin control, configuration and pinctrl as is.

Otherwise bindings would be in directory matching the real hardware...
but they are not. So you can of course call it as you wish, but from
hardware perspective this is not pin control. This is RC circuit, not
pin related thingy.

Best regards,
Krzysztof


  reply	other threads:[~2023-04-16 11:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06  9:33 [PATCH v1 0/3] gpio: Add gpio-delay support Alexander Stein
2023-04-06  9:33 ` [PATCH v1 1/3] dt-bindings: gpio: Add gpio-delay binding document Alexander Stein
2023-05-31 16:37   ` Krzysztof Kozlowski
2023-06-02 16:29   ` Bartosz Golaszewski
2023-04-06  9:33 ` [PATCH v1 2/3] gpio: Add gpio delay driver Alexander Stein
2023-06-02 16:31   ` Bartosz Golaszewski
2023-04-06  9:33 ` [PATCH v1 3/3] [DNI] arm64: dts: mba8mx: Use gpio-delay for LVDS bridge Alexander Stein
2023-04-07 18:57 ` [PATCH v1 0/3] gpio: Add gpio-delay support andy.shevchenko
2023-04-11  7:19   ` Alexander Stein
2023-04-11  9:34     ` Andy Shevchenko
2023-04-14  6:37       ` Alexander Stein
2023-04-15 15:06         ` Andy Shevchenko
2023-04-16  7:42           ` Krzysztof Kozlowski
2023-04-16  9:36             ` Andy Shevchenko
2023-04-16 11:04               ` Krzysztof Kozlowski [this message]
2023-04-16 11:14                 ` Andy Shevchenko
2023-04-16 11:21                   ` Krzysztof Kozlowski
2023-04-16 11:33                     ` Andy Shevchenko
2023-04-16 11:42                       ` Krzysztof Kozlowski
2023-04-16 18:46                         ` Andy Shevchenko
2023-05-31  6:53                           ` Alexander Stein
2023-05-31 12:02                             ` Andy Shevchenko
2023-05-31 13:44                             ` Linus Walleij
2023-05-31 14:37                               ` Andy Shevchenko
2023-05-31 16:37                               ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee53f7cf-b94a-ba0f-1e28-5ffa2c0f5e78@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=brgl@bgdev.pl \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).