From: Krzysztof Kozlowski <krzk@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Rob Herring" <robh@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 03/10] pmdomain: samsung: use to devm_kstrdup_const() to simplify error handling
Date: Fri, 10 Oct 2025 02:35:00 +0200 [thread overview]
Message-ID: <ee66dca6-3cd6-41d3-82f9-d2673da00287@kernel.org> (raw)
In-Reply-To: <63fb3ccc10267add00b579d4a05497cbeeadc65e.camel@linaro.org>
On 09/10/2025 23:00, André Draszik wrote:
> On Thu, 2025-10-09 at 14:31 +0100, André Draszik wrote:
>> On Thu, 2025-10-09 at 09:13 +0900, Krzysztof Kozlowski wrote:
>>> On 07/10/2025 01:43, André Draszik wrote:
>>>> Convert to using devm_kstrdup_const() so as to simplify cleanup during
>>>> error handling.
>>>
>>>
>>> This is either a fix (then describe the fixed issue and add Fixed tag)
>>> or you change the logic, not only simplify.
>>>
>>> Previously on of_genpd_add_provider_simple() the memory was not
>>> kfree_const. Now it will be.
>>
>> Indeed it's a fix after all - While the driver doesn't allow unbind,
>
> Thinking more about it - at this stage, this patch is not a fix. The driver
> can not unbind, hence there is no leak to be plugged, hence no fix.
It is about error paths. Driver can fail binding.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-10 0:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 16:43 [PATCH 00/10] pmdomain: samsung: add supoort for Google GS101 André Draszik
2025-10-06 16:43 ` [PATCH 01/10] dt-bindings: power: samsung: add google,gs101-pd André Draszik
2025-10-07 20:46 ` Peter Griffin
2025-10-06 16:43 ` [PATCH 02/10] dt-bindings: soc: samsung: exynos-pmu: allow power domains as child on g101 André Draszik
2025-10-09 0:09 ` Krzysztof Kozlowski
2025-10-06 16:43 ` [PATCH 03/10] pmdomain: samsung: use to devm_kstrdup_const() to simplify error handling André Draszik
2025-10-07 20:53 ` Peter Griffin
2025-10-09 0:13 ` Krzysztof Kozlowski
2025-10-09 13:31 ` André Draszik
2025-10-09 14:00 ` André Draszik
2025-10-10 0:35 ` Krzysztof Kozlowski [this message]
2025-10-10 5:29 ` André Draszik
2025-10-06 16:43 ` [PATCH 04/10] pmdomain: samsung: convert to using regmap André Draszik
2025-10-06 16:43 ` [PATCH 05/10] pmdomain: samsung: convert to regmap_read_poll_timeout() André Draszik
2025-10-06 16:43 ` [PATCH 06/10] pmdomain: samsung: don't hardcode offset for registers to 0 and 4 André Draszik
2025-10-06 16:43 ` [PATCH 07/10] pmdomain: samsung: selectively handle enforced sync_state André Draszik
2025-10-09 0:15 ` Krzysztof Kozlowski
2025-10-06 16:43 ` [PATCH 08/10] pmdomain: samsung: try to get PMU (syscon) regmap André Draszik
2025-10-06 16:43 ` [PATCH 09/10] pmdomain: samsung: use dev_err() instead of pr_err() André Draszik
2025-10-09 0:18 ` Krzysztof Kozlowski
2025-10-06 16:43 ` [PATCH 10/10] pmdomain: samsung: add support for google,gs101-pd André Draszik
2025-10-09 0:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee66dca6-3cd6-41d3-82f9-d2673da00287@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).