From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81D5FC32792 for ; Tue, 23 Aug 2022 09:29:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350433AbiHWJ3t (ORCPT ); Tue, 23 Aug 2022 05:29:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350042AbiHWJ1y (ORCPT ); Tue, 23 Aug 2022 05:27:54 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D384191D15 for ; Tue, 23 Aug 2022 01:37:24 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id q18so11823234ljg.12 for ; Tue, 23 Aug 2022 01:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=+aSY9Y33CDXgz04lbF3PqxrBUx68k/v5JOdwfPTNsck=; b=QkuAXN+U7cnhI883/vPgSeyqlE+WERE888alAVsSQAP6K76e4Lq6scqjW5YP5gY4Zv gVD8rvePqRyUWnq08fWShX0UKGdz+64B0i1RmzOIMHquRKO34P4KjKVA1eQgbCOvET5c XLxKuXdMN7i7FrPlNniRLvaqe2MWHiMxe1+cKHpfOkn+zWrbYLoyoNUBJsvd/NsQRIxV 0PAJTxFQYRRA1GjSzaLlvTMnfy5dlgNal0BIxfiprXMoLEB+392bMAYUtrZkZdjn3QD4 aRNoqblddkQYhPC/kwhTpB8oFZ8tZvUr4aA/AJhU5tY5FrlelbEHmPwxWc2JqMxLkFl+ 3slw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=+aSY9Y33CDXgz04lbF3PqxrBUx68k/v5JOdwfPTNsck=; b=4gWBQgraI3dCQZ1w+At3h35j5OIPjGsnfhiUmdfqCPeA/tG7TTwOispsgNZ5IJ8JgT ati3aemcEpbGnNRN2u3dYQnuZrtiYEqXFBSZOZbZOsEgnBf6NONG/Lcg1u85VbXlZTup uN82Uw5nL3bmkCxZ4ZIStVwxwyxqQJf9/hQmcpQNxtgxrouy2YzKuAirKDinMm8yXixh CUt5GXh1thfKZyfpPRMYCqFGPQNWGCYR/Px0laCx6GWwB2anQFOKqJQIellV/rPasunc tqeBrqCnKOMzFWpAR6MxAkS0UQfzGc1lRycvDhpLBFrsIaELXIFmXerfgUJg07JNhmvS xvRw== X-Gm-Message-State: ACgBeo3O3bvOdEHQNahkrKk3IaefuWg7MwUBQpzDi6faSee4jzhwXyFh hJKAOVdxo9oIVu7KnobrSqIJGQ== X-Google-Smtp-Source: AA6agR4tz09nxCgU4KECChD6CEX8ta0EVwvv34zu7NRW9WZuo44ysLqMs2v/JFtkNU1OgDp8eiWwiw== X-Received: by 2002:a2e:9d06:0:b0:261:d208:7475 with SMTP id t6-20020a2e9d06000000b00261d2087475mr1683044lji.113.1661243791045; Tue, 23 Aug 2022 01:36:31 -0700 (PDT) Received: from [192.168.0.11] (89-27-92-210.bb.dnainternet.fi. [89.27.92.210]) by smtp.gmail.com with ESMTPSA id p18-20020a2eb992000000b00261ca006158sm1243319ljp.54.2022.08.23.01.36.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 01:36:30 -0700 (PDT) Message-ID: Date: Tue, 23 Aug 2022 11:36:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1 1/1] dt-bindings: phy: ocelot-serdes: convert to YAML Content-Language: en-US To: Colin Foster , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org Cc: UNGLinuxDriver@microchip.com, Alexandre Belloni , Krzysztof Kozlowski , Rob Herring , Vinod Koul , Kishon Vijay Abraham I References: <20220823060052.3921849-1-colin.foster@in-advantage.com> <20220823060052.3921849-2-colin.foster@in-advantage.com> From: Krzysztof Kozlowski In-Reply-To: <20220823060052.3921849-2-colin.foster@in-advantage.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/08/2022 09:00, Colin Foster wrote: > Convert the phy-ocelot-serdes device tree binding to the new YAML format. > > Additionally, add the file to MAINTAINERS since the original file didn't > exist. > > Signed-off-by: Colin Foster > --- > .../bindings/phy/phy-ocelot-serdes.txt | 43 ------------- > .../bindings/phy/phy-ocelot-serdes.yaml | 61 +++++++++++++++++++ > MAINTAINERS | 1 + > 3 files changed, 62 insertions(+), 43 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/phy/phy-ocelot-serdes.txt > create mode 100644 Documentation/devicetree/bindings/phy/phy-ocelot-serdes.yaml Filename based on compatible, so mscc,vsc7514-serdes.yaml > > diff --git a/Documentation/devicetree/bindings/phy/phy-ocelot-serdes.yaml b/Documentation/devicetree/bindings/phy/phy-ocelot-serdes.yaml > new file mode 100644 > index 000000000000..0666974d886a > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-ocelot-serdes.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/phy-ocelot-serdes.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microsemi Ocelot SerDes muxing driver s/driver// Bindings are for hardware, not for Linux drivers. > + > +maintainers: > + - Alexandre Belloni > + - UNGLinuxDriver@microchip.com > + > +description: | > + On Microsemi Ocelot, there is a handful of registers in HSIO address > + space for setting up the SerDes to switch port muxing. > + > + A SerDes X can be "muxed" to work with switch port Y or Z for example. > + One specific SerDes can also be used as a PCIe interface. > + > + Hence, a SerDes represents an interface, be it an Ethernet or a PCIe one. > + > + There are two kinds of SerDes: SERDES1G supports 10/100Mbps in > + half/full-duplex and 1000Mbps in full-duplex mode while SERDES6G supports > + 10/100Mbps in half/full-duplex and 1000/2500Mbps in full-duplex mode. > + > + Also, SERDES6G number (aka "macro") 0 is the only interface supporting > + QSGMII. > + > + This is a child of the HSIO syscon ("mscc,ocelot-hsio", see > + Documentation/devicetree/bindings/mips/mscc.txt) on the Microsemi Ocelot. > + > +properties: > + compatible: > + enum: > + - mscc,vsc7514-serdes Missing blank line > + "#phy-cells": > + const: 2 > + description: | > + from the generic phy bindings, must be 2. Skip first sentence, it's obvious. The first number > + defines the input port to use for a given SerDes macro. The > + second defines the macro to use. They are defined in > + dt-bindings/phy/phy-ocelot-serdes.h > + > +required: > + - compatible > + - "#phy-cells" Missing additionalProperties: false Base your YAML on example-schema. > + > +examlpes: Typo. > + - | > + serdes: serdes { > + compatible = "mscc,vsc7514-serdes"; > + #phy-cells = <2>; > + }; > + > + ethernet { > + port1 { > + phy-handle = <&phy_foo>; > + /* Link SERDES1G_5 to port1 */ > + phys = <&serdes 1 SERDES1G_5>; > + }; > + }; Skip consumer examples in provider bindings. They're obvious. > diff --git a/MAINTAINERS b/MAINTAINERS > index 714fd8b45e5a..10dd3c6ad6ad 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -13481,6 +13481,7 @@ M: UNGLinuxDriver@microchip.com > L: linux-mips@vger.kernel.org > S: Supported > F: Documentation/devicetree/bindings/mips/mscc.txt > +F: Documentation/devicetree/bindings/phy/phy-ocelot-serdes.yaml > F: Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.yaml > F: Documentation/devicetree/bindings/power/reset/ocelot-reset.txt > F: arch/mips/boot/dts/mscc/ Best regards, Krzysztof