* [RFC PATCH] regulator: dt-bindings: qcom-labibb: Allow regulator-common properties
@ 2023-01-16 9:25 Konrad Dybcio
2023-01-17 8:51 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Dybcio @ 2023-01-16 9:25 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Konrad Dybcio, Liam Girdwood, Mark Brown,
Rob Herring, Krzysztof Kozlowski, Sumit Semwal, linux-kernel,
devicetree
Allow regulator-common properties on lab/ibb regulators, such as
regulator-always-on, etc.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
.../bindings/regulator/qcom-labibb-regulator.yaml | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
index f97b8083678f..c0be7d5a6d40 100644
--- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
@@ -20,7 +20,8 @@ properties:
lab:
type: object
- additionalProperties: false
+ $ref: "regulator.yaml#"
+ unevaluatedProperties: false
properties:
qcom,soft-start-us:
@@ -46,7 +47,8 @@ properties:
ibb:
type: object
- additionalProperties: false
+ $ref: "regulator.yaml#"
+ unevaluatedProperties: false
properties:
qcom,discharge-resistor-kohms:
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] regulator: dt-bindings: qcom-labibb: Allow regulator-common properties
2023-01-16 9:25 [RFC PATCH] regulator: dt-bindings: qcom-labibb: Allow regulator-common properties Konrad Dybcio
@ 2023-01-17 8:51 ` Krzysztof Kozlowski
2023-01-18 12:26 ` Konrad Dybcio
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-17 8:51 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross
Cc: marijn.suijten, Liam Girdwood, Mark Brown, Rob Herring,
Krzysztof Kozlowski, Sumit Semwal, linux-kernel, devicetree
On 16/01/2023 10:25, Konrad Dybcio wrote:
> Allow regulator-common properties on lab/ibb regulators, such as
> regulator-always-on, etc.
Are these proper regulators? If so this looks sensible. Why calling it
RFC? What is here questionable?
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> .../bindings/regulator/qcom-labibb-regulator.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> index f97b8083678f..c0be7d5a6d40 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> @@ -20,7 +20,8 @@ properties:
>
> lab:
> type: object
> - additionalProperties: false
> + $ref: "regulator.yaml#"
Drop quotes.
> + unevaluatedProperties: false
>
> properties:
> qcom,soft-start-us:
> @@ -46,7 +47,8 @@ properties:
>
> ibb:
> type: object
> - additionalProperties: false
> + $ref: "regulator.yaml#"
Drop quotes.
> + unevaluatedProperties: false
>
> properties:
> qcom,discharge-resistor-kohms:
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] regulator: dt-bindings: qcom-labibb: Allow regulator-common properties
2023-01-17 8:51 ` Krzysztof Kozlowski
@ 2023-01-18 12:26 ` Konrad Dybcio
0 siblings, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-01-18 12:26 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-arm-msm, andersson, agross
Cc: marijn.suijten, Liam Girdwood, Mark Brown, Rob Herring,
Krzysztof Kozlowski, Sumit Semwal, linux-kernel, devicetree
On 17.01.2023 09:51, Krzysztof Kozlowski wrote:
> On 16/01/2023 10:25, Konrad Dybcio wrote:
>> Allow regulator-common properties on lab/ibb regulators, such as
>> regulator-always-on, etc.
>
> Are these proper regulators? If so this looks sensible. Why calling it
> RFC? What is here questionable?
I really had no idea if this was the proper way to do it, but
dt_bindings_check and CHECK_DTBS+example dt were happy..
>
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> .../bindings/regulator/qcom-labibb-regulator.yaml | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
>> index f97b8083678f..c0be7d5a6d40 100644
>> --- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
>> +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
>> @@ -20,7 +20,8 @@ properties:
>>
>> lab:
>> type: object
>> - additionalProperties: false
>> + $ref: "regulator.yaml#"
>
> Drop quotes.
>
>> + unevaluatedProperties: false
>>
>> properties:
>> qcom,soft-start-us:
>> @@ -46,7 +47,8 @@ properties:
>>
>> ibb:
>> type: object
>> - additionalProperties: false
>> + $ref: "regulator.yaml#"
>
> Drop quotes.
Ack x2
Konrad
>
>> + unevaluatedProperties: false
>>
>> properties:
>> qcom,discharge-resistor-kohms:
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-18 13:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-16 9:25 [RFC PATCH] regulator: dt-bindings: qcom-labibb: Allow regulator-common properties Konrad Dybcio
2023-01-17 8:51 ` Krzysztof Kozlowski
2023-01-18 12:26 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).