From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF6B8C3DA78 for ; Tue, 17 Jan 2023 08:52:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235853AbjAQIwx (ORCPT ); Tue, 17 Jan 2023 03:52:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235576AbjAQIwa (ORCPT ); Tue, 17 Jan 2023 03:52:30 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BD722CFED for ; Tue, 17 Jan 2023 00:51:46 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id k22-20020a05600c1c9600b003d1ee3a6289so23853139wms.2 for ; Tue, 17 Jan 2023 00:51:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=expaoc4a1kUuojomtX/CBeI3GGcWe8iG4JOwm7tA2Ms=; b=GCBuP2ME3LEmq3d288LClfQ+DDoceb7qejVUCKci1Io3+3RT81PEq0YzI+C1ZzwsT5 6WyQCYKa7CiON2FBCWKBC+ZrjoPsaFO5JDZTtLTblFsb0I90j7ED6EsBVKGyb9eMbfjW zL/aWSzykK4zTaUc4GgVZs/QUjdTlpK4BCVtJBhNAGmInT8k0Gh9CUOdgUMk/69WsWqI T0liqYDKLBb7PqCc5cJAcgK/89PPlPM8ZoGDAHIjm6wK+/lYKZGo9fhmW0b7V9ja1joI iA76KK54eIYL7LNUe07Mnj7MuYHzX2Q2/qBEMEkGW/HVJ9ZGhJpKcr5egZmElAtKO/yS J6aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=expaoc4a1kUuojomtX/CBeI3GGcWe8iG4JOwm7tA2Ms=; b=OBLzPqWgh7QO1cIE46Am9IpblDS8P4b7E6MsbebHKUaf5yMk+Xc2en/pi+JQl4oWWZ Faja80SsHjy4VwV4/EMOpwzZxbGHmcBICLzpJwl2Zlsw3wz54rqfo79IP5lAXWCKMJla 4zV8rTCbAUi6t9kVjUkrir2X+M6YdwmJf9ccHMIcIIFyWdedeuTm1j40BpvxtVGmPe0O xfBhItAaPlENqKV1FJHOkijELA+elm/yw6zJVHYRSWrLFJuMz5rZC5h2AuwkZcZOGo/N B9HEbXi0VW+5YMUHL0OUezePGv4H0AWsL1Lxyct2omyr2aAJPRS0ApK64ozVo0uFWOrO sU5w== X-Gm-Message-State: AFqh2kp56VfJ9koFhbPcYtdcIoKh1J18wC9Tvx7K35MMNJfYvVaBwzSy q5HLnWWJv+LtWSiKiDdPxY7VLw== X-Google-Smtp-Source: AMrXdXueXFpF3XR7NYfg4P+jSjPuEvD2oSEf8abJxzrHhstw07/IPA3YDM4cBB/MjzxBAzfHOuxzSA== X-Received: by 2002:a05:600c:5006:b0:3da:f92a:5446 with SMTP id n6-20020a05600c500600b003daf92a5446mr2418854wmr.27.1673945504969; Tue, 17 Jan 2023 00:51:44 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h19-20020a05600c351300b003d9a86a13bfsm39331066wmq.28.2023.01.17.00.51.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jan 2023 00:51:44 -0800 (PST) Message-ID: Date: Tue, 17 Jan 2023 09:51:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH] regulator: dt-bindings: qcom-labibb: Allow regulator-common properties Content-Language: en-US To: Konrad Dybcio , linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Sumit Semwal , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20230116092502.71146-1-konrad.dybcio@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230116092502.71146-1-konrad.dybcio@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/01/2023 10:25, Konrad Dybcio wrote: > Allow regulator-common properties on lab/ibb regulators, such as > regulator-always-on, etc. Are these proper regulators? If so this looks sensible. Why calling it RFC? What is here questionable? > > Signed-off-by: Konrad Dybcio > --- > .../bindings/regulator/qcom-labibb-regulator.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml > index f97b8083678f..c0be7d5a6d40 100644 > --- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml > +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml > @@ -20,7 +20,8 @@ properties: > > lab: > type: object > - additionalProperties: false > + $ref: "regulator.yaml#" Drop quotes. > + unevaluatedProperties: false > > properties: > qcom,soft-start-us: > @@ -46,7 +47,8 @@ properties: > > ibb: > type: object > - additionalProperties: false > + $ref: "regulator.yaml#" Drop quotes. > + unevaluatedProperties: false > > properties: > qcom,discharge-resistor-kohms: Best regards, Krzysztof