From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, robh+dt@kernel.org,
agross@kernel.org, devicetree@vger.kernel.org,
andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated
Date: Sat, 10 Sep 2022 18:22:02 +0100 [thread overview]
Message-ID: <ee9f1ba2-cc53-beeb-7f96-5d1097f8e2e7@linaro.org> (raw)
In-Reply-To: <1662821635.164850.34696.nullmailer@robh.at.kernel.org>
On 10/09/2022 15:53, Rob Herring wrote:
> On Sat, 10 Sep 2022 02:42:06 +0100, Bryan O'Donoghue wrote:
>> We've had some discongruity in the compatible string of the lpass for 8916
>> for a while.
>>
>> Mark the old compat as deprecated. New SoC additions such as msm8936 and
>> msm8939 should use the compat string "qcom,apq8016-lpass-cpu".
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
>> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 13 ++++++++-----
>> 1 file changed, 8 insertions(+), 5 deletions(-)
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml:23:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>
> dtschema/dtc warnings/errors:
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
Bah, you were right.
I didn't see this in the noise generated by the tool
/home/deckard/Development/qualcomm/qlt-kernel/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml:23:9:
[warning] wrong indentation: expected 10 but found 8 (indentation)
Is there some way to slim the output down to just the yaml file I am
interested in ?
Dmitry submitted a patch for this at some stage I think
next prev parent reply other threads:[~2022-09-10 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 1:42 [PATCH v2 0/1] Update apq8016 lpass-cpu compat string Bryan O'Donoghue
2022-09-10 1:42 ` [PATCH v2 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated Bryan O'Donoghue
2022-09-10 7:55 ` Krzysztof Kozlowski
2022-09-10 11:10 ` Bryan O'Donoghue
2022-09-10 14:53 ` Rob Herring
2022-09-10 17:22 ` Bryan O'Donoghue [this message]
2022-09-11 13:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee9f1ba2-cc53-beeb-7f96-5d1097f8e2e7@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).