From: Chanwoo Choi <chanwoo@kernel.org>
To: david@ixit.cz, MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v2] dt-bindings: extcon: linux,extcon-usb-gpio: GPIO must be provided
Date: Sat, 6 Sep 2025 21:32:11 +0900 [thread overview]
Message-ID: <eeb4df05-ded6-4cc4-9d6f-8daf08d6ac36@kernel.org> (raw)
In-Reply-To: <20250904-yaml-extcon-usb-gpio-v2-1-a5c4afa496c3@ixit.cz>
25. 9. 5. 05:41에 David Heidelberg via B4 Relay 이(가) 쓴 글:
> From: David Heidelberg <david@ixit.cz>
>
> Without providing either ID or VBUS GPIO the driver is not able to operate.
> Original text binding says:
> "Either one of id-gpio or vbus-gpio must be present."
>
> Fixes: 79a31ce03f41 ("dt-bindings: extcon: convert extcon-usb-gpio.txt to yaml format")
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Changes in v2:
> - Rebased and added Conor A-b.
> - Link to v1: https://lore.kernel.org/r/20250329-yaml-extcon-usb-gpio-v1-1-190696e53a0b@ixit.cz
> ---
> Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml b/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml
> index 8856107bdd33b8654812ab9c97e85e23dc2ef75a..8f29d333602b95fe5ccd8464aa64e2d1f0c1c781 100644
> --- a/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml
> +++ b/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml
> @@ -25,6 +25,12 @@ properties:
> required:
> - compatible
>
> +anyOf:
> + - required:
> + - id-gpios
> + - required:
> + - vbus-gpios
> +
> additionalProperties: false
>
> examples:
>
> ---
> base-commit: 4ac65880ebca1b68495bd8704263b26c050ac010
> change-id: 20250329-yaml-extcon-usb-gpio-251b66522287
>
> Best regards,
Hi,
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
prev parent reply other threads:[~2025-09-06 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 20:41 [PATCH v2] dt-bindings: extcon: linux,extcon-usb-gpio: GPIO must be provided David Heidelberg via B4 Relay
2025-09-06 12:32 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeb4df05-ded6-4cc4-9d6f-8daf08d6ac36@kernel.org \
--to=chanwoo@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=cw00.choi@samsung.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).