[PATCH v1 0/1] Enable BT for qcs8300-ride

[PATCH v1 0/1] Enable BT for qcs8300-ride

[Cheng Jiang]

Enable the BT subsystem of the qcs8300 ride board.

Cheng Jiang (1):
  arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride

 arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)


base-commit: df5d6180169ae06a2eac57e33b077ad6f6252440
prerequisite-patch-id: 7777ec69b5f2389a2efdb0bda561b067da72abfb
prerequisite-patch-id: e6140f9abf38172e77875f126da90bde6e1829cb
prerequisite-patch-id: c4e0283b4bce4c4e0566d7783f8ccd7fcaaebd3f
prerequisite-patch-id: c87e5f1cb29568c24566e8a960d6c8dd0be5969d
prerequisite-patch-id: f80a486c6e34dfb62f09faf0eb3fae586cda85ec
prerequisite-patch-id: 0e2cb7a4d8779539a58261111deea6bd6b750f6f
prerequisite-patch-id: edd904882daa9ed31340710e36905c82c4552c8e
prerequisite-patch-id: 28493e0ec65dc01bd8f8e2e82beea6295944e6e6
prerequisite-patch-id: 29da1304862005c0fbe32230b47ce6d270518b04
prerequisite-patch-id: a796c820ab0b76a1b56b32480a83dbf5cb1cdab7
-- 
2.34.1

[PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride

[Cheng Jiang]

Enable BT on qcs8300-ride by adding a node for the BT module. Since the
platform uses the QCA6698 Bluetooth chip. While the QCA6698 shares th
same IP core as the WCN6855, it has different RF components and RAM sizes,
requiring new firmware files. Use the firmware-name property to specify
the NVM and rampatch firmware to load.

Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 24 +++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index a6991e8e2df6..93458773b72d 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -17,6 +17,7 @@ / {
 
 	aliases {
 		serial0 = &uart7;
+		serial1 = &uart2;
 	};
 
 	chosen {
@@ -451,6 +452,13 @@ &serdes0 {
 };
 
 &tlmm {
+	bt_en_state: bt-en-state {
+		pins = "gpio55";
+		function = "normal";
+		output-low;
+		bias-pull-down;
+	};
+
 	ethernet0_default: ethernet0-default-state {
 		ethernet0_mdc: ethernet0-mdc-pins {
 			pins = "gpio5";
@@ -544,6 +552,22 @@ wlan_en_state: wlan-en-state {
 	};
 };
 
+&uart2 {
+	status = "okay";
+	bluetooth: bluetooth {
+		compatible = "qcom,wcn6855-bt";
+		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&bt_en_state>;
+		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
+
+		vddio-supply       = <&vreg_conn_pa>;         /* bt-vdd-ctrl1-supply */
+		vddbtcxmx-supply   = <&vreg_conn_1p8>;        /* bt-vdd-ctrl2-supply */
+		max-speed = <3200000>;
+	};
+};
+
 &uart7 {
 	status = "okay";
 };
-- 
2.34.1

Re: [PATCH v1 0/1] Enable BT for qcs8300-ride

[Krzysztof Kozlowski]

On 11/02/2025 11:44, Cheng Jiang wrote:
> Enable the BT subsystem of the qcs8300 ride board.
> 
> Cheng Jiang (1):
>   arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride
> 
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> 
> base-commit: df5d6180169ae06a2eac57e33b077ad6f6252440
> prerequisite-patch-id: 7777ec69b5f2389a2efdb0bda561b067da72abfb
> prerequisite-patch-id: e6140f9abf38172e77875f126da90bde6e1829cb
> prerequisite-patch-id: c4e0283b4bce4c4e0566d7783f8ccd7fcaaebd3f
> prerequisite-patch-id: c87e5f1cb29568c24566e8a960d6c8dd0be5969d
> prerequisite-patch-id: f80a486c6e34dfb62f09faf0eb3fae586cda85ec
> prerequisite-patch-id: 0e2cb7a4d8779539a58261111deea6bd6b750f6f
> prerequisite-patch-id: edd904882daa9ed31340710e36905c82c4552c8e
> prerequisite-patch-id: 28493e0ec65dc01bd8f8e2e82beea6295944e6e6
> prerequisite-patch-id: 29da1304862005c0fbe32230b47ce6d270518b04
> prerequisite-patch-id: a796c820ab0b76a1b56b32480a83dbf5cb1cdab7


That's a lot of dependencies. Why isn't this just squashed in original
patchset?


Best regards,
Krzysztof

Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride

[Krzysztof Kozlowski]

On 11/02/2025 11:44, Cheng Jiang wrote:
>  	};
>  };
>  
> +&uart2 {
> +	status = "okay";
> +	bluetooth: bluetooth {

Why do you need the label?

> +		compatible = "qcom,wcn6855-bt";
> +		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&bt_en_state>;
> +		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
> +
> +		vddio-supply       = <&vreg_conn_pa>;         /* bt-vdd-ctrl1-supply */
> +		vddbtcxmx-supply   = <&vreg_conn_1p8>;        /* bt-vdd-ctrl2-supply */

Only one space before '='.

I think this has multiple test failures.

Best regards,
Krzysztof

Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride

[Konrad Dybcio]

On 11.02.2025 11:44 AM, Cheng Jiang wrote:
> Enable BT on qcs8300-ride by adding a node for the BT module. Since the
> platform uses the QCA6698 Bluetooth chip. While the QCA6698 shares th
> same IP core as the WCN6855, it has different RF components and RAM sizes,
> requiring new firmware files. Use the firmware-name property to specify
> the NVM and rampatch firmware to load.
> 
> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 24 +++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index a6991e8e2df6..93458773b72d 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -17,6 +17,7 @@ / {
>  
>  	aliases {
>  		serial0 = &uart7;
> +		serial1 = &uart2;
>  	};
>  
>  	chosen {
> @@ -451,6 +452,13 @@ &serdes0 {
>  };
>  
>  &tlmm {
> +	bt_en_state: bt-en-state {
> +		pins = "gpio55";
> +		function = "normal";
> +		output-low;
> +		bias-pull-down;
> +	};
> +
>  	ethernet0_default: ethernet0-default-state {
>  		ethernet0_mdc: ethernet0-mdc-pins {
>  			pins = "gpio5";
> @@ -544,6 +552,22 @@ wlan_en_state: wlan-en-state {
>  	};
>  };
>  
> +&uart2 {
> +	status = "okay";
> +	bluetooth: bluetooth {

Please add a newline between the last property and subnodes

> +		compatible = "qcom,wcn6855-bt";
> +		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&bt_en_state>;

You should use qcom,wcn6855-pmu (see e.g. sc8280xp-crd.dts)

> +		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
> +
> +		vddio-supply       = <&vreg_conn_pa>;         /* bt-vdd-ctrl1-supply */
> +		vddbtcxmx-supply   = <&vreg_conn_1p8>;        /* bt-vdd-ctrl2-supply */

Drop these comments

Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride

[Cheng Jiang]

Hi Krzysztof,

On 2/11/2025 7:03 PM, Krzysztof Kozlowski wrote:
> On 11/02/2025 11:44, Cheng Jiang wrote:
>>  	};
>>  };
>>  
>> +&uart2 {
>> +	status = "okay";
>> +	bluetooth: bluetooth {
> 
> Why do you need the label?
> 
Yes, label is not needed. 
>> +		compatible = "qcom,wcn6855-bt";
>> +		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
>> +
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&bt_en_state>;
>> +		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
>> +
>> +		vddio-supply       = <&vreg_conn_pa>;         /* bt-vdd-ctrl1-supply */
>> +		vddbtcxmx-supply   = <&vreg_conn_1p8>;        /* bt-vdd-ctrl2-supply */
> 
> Only one space before '='.
> 
> I think this has multiple test failures.
> 
Ack, Will change in next version. 

> Best regards,
> Krzysztof

Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride

[Cheng Jiang]

Hi Konrad,

On 2/11/2025 10:34 PM, Konrad Dybcio wrote:
> On 11.02.2025 11:44 AM, Cheng Jiang wrote:
>> Enable BT on qcs8300-ride by adding a node for the BT module. Since the
>> platform uses the QCA6698 Bluetooth chip. While the QCA6698 shares th
>> same IP core as the WCN6855, it has different RF components and RAM sizes,
>> requiring new firmware files. Use the firmware-name property to specify
>> the NVM and rampatch firmware to load.
>>
>> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 24 +++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> index a6991e8e2df6..93458773b72d 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> @@ -17,6 +17,7 @@ / {
>>  
>>  	aliases {
>>  		serial0 = &uart7;
>> +		serial1 = &uart2;
>>  	};
>>  
>>  	chosen {
>> @@ -451,6 +452,13 @@ &serdes0 {
>>  };
>>  
>>  &tlmm {
>> +	bt_en_state: bt-en-state {
>> +		pins = "gpio55";
>> +		function = "normal";
>> +		output-low;
>> +		bias-pull-down;
>> +	};
>> +
>>  	ethernet0_default: ethernet0-default-state {
>>  		ethernet0_mdc: ethernet0-mdc-pins {
>>  			pins = "gpio5";
>> @@ -544,6 +552,22 @@ wlan_en_state: wlan-en-state {
>>  	};
>>  };
>>  
>> +&uart2 {
>> +	status = "okay";
>> +	bluetooth: bluetooth {
> 
> Please add a newline between the last property and subnodes
> 
Ack.
>> +		compatible = "qcom,wcn6855-bt";
>> +		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
>> +
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&bt_en_state>;
> 
> You should use qcom,wcn6855-pmu (see e.g. sc8280xp-crd.dts)
> 
Ack. Will use the power sequence for BT power control. 
>> +		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
>> +
>> +		vddio-supply       = <&vreg_conn_pa>;         /* bt-vdd-ctrl1-supply */
>> +		vddbtcxmx-supply   = <&vreg_conn_1p8>;        /* bt-vdd-ctrl2-supply */
> 
> Drop these comments
> 
Ack.

Re: [PATCH v1 0/1] Enable BT for qcs8300-ride

[Cheng Jiang]

Hi Krzysztof,

On 2/11/2025 7:01 PM, Krzysztof Kozlowski wrote:
> On 11/02/2025 11:44, Cheng Jiang wrote:
>> Enable the BT subsystem of the qcs8300 ride board.
>>
>> Cheng Jiang (1):
>>   arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride
>>
>>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>>
>> base-commit: df5d6180169ae06a2eac57e33b077ad6f6252440
>> prerequisite-patch-id: 7777ec69b5f2389a2efdb0bda561b067da72abfb
>> prerequisite-patch-id: e6140f9abf38172e77875f126da90bde6e1829cb
>> prerequisite-patch-id: c4e0283b4bce4c4e0566d7783f8ccd7fcaaebd3f
>> prerequisite-patch-id: c87e5f1cb29568c24566e8a960d6c8dd0be5969d
>> prerequisite-patch-id: f80a486c6e34dfb62f09faf0eb3fae586cda85ec
>> prerequisite-patch-id: 0e2cb7a4d8779539a58261111deea6bd6b750f6f
>> prerequisite-patch-id: edd904882daa9ed31340710e36905c82c4552c8e
>> prerequisite-patch-id: 28493e0ec65dc01bd8f8e2e82beea6295944e6e6
>> prerequisite-patch-id: 29da1304862005c0fbe32230b47ce6d270518b04
>> prerequisite-patch-id: a796c820ab0b76a1b56b32480a83dbf5cb1cdab7
> 
> 
> That's a lot of dependencies. Why isn't this just squashed in original
> patchset?
> 
Yes, this is a new platform with many pending changes that have not yet 
been merged. The BT DTS change depends on the PMIC, UART, and PMU. I 
will wait for the other components to be merged before submitting a 
new version. Thank you for your comments.
> 
> Best regards,
> Krzysztof

Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride

[Krzysztof Kozlowski]

On 13/02/2025 06:56, Cheng Jiang wrote:
> Yes, label is not needed. 
>>> +		compatible = "qcom,wcn6855-bt";
>>> +		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
>>> +
>>> +		pinctrl-names = "default";
>>> +		pinctrl-0 = <&bt_en_state>;
>>> +		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
>>> +
>>> +		vddio-supply       = <&vreg_conn_pa>;         /* bt-vdd-ctrl1-supply */
>>> +		vddbtcxmx-supply   = <&vreg_conn_1p8>;        /* bt-vdd-ctrl2-supply */
>>
>> Only one space before '='.
>>
>> I think this has multiple test failures.
>>
> Ack, Will change in next version. 

Are you going to test it as well?

Best regards,
Krzysztof

Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride

[Cheng Jiang]

Hi Krzysztof,

On 2/13/2025 3:36 PM, Krzysztof Kozlowski wrote:
> On 13/02/2025 06:56, Cheng Jiang wrote:
>> Yes, label is not needed. 
>>>> +		compatible = "qcom,wcn6855-bt";
>>>> +		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
>>>> +
>>>> +		pinctrl-names = "default";
>>>> +		pinctrl-0 = <&bt_en_state>;
>>>> +		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
>>>> +
>>>> +		vddio-supply       = <&vreg_conn_pa>;         /* bt-vdd-ctrl1-supply */
>>>> +		vddbtcxmx-supply   = <&vreg_conn_1p8>;        /* bt-vdd-ctrl2-supply */
>>>
>>> Only one space before '='.
>>>
>>> I think this has multiple test failures.
>>>
>> Ack, Will change in next version. 
> 
> Are you going to test it as well?
> 
Yes, I will test it. Thanks! 

> Best regards,
> Krzysztof

Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride

[Dmitry Baryshkov]

On Tue, Feb 11, 2025 at 06:44:21PM +0800, Cheng Jiang wrote:
> Enable BT on qcs8300-ride by adding a node for the BT module. Since the
> platform uses the QCA6698 Bluetooth chip. While the QCA6698 shares th
> same IP core as the WCN6855, it has different RF components and RAM sizes,
> requiring new firmware files. Use the firmware-name property to specify
> the NVM and rampatch firmware to load.
> 
> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 24 +++++++++++++++++++++++
>  1 file changed, 24 insertions(+)

Just so that it doesn't get lost. It should be rebased on top of WiFi patchset ([1])

[1] https://lore.kernel.org/linux-arm-msm/20250325075331.1662306-1-quic_stonez@quicinc.com/

-- 
With best wishes
Dmitry