Re: [PATCH v3 2/4] soc: qcom: pmic_glink: Introduce base PMIC GLINK driver

[Neil Armstrong <neil.armstrong@linaro.org>]

On 30/01/2023 05:20, Bjorn Andersson wrote:
> From: Bjorn Andersson <bjorn.andersson@linaro.org>
> 
> The PMIC GLINK service runs on one of the co-processors of some modern
> Qualcomm platforms and implements USB-C and battery managements. It uses
> a message based protocol over GLINK for communication with the OS, hence
> the name.
> 
> The driver implemented provides the rpmsg device for communication and
> uses auxiliary bus to spawn off individual devices in respective
> subsystem. The auxiliary devices are spawned off from a
> platform_device, so that the drm_bridge is available early, to allow the
> DisplayPort driver to probe even before the remoteproc has spun up.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Tested-by: Konrad Dybcio <konrad.dybcio@linaro.org> # SM8350 PDX215
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
> 
> Changes since v2:
> - None
> 
>   drivers/soc/qcom/Kconfig            |  15 ++
>   drivers/soc/qcom/Makefile           |   1 +
>   drivers/soc/qcom/pmic_glink.c       | 336 ++++++++++++++++++++++++++++
>   include/linux/soc/qcom/pmic_glink.h |  32 +++
>   4 files changed, 384 insertions(+)
>   create mode 100644 drivers/soc/qcom/pmic_glink.c
>   create mode 100644 include/linux/soc/qcom/pmic_glink.h
> 

<snip>


Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-MTP & SM8450-HDK