From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3C6C61DA4 for ; Mon, 30 Jan 2023 14:29:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237179AbjA3O32 (ORCPT ); Mon, 30 Jan 2023 09:29:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237708AbjA3O3M (ORCPT ); Mon, 30 Jan 2023 09:29:12 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C67955FC0 for ; Mon, 30 Jan 2023 06:28:06 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id j32-20020a05600c1c2000b003dc4fd6e61dso3306465wms.5 for ; Mon, 30 Jan 2023 06:28:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=qKdXk/omSiAj1zB29OCY6KCCz70BntsFebdtzKnA+6Q=; b=qp5H5QXrd63klWczEQY29BOAI58DUzZ5uzYFsSFN1FiyRpRSZSPvQozWGE3ujG7MvF X7QSTkudv320mdeRZUPEopARPSuyQE4Ua94dOePKfcu5WLd0IgWTCv8SY3Y0UpCOa26c x0cJlS4RB5sV8CkLXZpPJ2kWNkVUBBKVoSsYri3F4Kvf7hq4QQTfADlrSF7sYh6XAQnT SxK7SlfdszGtzGR83Jw53www+SMOtr8w00Xgub0i7AmDdVdi+K1zu9ACbffy7CntqUWb fcoYK+VtCiH0268RmZbhtn27SaN9v4dwEO/tQNy8QAWTM2xqXP0gYa3cZVUrI5Jgq1AO i/2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qKdXk/omSiAj1zB29OCY6KCCz70BntsFebdtzKnA+6Q=; b=MFYJ/77nJWO5Y+YDA3J1zTHwHAfXUdohDAlYXza9rUpheW5qsYvFUlfFWV8cvG3yig XBX970oDpSOJsDpwsJBDRl0vk7DUx+mvuy0oXbc3YVc/bu3clYj7wtStWDgLRwkZLDci 9TcqZlF5HyWNKtyixUkdpTz4OVNqEXJfJ9h6wEovTp90cU4VCkjGW9aHXFucFrtYUVh8 JxLs3V21ThCkZJrnkUmGIfU52Mvl+6gxX/Xpqvg9zV3CzP3uEyIEiStTuWRrWgCgp4Oa Pw6HY8IEsgFLL7BJGwqR0VO7+Xh0SKRTcpj8IQFjRyBbQ567pkXF9++/ke6TbyvTwlCw 4LvQ== X-Gm-Message-State: AO0yUKV+Yha2BPADVKmPgC6IseU6zp7VHPTl1CxA+E6qJry8Uozyn+7d cJdx/BFyCJl2XkGEyRKo9r/SCw== X-Google-Smtp-Source: AK7set8hAxBEDnJQdA7HZtbQF42tcRjmtazRUUcVz0a1nnzvOFQqd9FgvXHKEGKf+8ElIiixb6axMw== X-Received: by 2002:a05:600c:a07:b0:3dc:2137:d67d with SMTP id z7-20020a05600c0a0700b003dc2137d67dmr19055856wmp.16.1675088885275; Mon, 30 Jan 2023 06:28:05 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:5f17:219:cb05:7cd? ([2a01:e0a:982:cbb0:5f17:219:cb05:7cd]) by smtp.gmail.com with ESMTPSA id y21-20020a05600c17d500b003dc46242c4csm7805760wmo.10.2023.01.30.06.28.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 06:28:04 -0800 (PST) Message-ID: Date: Mon, 30 Jan 2023 15:28:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v3 2/4] soc: qcom: pmic_glink: Introduce base PMIC GLINK driver Content-Language: en-US To: Bjorn Andersson , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Sebastian Reichel Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Subbaraman Narayanamurthy , Johan Hovold References: <20230130042003.577063-1-quic_bjorande@quicinc.com> <20230130042003.577063-3-quic_bjorande@quicinc.com> Organization: Linaro Developer Services In-Reply-To: <20230130042003.577063-3-quic_bjorande@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/01/2023 05:20, Bjorn Andersson wrote: > From: Bjorn Andersson > > The PMIC GLINK service runs on one of the co-processors of some modern > Qualcomm platforms and implements USB-C and battery managements. It uses > a message based protocol over GLINK for communication with the OS, hence > the name. > > The driver implemented provides the rpmsg device for communication and > uses auxiliary bus to spawn off individual devices in respective > subsystem. The auxiliary devices are spawned off from a > platform_device, so that the drm_bridge is available early, to allow the > DisplayPort driver to probe even before the remoteproc has spun up. > > Signed-off-by: Bjorn Andersson > Tested-by: Konrad Dybcio # SM8350 PDX215 > Signed-off-by: Bjorn Andersson > --- > > Changes since v2: > - None > > drivers/soc/qcom/Kconfig | 15 ++ > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/pmic_glink.c | 336 ++++++++++++++++++++++++++++ > include/linux/soc/qcom/pmic_glink.h | 32 +++ > 4 files changed, 384 insertions(+) > create mode 100644 drivers/soc/qcom/pmic_glink.c > create mode 100644 include/linux/soc/qcom/pmic_glink.h > Reviewed-by: Neil Armstrong Tested-by: Neil Armstrong # on SM8550-MTP & SM8450-HDK