From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 726A8C6FA89 for ; Mon, 5 Sep 2022 09:21:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236227AbiIEJVW (ORCPT ); Mon, 5 Sep 2022 05:21:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236216AbiIEJVM (ORCPT ); Mon, 5 Sep 2022 05:21:12 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5826A3ECEE; Mon, 5 Sep 2022 02:21:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A622BCE10E1; Mon, 5 Sep 2022 09:21:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFBA8C433D6; Mon, 5 Sep 2022 09:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662369667; bh=ptxuZG4Zk9G7RVWmKc5/Z8aPFdisqj7T38aPHulvzAc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=O2lakoHqF27D7zQCvZjexwQldXiyCCpAoQv+9Tjr0l+CZKZaxkLGiOb0LPKwrZLzh 9C44U4Ul1v186uSJbhofcDvazfrZjcVEXAtPxk2Iry2XZOwKnwU2l2M4frd2mgEp0O jvE4uRzY7EdsZXgVTk1vCHG7BUofwNhT1mPfQK5yJ0KBT9Bt+beKHgnCokhNPnYW4n TJf5uSdHof6zDuK7ctFtOLjBTCSnXKI1t+XYSDshuh8sC4Ga+IafbuQ1e2WPbuE+Qf UZxfbcUQbHR4CioDHXjplwh+eBFgGwv69UGawBvNCLvNY5P9b2VmV848EO1crRJqsV 3JuBIiUmPxfbw== Message-ID: Date: Mon, 5 Sep 2022 12:21:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 3/3] dt-bindings: memory-controllers: gpmc-child: Add binding for wait-pin-polarity Content-Language: en-US To: "Niedermayr, BENEDIKT" , "devicetree@vger.kernel.org" , "linux-omap@vger.kernel.org" Cc: "tony@atomide.com" , "krzysztof.kozlowski@linaro.org" , "robh+dt@kernel.org" References: <20220905071717.1500568-1-benedikt.niedermayr@siemens.com> <20220905071717.1500568-4-benedikt.niedermayr@siemens.com> From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/09/2022 12:14, Niedermayr, BENEDIKT wrote: > On Mon, 2022-09-05 at 11:56 +0300, Roger Quadros wrote: >> Hi Benedikt, >> >> On 05/09/2022 10:17, B. Niedermayr wrote: >>> From: Benedikt Niedermayr >>> >>> Add a new dt-binding for the wait-pin-polarity property >>> >>> Signed-off-by: Benedikt Niedermayr >>> >>> --- >>> .../bindings/memory-controllers/ti,gpmc-child.yaml | 7 >>> +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/memory- >>> controllers/ti,gpmc-child.yaml >>> b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc- >>> child.yaml >>> index 6e3995bb1630..7c721206f10b 100644 >>> --- a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc- >>> child.yaml >>> +++ b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc- >>> child.yaml >>> @@ -230,6 +230,13 @@ properties: >>> Wait-pin used by client. Must be less than "gpmc,num- >>> waitpins". >>> $ref: /schemas/types.yaml#/definitions/uint32 >>> >>> + gpmc,wait-pin-polarity: >>> + description: | >>> + Wait-pin polarity used by the clien. It relates to the pin >>> defined >> >> did you mean "client?" >> Can you please specify what value is for Active Low vs Active High? > > Yes, that makes sense. And yes I meant "client". My typo..... >> >>> + with "gpmc,wait-pin". >>> + $ref: /schemas/types.yaml#/definitions/uint32 >> >> Why can't type be boolean? > > Of course we can use the boolean there. In that case I should give the > property a more meaningful name e.g. wait-pin-active-high or wait-pin- > active-low. > Since the default behavour of this pin is Active High, > a bool property "gpmc,wait-pin-active-low" would make more sense for > backwards compatibility. > If the property is missing, than the polarity stays on Active High like > before. > OK, in that case you don't have to clarify the polarity in description. >> >>> + default: 0 >>> + >>> gpmc,wait-on-read: >>> description: Enables wait monitoring on reads. >>> type: boolean >> >> cheers, >> -roger > > cheers, > benedikt > cheers, -roger