Devicetree
 help / color / mirror / Atom feed
From: Komal Bajaj <quic_kbajaj@quicinc.com>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	<linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: qdu1000-idp: add SDHCI for emmc
Date: Tue, 23 May 2023 19:24:47 +0530	[thread overview]
Message-ID: <eeeb8971-162e-6c33-83ff-d003739d5211@quicinc.com> (raw)
In-Reply-To: <CAH=2NtxwG3YaN7F_q2PARXPA_Rit7-KhkxFKXzL0xD3J8J4SpQ@mail.gmail.com>



On 5/22/2023 3:23 PM, Bhupesh Sharma wrote:
> On Mon, 22 May 2023 at 15:06, Komal Bajaj <quic_kbajaj@quicinc.com> wrote:
>> Add sdhci node for emmc in qdu1000-idp.
>>
>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 23 +++++++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>> index 9e9fd4b8023e..61d8446a2d55 100644
>> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>> @@ -451,3 +451,26 @@
>>   &uart7 {
>>          status = "okay";
>>   };
>> +
>> +&sdhc_1 {
>> +       pinctrl-names = "default", "sleep";
>> +       pinctrl-0 = <&sdc1_on_state>;
>> +       pinctrl-1 = <&sdc1_off_state>;
>> +
>> +       cap-mmc-hw-reset;
>> +       mmc-ddr-1_8v;
>> +       mmc-hs200-1_8v;
>> +       mmc-hs400-1_8v;
>> +       mmc-hs400-enhanced-strobe;
>> +
>> +       non-removable;
>> +       no-sd;
>> +       no-sdio;
>> +
>> +       supports-cqe;
>> +
>> +       vmmc-supply = <&vreg_l10a_2p95>;
>> +       vqmmc-supply = <&vreg_l7a_1p8>;
>> +
>> +       status = "okay";
>> +};
> This node is out of alphabetical order again.
> &uart7 would follow &sdhc_1 and so on...
Sure will change this next version.

Thanks
Komal
>
> Thanks,
> Bhupesh


      reply	other threads:[~2023-05-23 13:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22  9:36 [PATCH v2 0/4] arm64: dts: qcom: qdu1000: add SDHCI Komal Bajaj
2023-05-22  9:36 ` [PATCH v2 1/4] dt-bindings: mmc: sdhci-msm: Document the QDU1000/QRU1000 compatible Komal Bajaj
2023-05-22  9:50   ` Bhupesh Sharma
2023-05-22  9:36 ` [PATCH v2 2/4] arm: dts: qcom: qdu1000: Add SDHCI node Komal Bajaj
2023-05-22 15:01   ` Bjorn Andersson
2023-05-23 13:53     ` Komal Bajaj
2023-05-22  9:36 ` [PATCH v2 3/4] arm64: dts: qcom: qdu1000: Add SDHCI1 pin configuration to DTSI Komal Bajaj
2023-05-22  9:49   ` Bhupesh Sharma
2023-05-22  9:36 ` [PATCH v2 4/4] arm64: dts: qcom: qdu1000-idp: add SDHCI for emmc Komal Bajaj
2023-05-22  9:53   ` Bhupesh Sharma
2023-05-23 13:54     ` Komal Bajaj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eeeb8971-162e-6c33-83ff-d003739d5211@quicinc.com \
    --to=quic_kbajaj@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bhupesh.sharma@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox