From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 963BBEEC3; Mon, 28 Jul 2025 04:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753678209; cv=none; b=BUIE5ffBo/QRN9XgUwrSMblp38jqg+GIXj/yiSi5/wxbWQ4B7weKGMittOj0rYv5B2Hc68Ehh+u6hmzk1ebfIufLsCaud6VxhSOJPNNxMqFixpRjru4Fat3NVEzX7Erhn8rLFfkf19n7VF5NRF9B27y0ssDJgDbkzX+tl7SZcEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753678209; c=relaxed/simple; bh=CzRdO948Lo2iFxSrbyu5Pagmi3kJ6/7KYnoh6hd6OHk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HJcEzbftocJNY3r5ljGvc8lYXR+TIaMRvKqICk+fJcjkaoig2NgTwIQKQcc8O/LcnlCyCPjNnmg5Vls6FB0l6oweowjOAsYQDWfLDJrkxwxCkHlrJ778r4wi1LXjp879W7QKV6wZzRvzsIoGjFSfY80ZAkppZ+cwBe3kz4WxNvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RrL4+y31; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RrL4+y31" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6663CC4CEE7; Mon, 28 Jul 2025 04:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753678209; bh=CzRdO948Lo2iFxSrbyu5Pagmi3kJ6/7KYnoh6hd6OHk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RrL4+y31r5CPtYMDYuefm/kgI9mrBIwDYDdyLrivD4MtAP93Y6kIIdD3PwSYu7lVg Uo8V3Ult2hqkn770Jdo4Ho1Hzz3cnflSDULKiwCCF1OPBlQzhSrrEmHVuSpVzU1HKS FLliS9vWzC/t1hOFce8Y1V66kO4MQKaws1beT7e5wzpVC7WoVtL+vnDmBtoyyfEKtc wuwhhL5rWE9X5KY8mPkQGFmutq1vQpEvdVE/MwCfiyX9svGf+utJg6Tzsr91HWJvtK LlHLnyi+B/Lw4Ll67QVQEAohs2n+trvYGsGW5yuqn9k0rh2JFYvlQOw5r5hkJJcHGL Bf3EwaKb25e8g== Message-ID: Date: Mon, 28 Jul 2025 06:50:04 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp for MT8188 To: =?UTF-8?B?RnJpZGF5IFlhbmcgKOadqOmYsyk=?= , "robh@kernel.org" , "matthias.bgg@gmail.com" , =?UTF-8?B?WW9uZyBXdSAo5ZC05YuHKQ==?= , "p.zabel@pengutronix.de" , "conor+dt@kernel.org" , AngeloGioacchino Del Regno Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , Project_Global_Chrome_Upstream_Group References: <20250521063347.31578-1-friday.yang@mediatek.com> <20250521063347.31578-3-friday.yang@mediatek.com> <7421d8f4f3d5fdb392f46df93bfee21a97cc2e1c.camel@mediatek.com> <633ea291-2e02-44be-bd03-220634b3c62d@kernel.org> <1e9de035-9d32-45d1-9f11-33c3439143be@kernel.org> <2cc7a0be13d2b35b8728fb23e56097620a40fc05.camel@mediatek.com> <03dece78-44d5-4b85-b71c-bb6794849ddd@kernel.org> <7e390b85e1ba6362ffa0231faefc0ea63a922639.camel@mediatek.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <7e390b85e1ba6362ffa0231faefc0ea63a922639.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 28/07/2025 04:59, Friday Yang (杨阳) wrote: > On Thu, 2025-07-24 at 10:55 +0200, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On 24/07/2025 10:43, Friday Yang (杨阳) wrote: >>>> >>>>> ignore this tag. What I intended to explain here was that I >>>>> decided >>>>> not >>>>> to use 'devm_pm_runtime_enable' to replace 'pm_runtime_enable' >>>>> functions. Unfortunately, the fake tag didn't explain this >>>>> clearly >>>>> in >>>>> the changelog, which was my fault. To address this, I updated >>>>> patchset >>>>> v8 to include an explanation. >>>>> >>>>> In patchset v6, I replaced 'pm_runtime_enable' with >>>>> 'devm_pm_runtime_enable'. However, in patchset v8, I reverted >>>>> this >>>>> change and included the reason for this decision in the >>>>> changelog. >>>>> Apologize for the delay and the trouble again. >>>> >>>> Nothing above is related to my question about the >>>> fake/invented/questioned tag. >>>> >>> >>> I got your point, you refer to the 'reviewed-by' and 'acked-by' tag >>> in >>> this patch. >>> These are the tags from two reviewers. >>> >>> > https://lore.kernel.org/lkml/174172361378.44650.15345202042780383326.robh@kernel.org/ >> >> >> You are really not responding to my initial comments and keep >> dragging >> this discussion in some confused directions. Do we talk here about >> that >> patch? No. >> > > I understand what you're referring to. For the 'dt-binding' patch, I > can keep the tags. However, for the 'smi driver' patch, I should remove > the tags because there was a change after v6. > I will update v9 soon. Thank you! No. You never responded to v7 and never addressed the actual comments I raised. Best regards, Krzysztof