From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 65C6020CCFF; Tue, 18 Mar 2025 13:37:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742305050; cv=none; b=A9dgPYjzLUULIdNt9CimyNkR+yZOkAhbPbAui/q28gXzpPz4QBPj89NOGm5ysrRJ2PPu34HJNIK4Tji11DQWrzLOX6PtUdX6u9sQSVJaPBt9hOfHpxfS7rHUva+QpnAQs3tt6aG2Z/Bi1xb76UyOkby6mRsQ0p2/YnbsGAGWRRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742305050; c=relaxed/simple; bh=VmTzynLEZMwhCT3MfTXuku7wjKlEdu3eCX94MGhkA0I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mE02s0VUT1SEWwQUO1GRFdZwUbLfbDNuc1wUuobnu1sNDbkek8jvha3gEADxdymBQ/8hLxZmU9RBtKNgAQZr+4x71C7B2XUzQlxeazqypin2zYuZpK5YTDU+jmQ3xV3nXqj6Pkfob6Alv2URVT+le0FGpHFIuprbKD/39P+fYIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E78EC13D5; Tue, 18 Mar 2025 06:37:36 -0700 (PDT) Received: from [10.1.197.1] (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7FEDC3F673; Tue, 18 Mar 2025 06:37:24 -0700 (PDT) Message-ID: Date: Tue, 18 Mar 2025 13:37:23 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/9] dt-bindings: arm: qcom,coresight-static-replicator: add optional clocks To: Dmitry Baryshkov , Mike Leach Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Neil Armstrong , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Mike Leach , James Clark , Leo Yan , Kumar Gala , Andy Gross , "Ivan T. Ivanov" , Andy Gross , Georgi Djakov , David Heidelberg , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <20250317-fix-nexus-4-v1-0-655c52e2ad97@oss.qualcomm.com> <20250317-fix-nexus-4-v1-4-655c52e2ad97@oss.qualcomm.com> <7b0af57c-a38c-4c30-9bb7-efe511d6bd1d@arm.com> Content-Language: en-US From: Suzuki K Poulose In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/03/2025 12:19, Dmitry Baryshkov wrote: > On Tue, Mar 18, 2025 at 10:38:17AM +0000, Suzuki K Poulose wrote: >> On 17/03/2025 17:44, Dmitry Baryshkov wrote: >> >> nit: Subject: >> >> s/qcom,coresight-static-replicator/arm,coresight-static-replicator >> >>> As most other CoreSight devices the replicator can use either of the >>> optional clocks (or both). Document those optional clocks in the schema. >>> >>> Fixes: 3c15fddf3121 ("dt-bindings: arm: Convert CoreSight bindings to DT schema") >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> .../bindings/arm/arm,coresight-static-replicator.yaml | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml >>> index a6f793ea03b6c193fc0ff72a45e0249a63a2ba3c..56e64067ed3d63c5e293a0840858f13428bacb45 100644 >>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml >>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml >>> @@ -30,6 +30,16 @@ properties: >>> power-domains: >>> maxItems: 1 >>> + clocks: >>> + minItems: 1 >>> + maxItems: 2 >>> + >> >> For the static replicator, you don't have an APB clock, as they can't be >> programmed. It may have an ATB clock. So minItems 0, maxItems: 1 > > It can, see qcom-apq8064.dtsi > > Also minItems:0 doesn't make sense to me. I'd rather keep this as an > optional property rather than requiring an empty set. Interesting, that must be atclk in fact. Because a static replicator only manages ATB transactions. It doesn't have an APB interface. I am not an expert in DTB schema. But the point is the clocks are optional. Suzuki > >> >> Suzuki >> >> >> >>> + clock-names: >>> + minItems: 1 >>> + enum: >>> + - apb_pclk >>> + - atclk >>> + >>> in-ports: >>> $ref: /schemas/graph.yaml#/properties/ports >>> additionalProperties: false >>> >> >