From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH v4 1/4] Documentation: dt-bindings: iio: Add max9611 ADC Date: Sun, 2 Apr 2017 10:35:40 +0100 Message-ID: References: <1490627578-15938-1-git-send-email-jacopo+renesas@jmondi.org> <1490627578-15938-2-git-send-email-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1490627578-15938-2-git-send-email-jacopo+renesas@jmondi.org> Sender: linux-renesas-soc-owner@vger.kernel.org To: Jacopo Mondi , geert@linux-m68k.org, wsa+renesas@sang-engineering.com, magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-iio@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 27/03/17 16:12, Jacopo Mondi wrote: > Add device tree bindings documentation for Maxim max9611/max9612 current > sense amplifier. > > Signed-off-by: Jacopo Mondi > --- > .../devicetree/bindings/iio/adc/max9611.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/max9611.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/max9611.txt b/Documentation/devicetree/bindings/iio/adc/max9611.txt > new file mode 100644 > index 0000000..8430d3b > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/max9611.txt > @@ -0,0 +1,26 @@ > +* Maxim max9611/max9612 current sense amplifier with 12-bits ADC interface > + > +Maxim max9611/max9612 is an high-side current sense amplifier with integrated > +12-bits ADC communicating over I2c bus. > +The device node for this driver shall be a child of a I2c controller. > + > +Required properties > + - compatible: Should be "maxim,max9611" or "maxim,max9612" > + - reg: The 7-bits long I2c address of the device > + - shunt-resistor-uohm: Value, in uOhm, of the current sense shunt resistor Just did a quick grep for this see if I felt comfortable enough to not wait for Rob / Mark to have a chance to look at it. Grep gave me: shunt-resistor-micro-ohms for the ina2xx. Feels rather like we should match that. Otherwise looks good to me. Jonathan > + > +Example: > + > +&i2c4 { > + csa: adc@7c { > + compatible = "maxim,max9611"; > + reg = <0x7c>; > + > + shunt-resistor-uohm = <5000>; > + }; > +}; > + > +This device node describes a current sense amplifier sitting on I2c4 bus > +with address 0x7c (read address is 0xf9, write address is 0xf8). > +A sense resistor of 0,005 Ohm is installed between RS+ and RS- current-sensing > +inputs. >