From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Date: Thu, 16 Jun 2016 09:06:29 -0400 Message-ID: References: <1466000018-16784-1-git-send-email-ldewangan@nvidia.com> <1466000018-16784-6-git-send-email-ldewangan@nvidia.com> <3fa0a098-3b28-9baa-8950-a944cce86b65@osg.samsung.com> <57629AB9.2090506@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <57629AB9.2090506@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Krzysztof Kozlowski , Laxman Dewangan , mturquette@baylibre.com, robh+dt@kernel.org, linux@armlinux.org.uk Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Javier Martinez Canillas List-Id: devicetree@vger.kernel.org Hello Krzysztof, On 06/16/2016 08:25 AM, Krzysztof Kozlowski wrote: > On 06/15/2016 05:39 PM, Javier Martinez Canillas wrote: >> Hello Laxman, >> >> On 06/15/2016 10:13 AM, Laxman Dewangan wrote: >>> The clock driver used by Maxim PMIC MAX77802 is clk-max77686 >>> which can be enabled with config CONFIG_COMMON_CLK_MAX77686. >>> >>> Hence the config CONFIG_COMMON_CLK_MAX77802 is not required. >>> >>> Signed-off-by: Laxman Dewangan >>> CC: Krzysztof Kozlowski >>> CC: Javier Martinez Canillas >>> --- >>> arch/arm/configs/exynos_defconfig | 1 - >>> arch/arm/configs/multi_v7_defconfig | 1 - >> >> Please split these two changes in separate patches, there are just >> cleanups needed after 1/5 and they can be picked separately. > > Not entirely separately. If we do not want to loose max77802 clocks on > defconfigs, then it should go with the same tree or after driver get > merged. I prefer the latter, similar case to 1898994229f8 ("ARM: > multi_v7_defconfig: Switch max77693 to module"). > Agreed. Your latter example is what I tried to say (that can be picked as cleanups separately once 1/5 hits mainline). I just didn't express clearly. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America