From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C31AC7EE23 for ; Thu, 11 May 2023 03:21:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232071AbjEKDVm (ORCPT ); Wed, 10 May 2023 23:21:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232261AbjEKDVl (ORCPT ); Wed, 10 May 2023 23:21:41 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97CA81719; Wed, 10 May 2023 20:21:35 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id EB91682D4; Thu, 11 May 2023 11:21:33 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 11 May 2023 11:21:34 +0800 Received: from [192.168.125.124] (113.72.146.187) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 11 May 2023 11:21:33 +0800 Message-ID: Date: Thu, 11 May 2023 11:21:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 3/3] riscv: dts: starfive: add tdm node and sound card To: Conor Dooley CC: Emil Renner Berthing , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , References: <20230506090116.9206-1-walker.chen@starfivetech.com> <20230506090116.9206-4-walker.chen@starfivetech.com> <20230509-overheat-pliable-00d60523637e@spud> <20230510-riveter-ridden-3f056251e623@spud> Content-Language: en-US From: Walker Chen In-Reply-To: <20230510-riveter-ridden-3f056251e623@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.146.187] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/5/11 4:22, Conor Dooley wrote: > On Wed, May 10, 2023 at 05:21:21PM +0800, Walker Chen wrote: >> On 2023/5/10 16:33, Emil Renner Berthing wrote: >> > On Tue, 9 May 2023 at 20:05, Conor Dooley wrote: >> >> >> >> On Tue, May 09, 2023 at 08:52:48PM +0800, Walker Chen wrote: >> >> > Hi Conor/Emil, >> >> > >> >> > DT overlay is used to describe combinations of VF2 and hat. >> >> > Do you have any comments on this patch ? >> >> >> >> I seem to recall that he said at the linux-riscv sync-up call that we >> >> have* that he was not in favour of overlays for hats like this. >> >> I'll let him confirm that though, I might very well be misinterpreting or >> >> misremembering what he said. >> > >> > What probably meant was that I didn't want a bunch of different device >> > trees for each combination board * hat. An overlay makes a lot more >> > sense. However, looking through the kernel tree there is a surprising >> > lack of overlays for hats committed already, so I suspect there is >> > some sort of policy around overlays already in place. > >> About the specific usage of overlay for this board + hat, referenced to the following example in kernel: >> linux/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-imx219.dtso >> That board is connected with imx219 sensor via mipi_csi interface. That patch was accepted in 2022. > > Hmm, so spoke to Emil again today about it. In the interest of being > fair, I did go looking at that particular board & looked through their > documentation for more information on why there are overlays. > They do actually sell the bits required to use the overlays, based on > what I saw in their datasheet for the board & wiki. That said, what is > done for one arm64 platform does not necessarily apply elsewhere ;) > > I'm not against allowing in-tree overlays for hats/capes/daughter-boards > that come bundled with a board, but accepting ones for a hat that > someone decided to use theoretically has no limit! The "someone" in this > case might be a StarFive developer, but it could be any random one of > your customers next! > We've got to draw a line somewhere, so my answer to the overlay *in this > case* is a no. Sorry. > When you submit your next version, please drop the overlay from this > patch. I'm trying to understand what you mean. so the conclusion is that I need to drop the file 'jh7110-starfive-visionfive-2-wm8960.dtso' from this patch. When I submit the next version, just keep the TDM node and the pins configuration for TDM in patch [3/3], need to drop the wm8960 stuff. Right ? Best regards, Walker