From: Icenowy Zheng <uwu@icenowy.me>
To: Anand Moon <linux.amoon@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 01/11] dt-bindings: usb: Add device id for Genesys Logic hub controller
Date: Wed, 28 Dec 2022 18:08:15 +0800 [thread overview]
Message-ID: <ef20a7dfa027f1a5a24a515e347af10c06a4da85.camel@icenowy.me> (raw)
In-Reply-To: <20221228100321.15949-2-linux.amoon@gmail.com>
在 2022-12-28星期三的 10:03 +0000，Anand Moon写道：
> Add usb hub device id for Genesys Logic, Inc. GL852G-OHG Hub USB 2.0
> root hub and Genesys Logic, Inc. GL3523-QFN76 USB 3.1 root hub.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Documentation/devicetree/bindings/usb/genesys,gl850g.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> index a9f831448cca..db009f3ef438 100644
> --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> @@ -16,6 +16,8 @@ properties:
> compatible:
> enum:
> - usb5e3,608
> + - genesys,usb5e3,610
> + - genesys,usb5e3,620
I don't think genesys, is needed here because usb5e3 means USB VID
0x05e3, which is already linked to Genesys Logic.
In addition, the control logic of these two hubs are needed to be
verified.
And what's the status of the companion hub of the USB3 hub? Is it
really a USB3-only hub, or is its USB2 part just equal to another USB3
hub?
>
> reg: true
>
next prev parent reply other threads:[~2022-12-28 10:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221228100321.15949-1-linux.amoon@gmail.com>
2022-12-28 10:03 ` [PATCH v1 01/11] dt-bindings: usb: Add device id for Genesys Logic hub controller Anand Moon
2022-12-28 10:08 ` Icenowy Zheng [this message]
2022-12-28 10:29 ` Anand Moon
2023-01-04 22:54 ` Matthias Kaehlcke
2023-01-07 15:01 ` Anand Moon
2023-01-09 16:29 ` Matthias Kaehlcke
2023-01-09 17:48 ` Anand Moon
2022-12-28 15:08 ` Krzysztof Kozlowski
2022-12-28 15:18 ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 02/11] ARM: dts: amlogic: Used onboard usb hub reset to enable usb hub Anand Moon
2022-12-28 15:08 ` Krzysztof Kozlowski
2023-01-07 14:59 ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 03/11] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2 Anand Moon
2022-12-28 12:51 ` Martin Blumenstingl
2022-12-28 14:44 ` Anand Moon
2023-01-04 8:13 ` Anand Moon
2023-01-04 8:56 ` Neil Armstrong
2023-01-04 9:17 ` Anand Moon
2023-01-04 9:36 ` Alexander Stein
2023-01-07 14:56 ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 04/11] arm64: dts: amlogic: Used onboard usb hub reset on odroid n2 Anand Moon
2022-12-28 10:03 ` [PATCH v1 07/11] vendor-prefixes: Add VIA Labs, Inc Anand Moon
2022-12-28 15:11 ` Krzysztof Kozlowski
2022-12-28 10:03 ` [PATCH v1 08/11] dt-bindings: usb: Add binding for Via lab VL817Q7 hub controller Anand Moon
2022-12-28 11:02 ` Johan Hovold
2022-12-28 11:09 ` Anand Moon
2022-12-28 17:16 ` Rob Herring
2023-01-04 22:37 ` Matthias Kaehlcke
2023-01-07 15:00 ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 09/11] arm64: dts: meson-sm1-odroid-c4: Used onboard usb hub reset on odroid c4 Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef20a7dfa027f1a5a24a515e347af10c06a4da85.camel@icenowy.me \
--to=uwu@icenowy.me \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).