From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63A994D8AD for ; Sun, 23 Jun 2024 11:17:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719141435; cv=none; b=aqFDtabcFyHiHMaggNr2pngOeobDaG1Kw6TYIVfsByDCRqcYYxfXgGosKHJrxvtlt5envH6jIvbMtoYkMYGIyOhKr+p0xMOvfalClMsVVcYNVPVSF6gQkht3Hvhyerj5IOKORtE+PTLZX0nHaPj/gFN9nU+MBqjP9r4VKug2kRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719141435; c=relaxed/simple; bh=TveO61+2iJeBP3GHqzB1IiVQDAe7GiLKVq2CCsJ05aU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fB/HCzCs8Cc5Vg5z00yXdwsdB+P798PlJRQnInyNM1rh4UNFTYUgVD+oZYVQHp3jzMU1rgPu2Z9vQpTHpIhmsK909rfz2vZeJcX+kaDyO1ZYPdkLvrLcmAxZuVNyl99ql/SltjpqC5GwAT2gy+UeAMxsrBbjDp4yCAQj14qhJwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wYgGFcdh; arc=none smtp.client-ip=209.85.221.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wYgGFcdh" Received: by mail-wr1-f67.google.com with SMTP id ffacd0b85a97d-362f62ae4c5so1912110f8f.1 for ; Sun, 23 Jun 2024 04:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719141431; x=1719746231; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E/uNYx9wbe1FVigGrWkz8ceaapK4umFwJkG/aUnu2ew=; b=wYgGFcdhBnpgmr+7Y82XhY7fJcMcYaWBIw3pDD1rHy7Emt1u6VHmifT7rfBN63dM/D dsyEgPB/Fn+z/n18Bev6aESs1nSVuIIp69f4t2NbBHr1udUgBbnWNpiiI/LChN4xi/v/ 9Dkm3BoCo+YKstf4HPzkOm6ifreNuWfwcQAnXY3s8T7iAzpmpmJmHXWkhtsdAXi8usq1 0adDYhlKwI5xDOIGQUP18zWSp9+aNTHYE5qN4bcZkVA15170Iwuxg0dLGo/3IwIVNWAG 50io+4PYHQgicSavdoRnwc6vWjeXI0WgMFFEp721cMgHgMYaJNQWcNbv74fUlomxyzqn sWjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719141431; x=1719746231; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E/uNYx9wbe1FVigGrWkz8ceaapK4umFwJkG/aUnu2ew=; b=osJFL9h7yA3xG6ljvax67P/yxOsLR0P8Vj6I+L+xtJaw4KaI2a2GwRndhnxFqLDR3d SAzc4jVVyQ2ZuNLefx/RkmN1Tvu+eah2YMI6GhqWUV26iAxlZsls8ykwlLv8ByXTi1hh 6NmMCSqvtg5T5tW8YzFE7kM0MvM9ulDrjcIAnEzogpQ/w067kVh/bNuRyQVB53XtVx7y wkxf8Z34bPNOfSeaXDW59x0MFueqDTowr8KirkZqeLDB0H3iBzOoAzkL/2mJB5hhzM27 Qw6TWy9XUKVJFSfOaJJ9+9ORXaT2DvGRcA6tUJTfGcDamj/CiVSPZMb3XxPc3cAivlh4 n9fw== X-Forwarded-Encrypted: i=1; AJvYcCXUAk1ngs4PmF6kDA917cg9YWd1buOH6ciBAlZCn4bavj0ZyaaczrtmMeyITJJpyHkX9T8TVk00cLwx3MhH33J8caUNPb1cjLVJ8g== X-Gm-Message-State: AOJu0YxHH6lCjpMVfEIdo8Z+2y4UICsM6PZ7Ysd7lOCvLh79Crt4coTD uF6ULVkzAdewBIb2fvYliatwLP8/TZDHCyRXN8YpBRvetfc5zramqzNce7j7RTY= X-Google-Smtp-Source: AGHT+IEnfkf9A/OZy49Z4IWSRdfP/ZgKsbN5tn+lAqcp2I5TQtPFferklb1sn7FyT56zuDX0dt/E2Q== X-Received: by 2002:a05:6000:1f8c:b0:360:727b:ab49 with SMTP id ffacd0b85a97d-366e36b0b77mr3050215f8f.22.1719141430585; Sun, 23 Jun 2024 04:17:10 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366383f6769sm7128327f8f.5.2024.06.23.04.17.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jun 2024 04:17:10 -0700 (PDT) Message-ID: Date: Sun, 23 Jun 2024 12:17:09 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] media: qcom: camss: csiphy-3ph: Add Gen2 v1.2.2 two-phase MIPI CSI-2 DPHY init To: george chan , Konrad Dybcio Cc: Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, Bjorn Andersson , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240621-b4-sc7180-camss-v1-0-14937929f30e@gmail.com> <20240621-b4-sc7180-camss-v1-3-14937929f30e@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 22/06/2024 14:43, george chan wrote: > FWIW 1.2.2 seems to be the desired one: [1] > > Konrad > > [1] > https://git.codelinaro.org/clo/la/kernel/msm-4.14/-/blob/UC.UM.1.0.r1-02500-sa8155.0/arch/arm64/boot/dts/qcom/atoll-camera.dtsi#L22 > > > Here is the log from sm7125 joyeuse phone, not sure if it helps or not. > [  204.034767] qcom-camss acb3000.camss: CSIPHY 3PH HW Version = 0x01000000 > > I carefully looked into this csiphy_2ph_v1_2_2_reg of various trees, and > concluded below version: > (1)atoll, sdm845[1] > (2)surya[2], sa8155, factory-trogdor-13443.B-chromeos-5.4[3] > > I was tempted to use (1)atoll one but it looked like (2) is newer. Is it > worthy to create CAMSS_7125 specially for SM7125. Please give me some > advice about it. So, which have you tested with as verified and working ? My assumption here is that this series has been tested and is proven to work. Version 1.2.1 and version 1.2.2 don't indicate different versions of the init sequence but different versions of the PHY. For example - the CSI decoder is "just" digital logic, the "source code" for the at logic can be "recompiled" for a different process node. But the PHYs translate analogue signals into the digital domain and therefore will vary with different process nodes - 3nm v 4nm v 28nm. So it is virtually impossible - or highly improbable that init sequence 1.2.1 and init sequence 1.2.2 will work on the same piece of hardware. So its not a question of choosing the newer version - only one version will work - the version that is specifically tuned to the PHY for the given process node and RTL version. Err, so TL;DR you _have_ tested this and gotten data delivered to you in user-space - right ? --- bod