* [PATCH] arm64: dts: imx8mp-venice*: enable NPU support
@ 2024-09-09 21:53 Tim Harvey
2024-09-10 6:50 ` Frieder Schrempf
0 siblings, 1 reply; 3+ messages in thread
From: Tim Harvey @ 2024-09-09 21:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Li Yang,
devicetree, linux-kernel, imx, linux-arm-kernel
Cc: Tim Harvey
The IMX8MP has a VeriSilicon (Vivante VIP8000) NPU which
is supported by the etnaviv driver. Enable it.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi
index 6c75a5ecf56b..f0211a96855b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi
@@ -393,6 +393,10 @@ &i2c3 {
status = "okay";
};
+&npu {
+ status = "okay";
+};
+
/* off-board header */
&uart1 {
pinctrl-names = "default";
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index 9885948952b4..8a04b66a4afc 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -666,6 +666,10 @@ &i2c4 {
status = "okay";
};
+&npu {
+ status = "okay";
+};
+
&pcie_phy {
fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
fsl,clkreq-unsupported;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp-venice*: enable NPU support
2024-09-09 21:53 [PATCH] arm64: dts: imx8mp-venice*: enable NPU support Tim Harvey
@ 2024-09-10 6:50 ` Frieder Schrempf
2024-09-10 20:14 ` Tim Harvey
0 siblings, 1 reply; 3+ messages in thread
From: Frieder Schrempf @ 2024-09-10 6:50 UTC (permalink / raw)
To: Tim Harvey, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Li Yang, devicetree, linux-kernel, imx, linux-arm-kernel
Hi Tim,
On 09.09.24 11:53 PM, Tim Harvey wrote:
> The IMX8MP has a VeriSilicon (Vivante VIP8000) NPU which
> is supported by the etnaviv driver. Enable it.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi
> index 6c75a5ecf56b..f0211a96855b 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi
> @@ -393,6 +393,10 @@ &i2c3 {
> status = "okay";
> };
>
> +&npu {
> + status = "okay";
> +};
> +
> /* off-board header */
> &uart1 {
> pinctrl-names = "default";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> index 9885948952b4..8a04b66a4afc 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> @@ -666,6 +666,10 @@ &i2c4 {
> status = "okay";
> };
>
> +&npu {
> + status = "okay";
> +};
> +
> &pcie_phy {
> fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
> fsl,clkreq-unsupported;
I think there is no need for this patch as the NPU is already enabled by
default in imx8mp.dtsi (same as the GPUs). Or do you disable it in some
intermediate devicetree include file?
Thanks
Frieder
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp-venice*: enable NPU support
2024-09-10 6:50 ` Frieder Schrempf
@ 2024-09-10 20:14 ` Tim Harvey
0 siblings, 0 replies; 3+ messages in thread
From: Tim Harvey @ 2024-09-10 20:14 UTC (permalink / raw)
To: Frieder Schrempf
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Li Yang,
devicetree, linux-kernel, imx, linux-arm-kernel
On Mon, Sep 9, 2024 at 11:50 PM Frieder Schrempf
<frieder.schrempf@kontron.de> wrote:
>
> Hi Tim,
>
> On 09.09.24 11:53 PM, Tim Harvey wrote:
> > The IMX8MP has a VeriSilicon (Vivante VIP8000) NPU which
> > is supported by the etnaviv driver. Enable it.
> >
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi | 4 ++++
> > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 4 ++++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi
> > index 6c75a5ecf56b..f0211a96855b 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi
> > @@ -393,6 +393,10 @@ &i2c3 {
> > status = "okay";
> > };
> >
> > +&npu {
> > + status = "okay";
> > +};
> > +
> > /* off-board header */
> > &uart1 {
> > pinctrl-names = "default";
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > index 9885948952b4..8a04b66a4afc 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > @@ -666,6 +666,10 @@ &i2c4 {
> > status = "okay";
> > };
> >
> > +&npu {
> > + status = "okay";
> > +};
> > +
> > &pcie_phy {
> > fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
> > fsl,clkreq-unsupported;
>
> I think there is no need for this patch as the NPU is already enabled by
> default in imx8mp.dtsi (same as the GPUs). Or do you disable it in some
> intermediate devicetree include file?
>
Frieder,
Thanks for pointing this out... you are correct. I'm not sure why I
thought it needed to be explicitly enabled.
Please ignore this patch.
Best Regards,
Tim
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-10 20:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-09 21:53 [PATCH] arm64: dts: imx8mp-venice*: enable NPU support Tim Harvey
2024-09-10 6:50 ` Frieder Schrempf
2024-09-10 20:14 ` Tim Harvey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).