Re: [PATCH] arm64: dts: qcom: Move board nodes to common DTSI

[Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>]

On 5/24/2026 11:53 PM, Krzysztof Kozlowski wrote:
> On 15/05/2026 11:14, Pankaj Patil wrote:
>> On 3/29/2026 4:27 PM, Dmitry Baryshkov wrote:
>>> On Fri, Mar 27, 2026 at 06:16:59PM +0530, Gopikrishna Garmidi wrote:
>>>>
>>>>
>>>> On 3/26/2026 7:55 PM, Krzysztof Kozlowski wrote:
>>>>> On 26/03/2026 15:21, Gopikrishna Garmidi wrote:
>>>>>> The display, peripherals (touchpad/touchscreen/keypad), usb and their
>>>>>> dependent device nodes are common to both Glymur and Mahua CRDs,
>>>>>> so move them from glymur-crd.dts to glymur-crd.dtsi to enable code
>>>>>> reuse.
>>>>>>
>>>>>
>>>>> Same questions as for earlier tries (why this has to be repeated?), e.g.
>>>>> x1-crd: Please describe here what is the actual common hardware. In
>>>>> terms of physical hardware, not what you want to share.
>>>>>
>>>>
>>>> Hi krzysztof,
>>>>
>>>> Thanks for the review,
>>>>
>>>> Will update the commit message in the next re-spin.
>>>
>>> Before you respin, you can actually respond to the question. Do Glymur
>>> and Mahua CRD actually share those devices (in case of USB that would
>>> mean having the same baseboard with different SoCs being wired) or is it
>>> just "oh, this looks similar enough, let's create a common file".
>>>
>>
>> Hello,
>> Yes we've verified across glymur crd and mahua crd schematics, the regulator supply
>> and data lines are common across both targets for the nodes in the patch
> 
> That's not an answer to the question. Or rather you just confirmed -
> they are similar, so let's create a common file.
> 
> That's not a valid reason. Don't create common parts just because a few
> nodes are the same.

Hi Krzysztof,

Thanks for getting back.

Just to clarify — this patch does not introduce the common board
file, that was already done in an earlier patch:
https://lore.kernel.org/all/20260318124100.212992-4
gopikrishna.garmidi@oss.qualcomm.com/

We clearly describe the physical differences between Glymur and Mahua in 
that series and a consensus was reached.

We have re-verified both the Glymur CRD and Mahua CRD schematics
and also physically verified on both devices. The differences
between the two boards are limited to what was already described
in the patch above.

This patch simply moves the remaining common nodes into that
already-accepted shared file.

Happy to update the commit message if you have specific
suggestions on what needs to be changed and we will address it
in v3, or if you feel a separate Mahua board file is the right
approach we can go that route too — just let us know.

Thanks,
Gopikrishna