Re: [PATCH v5 02/20] dt-bindings: thermal: tsens: support per-sensor calibration cells

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 29/12/2022 04:00, Dmitry Baryshkov wrote:
> Allow specifying the exact calibration mode and calibration data as nvmem
> cells, rather than specifying just a single calibration data blob.
> 
> Note, unlike the vendor kernel the calibration data uses hw_ids rather
> than software sensor indices (to match actual tsens usage in
> thermal zones).
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../bindings/thermal/qcom-tsens.yaml          | 95 +++++++++++++++++--
>  1 file changed, 85 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index f3660af0b3bf..4bb689f4602d 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -81,18 +81,63 @@ properties:
>      maxItems: 2
>  
>    nvmem-cells:
> -    minItems: 1
> -    maxItems: 2
> -    description:
> -      Reference to an nvmem node for the calibration data
> +    oneOf:
> +      - minItems: 1
> +        maxItems: 2
> +        description:
> +          Reference to an nvmem node for the calibration data
> +      - minItems: 5
> +        maxItems: 35
> +        description: |
> +          Reference to nvmem cells for the calibration mode, two calibration
> +          bases and two cells per each sensor
>  
>    nvmem-cell-names:
> -    minItems: 1
> -    items:
> -      - const: calib
> -      - enum:
> -          - calib_backup
> -          - calib_sel
> +    oneOf:
> +      - minItems: 1
> +        items:
> +          - const: calib
> +          - enum:
> +              - calib_backup
> +              - calib_sel
> +      - minItems: 5
> +        items:
> +          enum:

This should not be an enum but a list of const... unless "holes" are
expected (e.g. s0_p1 and s5_p2, without ones in between).

> +            - mode
> +            - base1
> +            - base2
> +            - s0_p1
> +            - s0_p2
> +            - s1_p1
> +            - s1_p2
> +            - s2_p1
> +            - s2_p2
> +            - s3_p1
> +            - s3_p2
> +            - s4_p1


Best regards,
Krzysztof