[PATCH] dt-bindings:iio:gyroscope:invensense,itg3200: add binding

[PATCH] dt-bindings:iio:gyroscope:invensense,itg3200: add binding

[Rodrigo Gobbi]

There is no txt file for it, add yaml for invensense,itg3200 gyroscope.

Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
---
Added @Jonathan as the maintainer here due a suggestion in a
different thread for a different binding file.
Created this yaml using the driver probe and comparing with other gyro bindings.
Tks and regards.
---
 .../iio/gyroscope/invensense,itg3200.yaml     | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml

diff --git a/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
new file mode 100644
index 000000000000..0656dbb58cf2
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/gyroscope/invensense,itg3200.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Invensense ITG-3200 Gyroscope
+
+maintainers:
+  - Jonathan Cameron <jic23@kernel.org>
+
+description: |
+  Triple-axis, digital output gyroscope with a three 16-bit analog-to-digital
+  converters (ADCs) for digitizing the gyro outputs, a user-selectable internal
+  low-pass filter bandwidth, and a Fast-Mode I2C . Datasheet can be found here:
+  https://invensense.tdk.com/wp-content/uploads/2015/02/ITG-3200-Register-Map.pdf
+
+properties:
+  compatible:
+    const: invensense,itg3200
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    minItems: 1
+
+  mount-matrix:
+    description: an optional 3x3 mounting rotation matrix.
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        itg3200@68 {
+            compatible = "invensense,itg3200";
+            reg = <0x68>;
+            pinctrl-names = "default";
+            pinctrl-0 = <&itg3200_pins>;
+            interrupt-parent = <&gpio2>;
+            interrupts = <24 IRQ_TYPE_EDGE_FALLING>;
+        };
+    };
-- 
2.49.0

Re: [PATCH] dt-bindings:iio:gyroscope:invensense,itg3200: add binding

[David Lechner]

On 5/14/25 7:21 PM, Rodrigo Gobbi wrote:
> There is no txt file for it, add yaml for invensense,itg3200 gyroscope.
> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
> ---
> Added @Jonathan as the maintainer here due a suggestion in a
> different thread for a different binding file.
> Created this yaml using the driver probe and comparing with other gyro bindings.
> Tks and regards.
> ---
>  .../iio/gyroscope/invensense,itg3200.yaml     | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> new file mode 100644
> index 000000000000..0656dbb58cf2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/gyroscope/invensense,itg3200.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Invensense ITG-3200 Gyroscope
> +
> +maintainers:
> +  - Jonathan Cameron <jic23@kernel.org>
> +
> +description: |
> +  Triple-axis, digital output gyroscope with a three 16-bit analog-to-digital
> +  converters (ADCs) for digitizing the gyro outputs, a user-selectable internal
> +  low-pass filter bandwidth, and a Fast-Mode I2C . Datasheet can be found here:
> +  https://invensense.tdk.com/wp-content/uploads/2015/02/ITG-3200-Register-Map.pdf

This is only the register map, not a proper datasheet, so isn't useful
for the devicetree bindings.

> +
> +properties:
> +  compatible:
> +    const: invensense,itg3200
> +
> +  reg:
> +    maxItems: 1
> +

Missing vdd-supply and vlogic-supply properties. These should be
required.

Missing clocks property for optional external clock.

We always try to make the DT bindings as complete as possible
even if the driver doesn't use all of it.

> +  interrupts:
> +    minItems: 1
> +
> +  mount-matrix:
> +    description: an optional 3x3 mounting rotation matrix.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        itg3200@68 {

           gyro@68

Generic names are preferred.

> +            compatible = "invensense,itg3200";
> +            reg = <0x68>;
> +            pinctrl-names = "default";
> +            pinctrl-0 = <&itg3200_pins>;

Probably don't need pinctrl stuff in the example.

> +            interrupt-parent = <&gpio2>;
> +            interrupts = <24 IRQ_TYPE_EDGE_FALLING>;
> +        };
> +    };

Re: [PATCH] dt-bindings:iio:gyroscope:invensense,itg3200: add binding

[David Lechner]

On 5/15/25 9:04 AM, David Lechner wrote:
> On 5/14/25 7:21 PM, Rodrigo Gobbi wrote:
>> There is no txt file for it, add yaml for invensense,itg3200 gyroscope.
>>
>> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
>> ---
>> Added @Jonathan as the maintainer here due a suggestion in a
>> different thread for a different binding file.
>> Created this yaml using the driver probe and comparing with other gyro bindings.
>> Tks and regards.
>> ---

Also just noticed that the IIO mailing list and Jonathan are missing
from the CC. Need to add those to have a chance of this getting picked
up.

Re: [PATCH] dt-bindings:iio:gyroscope:invensense,itg3200: add binding

[Rodrigo Gobbi]

> Also just noticed that the IIO mailing list and Jonathan are missing
> from the CC. Need to add those to have a chance of this getting picked
> up.

Adding CC since I`ve missed.
Tks and regards.

Re: [PATCH] dt-bindings:iio:gyroscope:invensense,itg3200: add binding

[Krzysztof Kozlowski]

On 16/05/2025 00:09, Rodrigo Gobbi wrote:
>> Also just noticed that the IIO mailing list and Jonathan are missing
>> from the CC. Need to add those to have a chance of this getting picked
>> up.
> 
> Adding CC since I`ve missed.
> Tks and regards.


No, you need to resend. By adding them on Cc they do not magically get
all the discussions from other emails.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings:iio:gyroscope:invensense,itg3200: add binding

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

On Thu, May 15, 2025 at 09:04:57AM -0500, David Lechner wrote:
> 
>            gyro@68
> 
> Generic names are preferred.

Which probably just means "gyroscope" in this case.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] dt-bindings:iio:gyroscope:invensense,itg3200: add binding

[Krzysztof Kozlowski]

On 15/05/2025 02:21, Rodrigo Gobbi wrote:
> There is no txt file for it, add yaml for invensense,itg3200 gyroscope.
> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
> ---

Subject, missing spaces.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> Added @Jonathan as the maintainer here due a suggestion in a
> different thread for a different binding file.
> Created this yaml using the driver probe and comparing with other gyro bindings.
> Tks and regards.
> ---
>  .../iio/gyroscope/invensense,itg3200.yaml     | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> new file mode 100644
> index 000000000000..0656dbb58cf2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/gyroscope/invensense,itg3200.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Invensense ITG-3200 Gyroscope
> +
> +maintainers:
> +  - Jonathan Cameron <jic23@kernel.org>

Not really, this should be someone interested in the hardware.

> +
> +description: |
> +  Triple-axis, digital output gyroscope with a three 16-bit analog-to-digital
> +  converters (ADCs) for digitizing the gyro outputs, a user-selectable internal
> +  low-pass filter bandwidth, and a Fast-Mode I2C . Datasheet can be found here:
> +  https://invensense.tdk.com/wp-content/uploads/2015/02/ITG-3200-Register-Map.pdf
> +
> +properties:
> +  compatible:
> +    const: invensense,itg3200
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    minItems: 1

No, maxItems instead. Look at other bindings.

> +
> +  mount-matrix:
> +    description: an optional 3x3 mounting rotation matrix.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        itg3200@68 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation




Best regards,
Krzysztof