From: Marek Vasut <marex@denx.de>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org, robert.foss@linaro.org,
"Christoph Niedermaier" <cniedermaier@dh-electronics.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Dmitry Osipenko" <digetx@gmail.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
devicetree@vger.kernel.org
Subject: Re: [RFC][PATCH 2/3] drm/modes: Make width-mm/height-mm mandatory in of_get_drm_panel_display_mode()
Date: Fri, 1 Apr 2022 22:36:24 +0200 [thread overview]
Message-ID: <efaa195a-bbdc-ca24-eccc-271995dfd27f@denx.de> (raw)
In-Reply-To: <YkdImJRIRkaqeGDl@pendragon.ideasonboard.com>
On 4/1/22 20:46, Laurent Pinchart wrote:
Hi,
> On Fri, Apr 01, 2022 at 06:37:54PM +0200, Marek Vasut wrote:
>> Make the width-mm/height-mm panel properties mandatory in
>> of_get_drm_panel_display_mode(), print error message and
>> return -ve in case these DT properties are not present.
>> This is needed to correctly report panel dimensions.
>
> Can we guarantee this won't cause a regression ?
For the upstream DTs, I think we can.
For downstream DTs, we cannot know.
next prev parent reply other threads:[~2022-04-01 20:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 16:37 [RFC][PATCH 1/3] dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory Marek Vasut
2022-04-01 16:37 ` [RFC][PATCH 2/3] drm/modes: Make width-mm/height-mm mandatory in of_get_drm_panel_display_mode() Marek Vasut
2022-04-01 18:46 ` Laurent Pinchart
2022-04-01 20:36 ` Marek Vasut [this message]
2022-04-02 3:19 ` Laurent Pinchart
2022-04-02 4:28 ` Marek Vasut
2022-04-02 7:45 ` Noralf Trønnes
2022-04-02 16:39 ` Marek Vasut
2022-04-02 17:08 ` Noralf Trønnes
2022-04-02 17:55 ` Marek Vasut
2022-04-02 20:08 ` Noralf Trønnes
2022-04-04 16:01 ` Rob Herring
2022-04-04 19:23 ` Marek Vasut
2022-04-01 16:37 ` [RFC][PATCH 3/3] drm/panel: lvds: Drop duplicate width-mm/height-mm check Marek Vasut
2022-04-01 18:49 ` Laurent Pinchart
2022-04-01 18:36 ` [RFC][PATCH 1/3] dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory Rob Herring
2022-04-01 18:45 ` Laurent Pinchart
2022-04-02 20:19 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efaa195a-bbdc-ca24-eccc-271995dfd27f@denx.de \
--to=marex@denx.de \
--cc=cniedermaier@dh-electronics.com \
--cc=daniel.vetter@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=noralf@tronnes.org \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).