From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 438E4C7EE45 for ; Tue, 9 May 2023 09:51:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234584AbjEIJuf (ORCPT ); Tue, 9 May 2023 05:50:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233534AbjEIJuA (ORCPT ); Tue, 9 May 2023 05:50:00 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42EE01BF7; Tue, 9 May 2023 02:49:55 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3499nji8034915; Tue, 9 May 2023 04:49:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1683625785; bh=/0tpUCP2f1xtcvYtIYbr/9f8Rv4j6HXpySHLSv1mYn8=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=hKihlEYp5zOBaJU8NDdDThOc8Rl5ZS5zWb9AJMekx4ZpaZuogbW2Hl4ByI9THmOBt lsLriqwyFKgxyOLVWHKucImTW+lRobz4BXzws0TfWHaXoep4Regjc9npeRgjBcefen ESt+QyuihwapwVw+RIz88InO/YKphKJP6tQTGTX8= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3499njpj117023 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 9 May 2023 04:49:45 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 9 May 2023 04:49:44 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 9 May 2023 04:49:45 -0500 Received: from [172.24.147.77] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3499nf8S032514; Tue, 9 May 2023 04:49:41 -0500 Message-ID: Date: Tue, 9 May 2023 15:19:40 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4: Fix wakeup pinmux range and pinctrl node offsets To: Nishanth Menon CC: Tero Kristo , Rob Herring , Krzysztof Kozlowski , , , , Andrew Davis , Vignesh Raghavendra , Apurva Nandan , Udit Kumar References: <20230503083143.32369-1-t-konduru@ti.com> <20230503114625.gqnijd3bog5bwemz@parameter> <31b31af7-6c54-7d05-f7ef-fcceba48580e@ti.com> <20230504115207.h6trzy4mqjcbkcm3@comment> <67eccecb-f4a4-7f15-5316-27fd39e65b51@ti.com> <20230504142239.hqhni2c52k3a3asz@prune> Content-Language: en-US From: Thejasvi Konduru In-Reply-To: <20230504142239.hqhni2c52k3a3asz@prune> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/05/23 19:52, Nishanth Menon wrote: > On 17:40-20230504, Thejasvi Konduru wrote: >> On 04/05/23 17:22, Nishanth Menon wrote: >>> On 14:36-20230504, Thejasvi Konduru wrote: >>>> On 03/05/23 17:16, Nishanth Menon wrote: >>>>> On 14:01-20230503, Thejasvi Konduru wrote: >>>>>> The wkup_pmx register region in j784s4 has multiple non-addressable >>>>>> regions, hence the existing wkup_pmx region is split as follows to >>>>>> avoid the non-addressable regions. The pinctrl node offsets are >>>>>> also corrected as per the newly split wkup_pmx* nodes. >>>>>> >>>>>> wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12) >>>>>> wkup_pmx1 -> 11 pins (WKUP_PADCONFIG 14 - 24) >>>>>> wkup_pmx2 -> 72 pins (WKUP_PADCONFIG 26 - 97) >>>>>> wkup_pmx3 -> 1 pin (WKUP_PADCONFIG 100) >>>>>> >>>>>> Fixes: 4664ebd8346a ("arm64: dts: ti: Add initial support for J784S4 SoC") >>>>>> Signed-off-by: Thejasvi Konduru >>>>>> --- >>>>> Could you provide a link to the output of: >>>>> $ cat /sys/kernel/debug/pinctrl/*/pins >>>> https://gist.github.com/thejasvikonduru/05b1a8e0fd8176116b7a3cc4e43b244a >>> Was this failing prior to this patch? Trying to understand the "Fix" >>> aspect of this patch. >>> >> Yes,it was failing prior to this patch. >> > next time some asks this question - give summary AND give a log. Even > better, please don't make folks even ask the question in the first > place by including the logs in the diffstat of the patch. > > Please share the log to understand what kind of "failure" was occurring. Link to logs: Before Fix: https://gist.github.com/thejasvikonduru/e217edf4839c348793a5671aa9331595 After Fix : https://gist.github.com/thejasvikonduru/05b1a8e0fd8176116b7a3cc4e43b244a >