From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A2ECA0FE2 for ; Fri, 1 Sep 2023 02:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347989AbjIACdb (ORCPT ); Thu, 31 Aug 2023 22:33:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231431AbjIACdb (ORCPT ); Thu, 31 Aug 2023 22:33:31 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BACBAE6E; Thu, 31 Aug 2023 19:33:27 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id BC58224E2E6; Fri, 1 Sep 2023 10:33:15 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 1 Sep 2023 10:33:15 +0800 Received: from [192.168.120.76] (171.223.208.138) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 1 Sep 2023 10:33:14 +0800 Message-ID: Date: Fri, 1 Sep 2023 10:33:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Drop unused properties To: Conor Dooley , Krzysztof Kozlowski CC: , , , , "Emil Renner Berthing" , Rob Herring , Jaehoon Chung , Ulf Hansson , "Krzysztof Kozlowski" , Conor Dooley , Paul Walmsley , "Palmer Dabbelt" , Albert Ou References: <20230830031846.127957-1-william.qiu@starfivetech.com> <20230830031846.127957-2-william.qiu@starfivetech.com> <20230830-commence-trickery-40eaa193cb15@wendy> <20230830-procedure-frostbite-56c751f7c276@wendy> Content-Language: en-US From: William Qiu In-Reply-To: <20230830-procedure-frostbite-56c751f7c276@wendy> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/8/30 16:34, Conor Dooley wrote: > On Wed, Aug 30, 2023 at 09:29:20AM +0200, Krzysztof Kozlowski wrote: >> On 30/08/2023 08:50, Conor Dooley wrote: >> > On Wed, Aug 30, 2023 at 11:18:44AM +0800, William Qiu wrote: >> >> Due to the change of tuning implementation, it's no longer necessary to >> >> use the "starfive,sysreg" property in dts, so drop the relevant >> >> description in dt-bindings here. >> > >> > How does changing your software implantation invalidate a description of >> > the hardware? >> > >> >> Which is kind of proof that this syscon was just to substitute >> incomplete hardware description (e.g. missing clocks and phys). We >> should have rejected it. Just like we should reject them in the future. > > :s I dunno what to do with this... I'm inclined to say not to remove it > from the binding or dts at all & only change the software. > >> There are just few cases where syscon is reasonable. All others is just >> laziness. It's not only starfivetech, of course. Several other >> contributors do the same. > > I'm not sure if laziness is fair, lack of understanding is usually more > likely. For this, I tend to keep it in binding, but remove it from required. Because we only modify the tuning implementation, it doesn't mean that this property need to be removed, it's just no longer be the required one. Best Regards, William