From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE429C38145 for ; Thu, 8 Sep 2022 13:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231324AbiIHNcc (ORCPT ); Thu, 8 Sep 2022 09:32:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232257AbiIHNcK (ORCPT ); Thu, 8 Sep 2022 09:32:10 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3166114A4E for ; Thu, 8 Sep 2022 06:30:54 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id z25so27769228lfr.2 for ; Thu, 08 Sep 2022 06:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=ssphXCw9dVc4K1o06caOSpIrGhXG1PGN20aX3IK807o=; b=ck4sfwitUujJ4vxU9ZOv8HwJvjGvsMZ6KqMM5evDrri5Rht9kYsiegBuwDv4+9EDIf sjrTTy8Gxx3SQwy8ByST/AKQejNj1a9cAEZQMJ+OuTI9ffYAJspQo7EsHenHmbfiqJxp PEZpXP253o7D9JwQ0QVeyamH+8975QarrG1O9qxnYlX01CoXQMLyJAXjtGKtxP69JJ+h kjKArCDi/ob5rxLp/VO4NN8u6S1qY0VkMfXrMBwFqaeJosDzvFQOTvcY4IIoUr47HXLM DB55Olq9kSsyaqRMyHVoAq2kr3zBVhcFSj15d6Fm8od7qVplq7ZQnBF7R6EkZ5cBxBJA H/7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=ssphXCw9dVc4K1o06caOSpIrGhXG1PGN20aX3IK807o=; b=62/r0CXVvwa2DAbxmwbDQCLb55hfA0Xs96Rt62Bsgdt0+tH8GuaJbMs88Myo0i38BU AA5YcmFdjQg9PIts2DjLaawegQ6ylBQynEUWlTeZOHnUVqi2+LOMNTUZlkMyZnO44kD1 mLZkRKYX3twihGPaf96h0F9kZx8MPblCZ6kKB6Eg1TCrNlUm255ZlRhKGgVOzzVKxoml rR9+/li6CXz543wMCjwg+3ErMe2hSKUr05yfVIqA1duxYgdbvhGrIRyDDMEwXA+gsWpX ualP/4dzFNQLlciHO80VoEgzyltCYfsCz5z8EjQl1XG89t0R2BGLMxnF5J3vhSLJFfo5 4akw== X-Gm-Message-State: ACgBeo1QaCGh96BZ2mjfzLRZqjmVpsdE5VjG8ItVSE5hJbv1kZfqn5ko nI3QDRcpm0ELLTBRkI0pN68vciFyEKZyzQ== X-Google-Smtp-Source: AA6agR4Cnrp8WVFsJsdGAqok1HmTtsifWI0ssMvOubIq728013GinG5Ar6anwjFrPPS71YUeXLYwHg== X-Received: by 2002:a05:6512:3ba9:b0:497:ab81:dca5 with SMTP id g41-20020a0565123ba900b00497ab81dca5mr1972140lfv.129.1662643839504; Thu, 08 Sep 2022 06:30:39 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 5-20020ac25f45000000b00498f0434efdsm221661lfz.19.2022.09.08.06.30.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 06:30:39 -0700 (PDT) Message-ID: Date: Thu, 8 Sep 2022 15:30:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v1] dt-bindings: iommu: mediatek: mt8195: Fix max interrupts Content-Language: en-US To: matthias.bgg@kernel.org, Yong Wu , Joerg Roedel , Will Deacon Cc: devicetree@vger.kernel.org, Robin Murphy , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , iommu@lists.linux.dev, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, Matthias Brugger References: <20220908132535.9350-1-matthias.bgg@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220908132535.9350-1-matthias.bgg@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/09/2022 15:25, matthias.bgg@kernel.org wrote: > From: Matthias Brugger > > The mt8195-iommu-infra has five banks and one interrupt for each. > Reflect that in the binding. > > Signed-off-by: Matthias Brugger > > --- > > .../bindings/iommu/mediatek,iommu.yaml | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > index fee0241b50988..621aca2adfb7f 100644 > --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > @@ -91,7 +91,7 @@ properties: > maxItems: 1 > > interrupts: > - maxItems: 1 Keep here wide constraints - minItems:1, maxItems:5 > + description: each bank has one dedicated interrupt > > clocks: > items: > @@ -183,6 +183,19 @@ allOf: > required: > - mediatek,infracfg > > + - if: > + properties: > + compatible: > + contains: > + const: mediatek,mt8195-iommu-infra > + > + then: > + properties: > + interrupts: > + maxItems: 5 and then minItems:5 > + required: > + - interrupts This seems unrelated and not really needed. > + > - if: # The IOMMUs don't have larbs. > not: > properties: > @@ -191,8 +204,12 @@ allOf: > const: mediatek,mt8195-iommu-infra > > then: > + properties: > + interrupts: > + maxItems: 1 > required: > - mediatek,larbs > + - interrupts This seems unrelated and not really needed. > > additionalProperties: false > Best regards, Krzysztof