devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@mailbox.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>,
	devicetree@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	dri-devel@lists.freedesktop.org,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Robert Foss <rfoss@kernel.org>, David Airlie <airlied@gmail.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	linux-renesas-soc@vger.kernel.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Simona Vetter <simona@ffwll.ch>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
Date: Fri, 5 Sep 2025 20:49:14 +0200	[thread overview]
Message-ID: <f008539e-2a7d-4958-a3b9-6c2a8b2e7388@mailbox.org> (raw)
In-Reply-To: <175708447882.930461.18275572084838852328.robh@kernel.org>

On 9/5/25 5:02 PM, Rob Herring (Arm) wrote:
> 
> On Thu, 04 Sep 2025 23:01:21 +0200, Marek Vasut wrote:
>> This controller can have both bridges and panels connected to it. In
>> order to describe panels properly in DT, pull in dsi-controller.yaml
>> and disallow only unevaluatedProperties, because the panel node is
>> optional. Include example binding with panel.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>> ---
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Robert Foss <rfoss@kernel.org>
>> Cc: Simona Vetter <simona@ffwll.ch>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>> Cc: devicetree@vger.kernel.org
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-renesas-soc@vger.kernel.org
>> ---
>> V2: Drop the dsi0: and dsi1: controller labels
>> ---
>>   .../display/bridge/renesas,dsi-csi2-tx.yaml   | 53 ++++++++++++++++++-
>>   1 file changed, 51 insertions(+), 2 deletions(-)
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb: panel@0 (raspberrypi,dsi-7inch): 'port' does not match any of the regexes: '^pinctrl-[0-9]+$'
> 	from schema $id: http://devicetree.org/schemas/display/panel/ilitek,ili9881c.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb: panel@0 (raspberrypi,dsi-7inch): compatible: ['raspberrypi,dsi-7inch'] is too short
> 	from schema $id: http://devicetree.org/schemas/display/panel/ilitek,ili9881c.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb: panel@0 (raspberrypi,dsi-7inch): 'power-supply' is a required property
> 	from schema $id: http://devicetree.org/schemas/display/panel/ilitek,ili9881c.yaml#
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250904210147.186728-4-marek.vasut+renesas@mailbox.org
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
I suspect this is already fixed in

[PATCH] dt-bindings: ili9881c: Allow port subnode

which updates the ili9881c/rpi panel binding a bit, to allow port subnode .

  reply	other threads:[~2025-09-05 18:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 21:01 [PATCH v2 1/4] arm64: dts: renesas: r8a779a0: Rename dsi-encoder@ to dsi@ Marek Vasut
2025-09-04 21:01 ` [PATCH v2 2/4] arm64: dts: renesas: r8a779g0: " Marek Vasut
2025-09-11 14:32   ` Geert Uytterhoeven
2025-09-04 21:01 ` [PATCH v2 3/4] arm64: dts: renesas: r8a779h0: " Marek Vasut
2025-09-11 14:33   ` Geert Uytterhoeven
2025-09-04 21:01 ` [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode Marek Vasut
2025-09-05  7:51   ` Neil Armstrong
2025-09-05 15:02   ` Rob Herring (Arm)
2025-09-05 18:49     ` Marek Vasut [this message]
2025-09-08  7:43   ` Tomi Valkeinen
2025-09-08 12:54     ` Marek Vasut
2025-09-16  8:15       ` Marek Vasut
2025-09-19 15:21       ` Tomi Valkeinen
2025-09-19 15:42         ` Marek Vasut
2025-09-19 15:49           ` Tomi Valkeinen
2025-09-19 17:03           ` Tomi Valkeinen
2025-09-19 17:08             ` Marek Vasut
2025-10-15 14:09               ` Marek Vasut
2025-10-22  7:19                 ` Tomi Valkeinen
2025-10-22 12:45                   ` Marek Vasut
2025-10-29 18:44                   ` Rob Herring
2025-10-29 19:14                     ` Marek Vasut
2025-09-11 14:31 ` [PATCH v2 1/4] arm64: dts: renesas: r8a779a0: Rename dsi-encoder@ to dsi@ Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f008539e-2a7d-4958-a3b9-6c2a8b2e7388@mailbox.org \
    --to=marek.vasut@mailbox.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tomi.valkeinen+renesas@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).