* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-09-04 21:01 ` [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode Marek Vasut
@ 2025-09-05 7:51 ` Neil Armstrong
2025-09-05 15:02 ` Rob Herring (Arm)
2025-09-08 7:43 ` Tomi Valkeinen
2 siblings, 0 replies; 23+ messages in thread
From: Neil Armstrong @ 2025-09-05 7:51 UTC (permalink / raw)
To: Marek Vasut, dri-devel
Cc: Conor Dooley, David Airlie, Geert Uytterhoeven, Kieran Bingham,
Krzysztof Kozlowski, Laurent Pinchart, Rob Herring, Robert Foss,
Simona Vetter, Thomas Zimmermann, Tomi Valkeinen, devicetree,
linux-renesas-soc
On 04/09/2025 23:01, Marek Vasut wrote:
> This controller can have both bridges and panels connected to it. In
> order to describe panels properly in DT, pull in dsi-controller.yaml
> and disallow only unevaluatedProperties, because the panel node is
> optional. Include example binding with panel.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-renesas-soc@vger.kernel.org
> ---
> V2: Drop the dsi0: and dsi1: controller labels
> ---
> .../display/bridge/renesas,dsi-csi2-tx.yaml | 53 ++++++++++++++++++-
> 1 file changed, 51 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml
> index c167795c63f64..51d685ed82891 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml
> @@ -14,6 +14,9 @@ description: |
> R-Car Gen4 SoCs. The encoder can operate in either DSI or CSI-2 mode, with up
> to four data lanes.
>
> +allOf:
> + - $ref: /schemas/display/dsi-controller.yaml#
> +
> properties:
> compatible:
> enum:
> @@ -80,14 +83,14 @@ required:
> - resets
> - ports
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
> #include <dt-bindings/clock/r8a779a0-cpg-mssr.h>
> #include <dt-bindings/power/r8a779a0-sysc.h>
>
> - dsi0: dsi-encoder@fed80000 {
> + dsi@fed80000 {
> compatible = "renesas,r8a779a0-dsi-csi2-tx";
> reg = <0xfed80000 0x10000>;
> power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> @@ -117,4 +120,50 @@ examples:
> };
> };
> };
> +
> + - |
> + #include <dt-bindings/clock/r8a779g0-cpg-mssr.h>
> + #include <dt-bindings/power/r8a779g0-sysc.h>
> +
> + dsi@fed80000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "renesas,r8a779g0-dsi-csi2-tx";
> + reg = <0xfed80000 0x10000>;
> + clocks = <&cpg CPG_MOD 415>,
> + <&cpg CPG_CORE R8A779G0_CLK_DSIEXT>,
> + <&cpg CPG_CORE R8A779G0_CLK_DSIREF>;
> + clock-names = "fck", "dsi", "pll";
> + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> + resets = <&cpg 415>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + dsi0port1_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + data-lanes = <1 2>;
> + };
> + };
> + };
> +
> + panel@0 {
> + reg = <0>;
> + compatible = "raspberrypi,dsi-7inch";
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&dsi0port1_out>;
> + };
> + };
> + };
> + };
> ...
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-09-04 21:01 ` [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode Marek Vasut
2025-09-05 7:51 ` Neil Armstrong
@ 2025-09-05 15:02 ` Rob Herring (Arm)
2025-09-05 18:49 ` Marek Vasut
2025-09-08 7:43 ` Tomi Valkeinen
2 siblings, 1 reply; 23+ messages in thread
From: Rob Herring (Arm) @ 2025-09-05 15:02 UTC (permalink / raw)
To: Marek Vasut
Cc: Tomi Valkeinen, devicetree, Geert Uytterhoeven, dri-devel,
Laurent Pinchart, Robert Foss, David Airlie, Kieran Bingham,
linux-renesas-soc, Krzysztof Kozlowski, Conor Dooley,
Simona Vetter, Neil Armstrong, Thomas Zimmermann
On Thu, 04 Sep 2025 23:01:21 +0200, Marek Vasut wrote:
> This controller can have both bridges and panels connected to it. In
> order to describe panels properly in DT, pull in dsi-controller.yaml
> and disallow only unevaluatedProperties, because the panel node is
> optional. Include example binding with panel.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-renesas-soc@vger.kernel.org
> ---
> V2: Drop the dsi0: and dsi1: controller labels
> ---
> .../display/bridge/renesas,dsi-csi2-tx.yaml | 53 ++++++++++++++++++-
> 1 file changed, 51 insertions(+), 2 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb: panel@0 (raspberrypi,dsi-7inch): 'port' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/display/panel/ilitek,ili9881c.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb: panel@0 (raspberrypi,dsi-7inch): compatible: ['raspberrypi,dsi-7inch'] is too short
from schema $id: http://devicetree.org/schemas/display/panel/ilitek,ili9881c.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb: panel@0 (raspberrypi,dsi-7inch): 'power-supply' is a required property
from schema $id: http://devicetree.org/schemas/display/panel/ilitek,ili9881c.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250904210147.186728-4-marek.vasut+renesas@mailbox.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-09-05 15:02 ` Rob Herring (Arm)
@ 2025-09-05 18:49 ` Marek Vasut
0 siblings, 0 replies; 23+ messages in thread
From: Marek Vasut @ 2025-09-05 18:49 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Tomi Valkeinen, devicetree, Geert Uytterhoeven, dri-devel,
Laurent Pinchart, Robert Foss, David Airlie, Kieran Bingham,
linux-renesas-soc, Krzysztof Kozlowski, Conor Dooley,
Simona Vetter, Neil Armstrong, Thomas Zimmermann
On 9/5/25 5:02 PM, Rob Herring (Arm) wrote:
>
> On Thu, 04 Sep 2025 23:01:21 +0200, Marek Vasut wrote:
>> This controller can have both bridges and panels connected to it. In
>> order to describe panels properly in DT, pull in dsi-controller.yaml
>> and disallow only unevaluatedProperties, because the panel node is
>> optional. Include example binding with panel.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>> ---
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Robert Foss <rfoss@kernel.org>
>> Cc: Simona Vetter <simona@ffwll.ch>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>> Cc: devicetree@vger.kernel.org
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-renesas-soc@vger.kernel.org
>> ---
>> V2: Drop the dsi0: and dsi1: controller labels
>> ---
>> .../display/bridge/renesas,dsi-csi2-tx.yaml | 53 ++++++++++++++++++-
>> 1 file changed, 51 insertions(+), 2 deletions(-)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb: panel@0 (raspberrypi,dsi-7inch): 'port' does not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/display/panel/ilitek,ili9881c.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb: panel@0 (raspberrypi,dsi-7inch): compatible: ['raspberrypi,dsi-7inch'] is too short
> from schema $id: http://devicetree.org/schemas/display/panel/ilitek,ili9881c.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb: panel@0 (raspberrypi,dsi-7inch): 'power-supply' is a required property
> from schema $id: http://devicetree.org/schemas/display/panel/ilitek,ili9881c.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250904210147.186728-4-marek.vasut+renesas@mailbox.org
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
I suspect this is already fixed in
[PATCH] dt-bindings: ili9881c: Allow port subnode
which updates the ili9881c/rpi panel binding a bit, to allow port subnode .
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-09-04 21:01 ` [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode Marek Vasut
2025-09-05 7:51 ` Neil Armstrong
2025-09-05 15:02 ` Rob Herring (Arm)
@ 2025-09-08 7:43 ` Tomi Valkeinen
2025-09-08 12:54 ` Marek Vasut
2 siblings, 1 reply; 23+ messages in thread
From: Tomi Valkeinen @ 2025-09-08 7:43 UTC (permalink / raw)
To: Marek Vasut, dri-devel
Cc: Conor Dooley, David Airlie, Geert Uytterhoeven, Kieran Bingham,
Krzysztof Kozlowski, Laurent Pinchart, Neil Armstrong,
Rob Herring, Robert Foss, Simona Vetter, Thomas Zimmermann,
devicetree, linux-renesas-soc
Hi,
On 05/09/2025 00:01, Marek Vasut wrote:
> This controller can have both bridges and panels connected to it. In
> order to describe panels properly in DT, pull in dsi-controller.yaml
> and disallow only unevaluatedProperties, because the panel node is
> optional. Include example binding with panel.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-renesas-soc@vger.kernel.org
> ---
> V2: Drop the dsi0: and dsi1: controller labels
> ---
> .../display/bridge/renesas,dsi-csi2-tx.yaml | 53 ++++++++++++++++++-
> 1 file changed, 51 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml
> index c167795c63f64..51d685ed82891 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml
> @@ -14,6 +14,9 @@ description: |
> R-Car Gen4 SoCs. The encoder can operate in either DSI or CSI-2 mode, with up
> to four data lanes.
>
> +allOf:
> + - $ref: /schemas/display/dsi-controller.yaml#
> +
Did you try with a bridge? dsi-controller.yaml only allows a panel. I
think I discussed this with someone not long ago, but I couldn't find
any patch sent for that.
Tomi
> properties:
> compatible:
> enum:
> @@ -80,14 +83,14 @@ required:
> - resets
> - ports
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
> #include <dt-bindings/clock/r8a779a0-cpg-mssr.h>
> #include <dt-bindings/power/r8a779a0-sysc.h>
>
> - dsi0: dsi-encoder@fed80000 {
> + dsi@fed80000 {
> compatible = "renesas,r8a779a0-dsi-csi2-tx";
> reg = <0xfed80000 0x10000>;
> power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> @@ -117,4 +120,50 @@ examples:
> };
> };
> };
> +
> + - |
> + #include <dt-bindings/clock/r8a779g0-cpg-mssr.h>
> + #include <dt-bindings/power/r8a779g0-sysc.h>
> +
> + dsi@fed80000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "renesas,r8a779g0-dsi-csi2-tx";
> + reg = <0xfed80000 0x10000>;
> + clocks = <&cpg CPG_MOD 415>,
> + <&cpg CPG_CORE R8A779G0_CLK_DSIEXT>,
> + <&cpg CPG_CORE R8A779G0_CLK_DSIREF>;
> + clock-names = "fck", "dsi", "pll";
> + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> + resets = <&cpg 415>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + dsi0port1_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + data-lanes = <1 2>;
> + };
> + };
> + };
> +
> + panel@0 {
> + reg = <0>;
> + compatible = "raspberrypi,dsi-7inch";
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&dsi0port1_out>;
> + };
> + };
> + };
> + };
> ...
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-09-08 7:43 ` Tomi Valkeinen
@ 2025-09-08 12:54 ` Marek Vasut
2025-09-16 8:15 ` Marek Vasut
2025-09-19 15:21 ` Tomi Valkeinen
0 siblings, 2 replies; 23+ messages in thread
From: Marek Vasut @ 2025-09-08 12:54 UTC (permalink / raw)
To: Tomi Valkeinen, Marek Vasut, dri-devel
Cc: Conor Dooley, David Airlie, Geert Uytterhoeven, Kieran Bingham,
Krzysztof Kozlowski, Laurent Pinchart, Neil Armstrong,
Rob Herring, Robert Foss, Simona Vetter, Thomas Zimmermann,
devicetree, linux-renesas-soc
On 9/8/25 9:43 AM, Tomi Valkeinen wrote:
> Hi,
Hello Tomi,
> On 05/09/2025 00:01, Marek Vasut wrote:
>> This controller can have both bridges and panels connected to it. In
>> order to describe panels properly in DT, pull in dsi-controller.yaml
>> and disallow only unevaluatedProperties, because the panel node is
>> optional. Include example binding with panel.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>> ---
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Robert Foss <rfoss@kernel.org>
>> Cc: Simona Vetter <simona@ffwll.ch>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>> Cc: devicetree@vger.kernel.org
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-renesas-soc@vger.kernel.org
>> ---
>> V2: Drop the dsi0: and dsi1: controller labels
>> ---
>> .../display/bridge/renesas,dsi-csi2-tx.yaml | 53 ++++++++++++++++++-
>> 1 file changed, 51 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml
>> index c167795c63f64..51d685ed82891 100644
>> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml
>> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml
>> @@ -14,6 +14,9 @@ description: |
>> R-Car Gen4 SoCs. The encoder can operate in either DSI or CSI-2 mode, with up
>> to four data lanes.
>>
>> +allOf:
>> + - $ref: /schemas/display/dsi-controller.yaml#
>> +
>
> Did you try with a bridge? dsi-controller.yaml only allows a panel. I
> think I discussed this with someone not long ago, but I couldn't find
> any patch sent for that.
Nope, I only have these two 5" and 7" RPi Display 2 panels.
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-09-08 12:54 ` Marek Vasut
@ 2025-09-16 8:15 ` Marek Vasut
2025-09-19 15:21 ` Tomi Valkeinen
1 sibling, 0 replies; 23+ messages in thread
From: Marek Vasut @ 2025-09-16 8:15 UTC (permalink / raw)
To: Tomi Valkeinen, Marek Vasut, dri-devel
Cc: Conor Dooley, David Airlie, Geert Uytterhoeven, Kieran Bingham,
Krzysztof Kozlowski, Laurent Pinchart, Neil Armstrong,
Rob Herring, Robert Foss, Simona Vetter, Thomas Zimmermann,
devicetree, linux-renesas-soc
On 9/8/25 2:54 PM, Marek Vasut wrote:
Hello Tomi,
>> On 05/09/2025 00:01, Marek Vasut wrote:
>>> This controller can have both bridges and panels connected to it. In
>>> order to describe panels properly in DT, pull in dsi-controller.yaml
>>> and disallow only unevaluatedProperties, because the panel node is
>>> optional. Include example binding with panel.
>>>
>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>>> ---
>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>> Cc: David Airlie <airlied@gmail.com>
>>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>>> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>>> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>>> Cc: Rob Herring <robh@kernel.org>
>>> Cc: Robert Foss <rfoss@kernel.org>
>>> Cc: Simona Vetter <simona@ffwll.ch>
>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>>> Cc: devicetree@vger.kernel.org
>>> Cc: dri-devel@lists.freedesktop.org
>>> Cc: linux-renesas-soc@vger.kernel.org
>>> ---
>>> V2: Drop the dsi0: and dsi1: controller labels
>>> ---
>>> .../display/bridge/renesas,dsi-csi2-tx.yaml | 53 ++++++++++++++++++-
>>> 1 file changed, 51 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/bridge/
>>> renesas,dsi-csi2-tx.yaml b/Documentation/devicetree/bindings/display/
>>> bridge/renesas,dsi-csi2-tx.yaml
>>> index c167795c63f64..51d685ed82891 100644
>>> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dsi-
>>> csi2-tx.yaml
>>> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-
>>> csi2-tx.yaml
>>> @@ -14,6 +14,9 @@ description: |
>>> R-Car Gen4 SoCs. The encoder can operate in either DSI or CSI-2
>>> mode, with up
>>> to four data lanes.
>>> +allOf:
>>> + - $ref: /schemas/display/dsi-controller.yaml#
>>> +
>>
>> Did you try with a bridge? dsi-controller.yaml only allows a panel. I
>> think I discussed this with someone not long ago, but I couldn't find
>> any patch sent for that.
> Nope, I only have these two 5" and 7" RPi Display 2 panels.
How can we proceed here ?
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-09-08 12:54 ` Marek Vasut
2025-09-16 8:15 ` Marek Vasut
@ 2025-09-19 15:21 ` Tomi Valkeinen
2025-09-19 15:42 ` Marek Vasut
1 sibling, 1 reply; 23+ messages in thread
From: Tomi Valkeinen @ 2025-09-19 15:21 UTC (permalink / raw)
To: Marek Vasut, Marek Vasut, dri-devel
Cc: Conor Dooley, David Airlie, Geert Uytterhoeven, Kieran Bingham,
Krzysztof Kozlowski, Laurent Pinchart, Neil Armstrong,
Rob Herring, Robert Foss, Simona Vetter, Thomas Zimmermann,
devicetree, linux-renesas-soc
Hi,
On 08/09/2025 15:54, Marek Vasut wrote:
> On 9/8/25 9:43 AM, Tomi Valkeinen wrote:
>> Hi,
>
> Hello Tomi,
>
>> On 05/09/2025 00:01, Marek Vasut wrote:
>>> This controller can have both bridges and panels connected to it. In
>>> order to describe panels properly in DT, pull in dsi-controller.yaml
>>> and disallow only unevaluatedProperties, because the panel node is
>>> optional. Include example binding with panel.
>>>
>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>>> ---
>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>> Cc: David Airlie <airlied@gmail.com>
>>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>>> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>>> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>>> Cc: Rob Herring <robh@kernel.org>
>>> Cc: Robert Foss <rfoss@kernel.org>
>>> Cc: Simona Vetter <simona@ffwll.ch>
>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>>> Cc: devicetree@vger.kernel.org
>>> Cc: dri-devel@lists.freedesktop.org
>>> Cc: linux-renesas-soc@vger.kernel.org
>>> ---
>>> V2: Drop the dsi0: and dsi1: controller labels
>>> ---
>>> .../display/bridge/renesas,dsi-csi2-tx.yaml | 53 ++++++++++++++++++-
>>> 1 file changed, 51 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/bridge/
>>> renesas,dsi-csi2-tx.yaml b/Documentation/devicetree/bindings/display/
>>> bridge/renesas,dsi-csi2-tx.yaml
>>> index c167795c63f64..51d685ed82891 100644
>>> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dsi-
>>> csi2-tx.yaml
>>> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-
>>> csi2-tx.yaml
>>> @@ -14,6 +14,9 @@ description: |
>>> R-Car Gen4 SoCs. The encoder can operate in either DSI or CSI-2
>>> mode, with up
>>> to four data lanes.
>>> +allOf:
>>> + - $ref: /schemas/display/dsi-controller.yaml#
>>> +
>>
>> Did you try with a bridge? dsi-controller.yaml only allows a panel. I
>> think I discussed this with someone not long ago, but I couldn't find
>> any patch sent for that.
> Nope, I only have these two 5" and 7" RPi Display 2 panels.
Ok. My point was just that the dsi-controller.yaml doesn't allow
"bridge" node (you can just rename the panel to bridge to test). I
thought someone (I just can't remember who was it =) will send a patch
for it, but I think that hasn't happened.
Tomi
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-09-19 15:21 ` Tomi Valkeinen
@ 2025-09-19 15:42 ` Marek Vasut
2025-09-19 15:49 ` Tomi Valkeinen
2025-09-19 17:03 ` Tomi Valkeinen
0 siblings, 2 replies; 23+ messages in thread
From: Marek Vasut @ 2025-09-19 15:42 UTC (permalink / raw)
To: Tomi Valkeinen, Marek Vasut, dri-devel
Cc: Conor Dooley, David Airlie, Geert Uytterhoeven, Kieran Bingham,
Krzysztof Kozlowski, Laurent Pinchart, Neil Armstrong,
Rob Herring, Robert Foss, Simona Vetter, Thomas Zimmermann,
devicetree, linux-renesas-soc
On 9/19/25 5:21 PM, Tomi Valkeinen wrote:
Hello Tomi,
>>> On 05/09/2025 00:01, Marek Vasut wrote:
>>>> This controller can have both bridges and panels connected to it. In
>>>> order to describe panels properly in DT, pull in dsi-controller.yaml
>>>> and disallow only unevaluatedProperties, because the panel node is
>>>> optional. Include example binding with panel.
>>>>
>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>>>> ---
>>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>>> Cc: David Airlie <airlied@gmail.com>
>>>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>>>> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>>>> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>>>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>>>> Cc: Rob Herring <robh@kernel.org>
>>>> Cc: Robert Foss <rfoss@kernel.org>
>>>> Cc: Simona Vetter <simona@ffwll.ch>
>>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>>> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>>>> Cc: devicetree@vger.kernel.org
>>>> Cc: dri-devel@lists.freedesktop.org
>>>> Cc: linux-renesas-soc@vger.kernel.org
>>>> ---
>>>> V2: Drop the dsi0: and dsi1: controller labels
>>>> ---
>>>> .../display/bridge/renesas,dsi-csi2-tx.yaml | 53 ++++++++++++++++++-
>>>> 1 file changed, 51 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/display/bridge/
>>>> renesas,dsi-csi2-tx.yaml b/Documentation/devicetree/bindings/display/
>>>> bridge/renesas,dsi-csi2-tx.yaml
>>>> index c167795c63f64..51d685ed82891 100644
>>>> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dsi-
>>>> csi2-tx.yaml
>>>> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-
>>>> csi2-tx.yaml
>>>> @@ -14,6 +14,9 @@ description: |
>>>> R-Car Gen4 SoCs. The encoder can operate in either DSI or CSI-2
>>>> mode, with up
>>>> to four data lanes.
>>>> +allOf:
>>>> + - $ref: /schemas/display/dsi-controller.yaml#
>>>> +
>>>
>>> Did you try with a bridge? dsi-controller.yaml only allows a panel. I
>>> think I discussed this with someone not long ago, but I couldn't find
>>> any patch sent for that.
>> Nope, I only have these two 5" and 7" RPi Display 2 panels.
>
> Ok. My point was just that the dsi-controller.yaml doesn't allow
> "bridge" node (you can just rename the panel to bridge to test). I
> thought someone (I just can't remember who was it =) will send a patch
> for it, but I think that hasn't happened.
Do you want me to drop the bridge part from the commit message (I assume
yes) ?
Any other change I should do before sending a V3 ?
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-09-19 15:42 ` Marek Vasut
@ 2025-09-19 15:49 ` Tomi Valkeinen
2025-09-19 17:03 ` Tomi Valkeinen
1 sibling, 0 replies; 23+ messages in thread
From: Tomi Valkeinen @ 2025-09-19 15:49 UTC (permalink / raw)
To: Marek Vasut, Marek Vasut, dri-devel
Cc: Conor Dooley, David Airlie, Geert Uytterhoeven, Kieran Bingham,
Krzysztof Kozlowski, Laurent Pinchart, Neil Armstrong,
Rob Herring, Robert Foss, Simona Vetter, Thomas Zimmermann,
devicetree, linux-renesas-soc
Hi,
On 19/09/2025 18:42, Marek Vasut wrote:
> On 9/19/25 5:21 PM, Tomi Valkeinen wrote:
>
> Hello Tomi,
>
>>>> On 05/09/2025 00:01, Marek Vasut wrote:
>>>>> This controller can have both bridges and panels connected to it. In
>>>>> order to describe panels properly in DT, pull in dsi-controller.yaml
>>>>> and disallow only unevaluatedProperties, because the panel node is
>>>>> optional. Include example binding with panel.
>>>>>
>>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>>>>> ---
>>>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>>>> Cc: David Airlie <airlied@gmail.com>
>>>>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>>>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>>>>> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>>>>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>>>>> Cc: Rob Herring <robh@kernel.org>
>>>>> Cc: Robert Foss <rfoss@kernel.org>
>>>>> Cc: Simona Vetter <simona@ffwll.ch>
>>>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>>>> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>>>>> Cc: devicetree@vger.kernel.org
>>>>> Cc: dri-devel@lists.freedesktop.org
>>>>> Cc: linux-renesas-soc@vger.kernel.org
>>>>> ---
>>>>> V2: Drop the dsi0: and dsi1: controller labels
>>>>> ---
>>>>> .../display/bridge/renesas,dsi-csi2-tx.yaml | 53 +++++++++++++
>>>>> +++++-
>>>>> 1 file changed, 51 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/display/bridge/
>>>>> renesas,dsi-csi2-tx.yaml b/Documentation/devicetree/bindings/display/
>>>>> bridge/renesas,dsi-csi2-tx.yaml
>>>>> index c167795c63f64..51d685ed82891 100644
>>>>> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dsi-
>>>>> csi2-tx.yaml
>>>>> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-
>>>>> csi2-tx.yaml
>>>>> @@ -14,6 +14,9 @@ description: |
>>>>> R-Car Gen4 SoCs. The encoder can operate in either DSI or CSI-2
>>>>> mode, with up
>>>>> to four data lanes.
>>>>> +allOf:
>>>>> + - $ref: /schemas/display/dsi-controller.yaml#
>>>>> +
>>>>
>>>> Did you try with a bridge? dsi-controller.yaml only allows a panel. I
>>>> think I discussed this with someone not long ago, but I couldn't find
>>>> any patch sent for that.
>>> Nope, I only have these two 5" and 7" RPi Display 2 panels.
>>
>> Ok. My point was just that the dsi-controller.yaml doesn't allow
>> "bridge" node (you can just rename the panel to bridge to test). I
>> thought someone (I just can't remember who was it =) will send a patch
>> for it, but I think that hasn't happened.
> Do you want me to drop the bridge part from the commit message (I assume
> yes) ?
It's not clear to me if the binding before this patch supported both
panels and bridges as DSI peripherals, or neither, only "external" ones,
i.e. i2c?.
If it supported bridges earlier, and now doesn't, it's a regression in
the binding.
What I want is for someone to fix dsi-controller.yaml (hint hint!), but
as for this patch, assuming there's no regression, I think it's fine to
just mention that only panels are currently supported due to
dsi-controller.yaml.
Tomi
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-09-19 15:42 ` Marek Vasut
2025-09-19 15:49 ` Tomi Valkeinen
@ 2025-09-19 17:03 ` Tomi Valkeinen
2025-09-19 17:08 ` Marek Vasut
1 sibling, 1 reply; 23+ messages in thread
From: Tomi Valkeinen @ 2025-09-19 17:03 UTC (permalink / raw)
To: Marek Vasut, Marek Vasut, dri-devel
Cc: Conor Dooley, David Airlie, Geert Uytterhoeven, Kieran Bingham,
Krzysztof Kozlowski, Laurent Pinchart, Neil Armstrong,
Rob Herring, Robert Foss, Simona Vetter, Thomas Zimmermann,
devicetree, linux-renesas-soc
Hi,
On 19/09/2025 18:42, Marek Vasut wrote:
> On 9/19/25 5:21 PM, Tomi Valkeinen wrote:
>
> Hello Tomi,
>
>>>> On 05/09/2025 00:01, Marek Vasut wrote:
>>>>> This controller can have both bridges and panels connected to it. In
>>>>> order to describe panels properly in DT, pull in dsi-controller.yaml
>>>>> and disallow only unevaluatedProperties, because the panel node is
>>>>> optional. Include example binding with panel.
>>>>>
>>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>>>>> ---
>>>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>>>> Cc: David Airlie <airlied@gmail.com>
>>>>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>>>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>>>>> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>>>>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>>>>> Cc: Rob Herring <robh@kernel.org>
>>>>> Cc: Robert Foss <rfoss@kernel.org>
>>>>> Cc: Simona Vetter <simona@ffwll.ch>
>>>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>>>> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>>>>> Cc: devicetree@vger.kernel.org
>>>>> Cc: dri-devel@lists.freedesktop.org
>>>>> Cc: linux-renesas-soc@vger.kernel.org
>>>>> ---
>>>>> V2: Drop the dsi0: and dsi1: controller labels
>>>>> ---
>>>>> .../display/bridge/renesas,dsi-csi2-tx.yaml | 53 +++++++++++++
>>>>> +++++-
>>>>> 1 file changed, 51 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/display/bridge/
>>>>> renesas,dsi-csi2-tx.yaml b/Documentation/devicetree/bindings/display/
>>>>> bridge/renesas,dsi-csi2-tx.yaml
>>>>> index c167795c63f64..51d685ed82891 100644
>>>>> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dsi-
>>>>> csi2-tx.yaml
>>>>> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-
>>>>> csi2-tx.yaml
>>>>> @@ -14,6 +14,9 @@ description: |
>>>>> R-Car Gen4 SoCs. The encoder can operate in either DSI or CSI-2
>>>>> mode, with up
>>>>> to four data lanes.
>>>>> +allOf:
>>>>> + - $ref: /schemas/display/dsi-controller.yaml#
>>>>> +
>>>>
>>>> Did you try with a bridge? dsi-controller.yaml only allows a panel. I
>>>> think I discussed this with someone not long ago, but I couldn't find
>>>> any patch sent for that.
>>> Nope, I only have these two 5" and 7" RPi Display 2 panels.
>>
>> Ok. My point was just that the dsi-controller.yaml doesn't allow
>> "bridge" node (you can just rename the panel to bridge to test). I
>> thought someone (I just can't remember who was it =) will send a patch
>> for it, but I think that hasn't happened.
> Do you want me to drop the bridge part from the commit message (I assume
> yes) ?
>
> Any other change I should do before sending a V3 ?
As we found out, this has been fixed in linux-next. For this, and the
rest in this series:
Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Tomi
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-09-19 17:03 ` Tomi Valkeinen
@ 2025-09-19 17:08 ` Marek Vasut
2025-10-15 14:09 ` Marek Vasut
0 siblings, 1 reply; 23+ messages in thread
From: Marek Vasut @ 2025-09-19 17:08 UTC (permalink / raw)
To: Tomi Valkeinen, Marek Vasut, dri-devel
Cc: Conor Dooley, David Airlie, Geert Uytterhoeven, Kieran Bingham,
Krzysztof Kozlowski, Laurent Pinchart, Neil Armstrong,
Rob Herring, Robert Foss, Simona Vetter, Thomas Zimmermann,
devicetree, linux-renesas-soc
On 9/19/25 7:03 PM, Tomi Valkeinen wrote:
Hello Tomi,
>>> Ok. My point was just that the dsi-controller.yaml doesn't allow
>>> "bridge" node (you can just rename the panel to bridge to test). I
>>> thought someone (I just can't remember who was it =) will send a patch
>>> for it, but I think that hasn't happened.
>> Do you want me to drop the bridge part from the commit message (I assume
>> yes) ?
>>
>> Any other change I should do before sending a V3 ?
>
> As we found out, this has been fixed in linux-next. For this, and the
> rest in this series:
>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Understood, thank you.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-09-19 17:08 ` Marek Vasut
@ 2025-10-15 14:09 ` Marek Vasut
2025-10-22 7:19 ` Tomi Valkeinen
0 siblings, 1 reply; 23+ messages in thread
From: Marek Vasut @ 2025-10-15 14:09 UTC (permalink / raw)
To: Tomi Valkeinen, dri-devel
Cc: Conor Dooley, David Airlie, Geert Uytterhoeven, Kieran Bingham,
Krzysztof Kozlowski, Laurent Pinchart, Neil Armstrong,
Rob Herring, Robert Foss, Simona Vetter, Thomas Zimmermann,
devicetree, linux-renesas-soc
On 9/19/25 7:08 PM, Marek Vasut wrote:
Hello Tomi,
>>>> Ok. My point was just that the dsi-controller.yaml doesn't allow
>>>> "bridge" node (you can just rename the panel to bridge to test). I
>>>> thought someone (I just can't remember who was it =) will send a patch
>>>> for it, but I think that hasn't happened.
>>> Do you want me to drop the bridge part from the commit message (I assume
>>> yes) ?
>>>
>>> Any other change I should do before sending a V3 ?
>>
>> As we found out, this has been fixed in linux-next. For this, and the
>> rest in this series:
>>
>> Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>
> Understood, thank you.
Do you think this 4/4 can now be applied ? The rest already is.
Thank you
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-10-15 14:09 ` Marek Vasut
@ 2025-10-22 7:19 ` Tomi Valkeinen
2025-10-22 12:45 ` Marek Vasut
2025-10-29 18:44 ` Rob Herring
0 siblings, 2 replies; 23+ messages in thread
From: Tomi Valkeinen @ 2025-10-22 7:19 UTC (permalink / raw)
To: Marek Vasut, dri-devel
Cc: Conor Dooley, David Airlie, Geert Uytterhoeven, Kieran Bingham,
Krzysztof Kozlowski, Laurent Pinchart, Neil Armstrong,
Rob Herring, Robert Foss, Simona Vetter, Thomas Zimmermann,
devicetree, linux-renesas-soc
Hi,
On 15/10/2025 17:09, Marek Vasut wrote:
> On 9/19/25 7:08 PM, Marek Vasut wrote:
>
> Hello Tomi,
>
>>>>> Ok. My point was just that the dsi-controller.yaml doesn't allow
>>>>> "bridge" node (you can just rename the panel to bridge to test). I
>>>>> thought someone (I just can't remember who was it =) will send a patch
>>>>> for it, but I think that hasn't happened.
>>>> Do you want me to drop the bridge part from the commit message (I
>>>> assume
>>>> yes) ?
>>>>
>>>> Any other change I should do before sending a V3 ?
>>>
>>> As we found out, this has been fixed in linux-next. For this, and the
>>> rest in this series:
>>>
>>> Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>>
>> Understood, thank you.
> Do you think this 4/4 can now be applied ? The rest already is.
Pushed to drm-misc-next.
Tomi
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-10-22 7:19 ` Tomi Valkeinen
@ 2025-10-22 12:45 ` Marek Vasut
2025-10-29 18:44 ` Rob Herring
1 sibling, 0 replies; 23+ messages in thread
From: Marek Vasut @ 2025-10-22 12:45 UTC (permalink / raw)
To: Tomi Valkeinen, dri-devel
Cc: Conor Dooley, David Airlie, Geert Uytterhoeven, Kieran Bingham,
Krzysztof Kozlowski, Laurent Pinchart, Neil Armstrong,
Rob Herring, Robert Foss, Simona Vetter, Thomas Zimmermann,
devicetree, linux-renesas-soc
On 10/22/25 9:19 AM, Tomi Valkeinen wrote:
Hello Tomi,
>>>>>> Ok. My point was just that the dsi-controller.yaml doesn't allow
>>>>>> "bridge" node (you can just rename the panel to bridge to test). I
>>>>>> thought someone (I just can't remember who was it =) will send a patch
>>>>>> for it, but I think that hasn't happened.
>>>>> Do you want me to drop the bridge part from the commit message (I
>>>>> assume
>>>>> yes) ?
>>>>>
>>>>> Any other change I should do before sending a V3 ?
>>>>
>>>> As we found out, this has been fixed in linux-next. For this, and the
>>>> rest in this series:
>>>>
>>>> Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>>>
>>> Understood, thank you.
>> Do you think this 4/4 can now be applied ? The rest already is.
>
> Pushed to drm-misc-next.
Thank you
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-10-22 7:19 ` Tomi Valkeinen
2025-10-22 12:45 ` Marek Vasut
@ 2025-10-29 18:44 ` Rob Herring
2025-10-29 19:14 ` Marek Vasut
1 sibling, 1 reply; 23+ messages in thread
From: Rob Herring @ 2025-10-29 18:44 UTC (permalink / raw)
To: Tomi Valkeinen, Marek Vasut
Cc: dri-devel, Conor Dooley, David Airlie, Geert Uytterhoeven,
Kieran Bingham, Krzysztof Kozlowski, Laurent Pinchart,
Neil Armstrong, Robert Foss, Simona Vetter, Thomas Zimmermann,
devicetree, linux-renesas-soc
On Wed, Oct 22, 2025 at 2:19 AM Tomi Valkeinen
<tomi.valkeinen+renesas@ideasonboard.com> wrote:
>
> Hi,
>
> On 15/10/2025 17:09, Marek Vasut wrote:
> > On 9/19/25 7:08 PM, Marek Vasut wrote:
> >
> > Hello Tomi,
> >
> >>>>> Ok. My point was just that the dsi-controller.yaml doesn't allow
> >>>>> "bridge" node (you can just rename the panel to bridge to test). I
> >>>>> thought someone (I just can't remember who was it =) will send a patch
> >>>>> for it, but I think that hasn't happened.
> >>>> Do you want me to drop the bridge part from the commit message (I
> >>>> assume
> >>>> yes) ?
> >>>>
> >>>> Any other change I should do before sending a V3 ?
> >>>
> >>> As we found out, this has been fixed in linux-next. For this, and the
> >>> rest in this series:
> >>>
> >>> Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> >>
> >> Understood, thank you.
> > Do you think this 4/4 can now be applied ? The rest already is.
>
> Pushed to drm-misc-next.
And now a warning in linux-next:
/builds/robherring/linux-dt/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb:
panel@0 (raspberrypi,dsi-7inch): compatible: ['raspberrypi,dsi-7inch']
is too short
from schema $id:
http://devicetree.org/schemas/display/panel/ilitek,ili9881c.yaml
/builds/robherring/linux-dt/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb:
panel@0 (raspberrypi,dsi-7inch): 'power-supply' is a required property
from schema $id:
http://devicetree.org/schemas/display/panel/ilitek,ili9881c.yaml
Please revert or figure out the fix.
Rob
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
2025-10-29 18:44 ` Rob Herring
@ 2025-10-29 19:14 ` Marek Vasut
0 siblings, 0 replies; 23+ messages in thread
From: Marek Vasut @ 2025-10-29 19:14 UTC (permalink / raw)
To: Rob Herring, Tomi Valkeinen
Cc: dri-devel, Conor Dooley, David Airlie, Geert Uytterhoeven,
Kieran Bingham, Krzysztof Kozlowski, Laurent Pinchart,
Neil Armstrong, Robert Foss, Simona Vetter, Thomas Zimmermann,
devicetree, linux-renesas-soc
On 10/29/25 7:44 PM, Rob Herring wrote:
Hello Rob,
> And now a warning in linux-next:
>
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb:
> panel@0 (raspberrypi,dsi-7inch): compatible: ['raspberrypi,dsi-7inch']
> is too short
> from schema $id:
> http://devicetree.org/schemas/display/panel/ilitek,ili9881c.yaml
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb:
> panel@0 (raspberrypi,dsi-7inch): 'power-supply' is a required property
> from schema $id:
> http://devicetree.org/schemas/display/panel/ilitek,ili9881c.yaml
I used dt-schema
d6be03029a35 ("Add yamllint config and fix all errors")
I used linux-next
f9ba12abc528 ("Add linux-next specific files for 20251029")
I get this in a dedicated clean worktree, no error:
$ make dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml
SCHEMA Documentation/devicetree/bindings/processed-schema.json
HOSTCC scripts/basic/fixdep
...
HOSTLD scripts/dtc/dtc
CHKDT ./Documentation/devicetree/bindings
LINT ./Documentation/devicetree/bindings
DTEX
Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dts
DTC [C]
Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.example.dtb
I am not seeing the error. Is this invocation correct ?
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 23+ messages in thread