From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
Cc: linux-clk@vger.kernel.org, git@amd.com,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
michal.simek@xilinx.com, shubhrajyoti.datta@gmail.com,
sboyd@kernel.org, mturquette@baylibre.com
Subject: Re: [PATCH v2 1/2] dt-bindings: clk: Add binding for versal clocking wizard
Date: Thu, 17 Nov 2022 14:15:11 +0100 [thread overview]
Message-ID: <f01ed99a-8487-aa4d-dfe8-df72037ce132@linaro.org> (raw)
In-Reply-To: <20221116220955.GA1042427-robh@kernel.org>
On 16/11/2022 23:09, Rob Herring wrote:
> On Tue, Nov 15, 2022 at 08:20:04PM +0530, Shubhrajyoti Datta wrote:
>> The Clocking Wizard for Versal adaptive compute acceleration platforms
>> generates multiple configurable number of clock outputs.
>> Add device tree binding for Versal clocking wizard support.
>>
>> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
>> ---
>>
>> Changes in v2:
>> rename the clocks clk_in1 to in1 and s_axi_clk to s_axi in dt
>
> Why? Now you don't match the other clocking wizard. Yes, 'clk' is kind
> of redundant, but making up different names for each version of h/w is
> worse.
>
> What happened to using the same schema file so we aren't defining the
> same property (xlnx,nr-outputs) twice?
This might have been effect of my early comment, but then we discovered
we have more of bindings for the same, thus my comment might not be
applicable.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-17 13:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 14:50 [PATCH v2 0/2] clocking-wizard: Add versal clocking wizard support Shubhrajyoti Datta
2022-11-15 14:50 ` [PATCH v2 1/2] dt-bindings: clk: Add binding for versal clocking wizard Shubhrajyoti Datta
2022-11-16 22:09 ` Rob Herring
2022-11-17 13:15 ` Krzysztof Kozlowski [this message]
2022-11-15 14:50 ` [PATCH v2 2/2] clocking-wizard: Add versal clocking wizard support Shubhrajyoti Datta
2022-11-17 16:47 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f01ed99a-8487-aa4d-dfe8-df72037ce132@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=shubhrajyoti.datta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).