Re: [PATCH 1/2] mmc: cqe: Add CQE DT support for cadence controller

[Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>]

On 07/04/2026 13:18, rohan1sj via B4 Relay wrote:
> From: rohan1sj <rohan1sj@cadence.com>
> 

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters


> Add DT config required to support CQE as present in
> cadence eMMC host controller

What is DT config?

Which devices? Say something useful here.

> 
> Signed-off-by: rohan1sj <rohan1sj@cadence.com>

Please use known identity.

> ---
>  .../devicetree/bindings/mmc/cdns,sdhci.yaml        | 32 +++++++++++++++++++++-
>  1 file changed, 31 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> index ac75d694611a..c0d8aefe20c2 100644
> --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> @@ -24,6 +24,10 @@ properties:
>      minItems: 1
>      maxItems: 2
>  
> +  reg-names:
> +    minItems: 1
> +    maxItems: 2

List would have to be here.

> +
>    interrupts:
>      maxItems: 1
>  
> @@ -139,7 +143,19 @@ allOf:
>      else:
>        properties:
>          reg:
> -          maxItems: 1
> +          oneOf:
> +            - items:
> +                - description: Host controller registers
> +            - items:
> +                - description: Host controller registers
> +                - description: CQE (Command Queue Engine) registers

So just one list with minItems

> +        reg-names:
> +          oneOf:
> +            - items:
> +                - const: sdhci
> +            - items:
> +                - const: sdhci

core

> +                - const: cqhci

cqe

Anyway, reg-names here are pointless. They should be in top-level.

You also need to disallow the reg-names for Pensando, because it has
completely different.

>  
>  unevaluatedProperties: false
>  
> @@ -156,3 +172,17 @@ examples:
>          mmc-hs400-1_8v;
>          cdns,phy-dll-delay-sdclk = <0>;
>      };
> +
> +  - |
> +    emmc_cqe: mmc@5b000000 {
> +        compatible = "socionext,uniphier-sd4hc", "cdns,sd4hc";
> +        reg = <0x5b000000 0x400>, <0x5b000400 0x060>;

No need for new example. Just correct existing one.

Best regards,
Krzysztof