* [PATCH] DT/arm,gic-v3: Update the ITS size in the examples
@ 2017-10-03 14:20 Julien Grall
2017-10-03 14:53 ` Mark Rutland
0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2017-10-03 14:20 UTC (permalink / raw)
To: mark.rutland-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
marc.zyngier-5wv7dgnIgG8, jason-NLaQJdtUoK4Be96aLqz0jA,
tglx-hfZtesqFncYOwBW4kG4KsQ
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Julien Grall
Currently, the examples are using 2MB for the ITS size. Per the
specification (section 8.18 in ARM IHI 0069D), the ITS address map is
128KB.
Update the examples to match the specification.
Signed-off-by: Julien Grall <julien.grall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
.../devicetree/bindings/interrupt-controller/arm,gic-v3.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
index 4c29cdab0ea5..5eb108e180fa 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
+++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
@@ -99,7 +99,7 @@ Examples:
compatible = "arm,gic-v3-its";
msi-controller;
#msi-cells = <1>;
- reg = <0x0 0x2c200000 0 0x200000>;
+ reg = <0x0 0x2c200000 0 0x20000>;
};
};
@@ -124,14 +124,14 @@ Examples:
compatible = "arm,gic-v3-its";
msi-controller;
#msi-cells = <1>;
- reg = <0x0 0x2c200000 0 0x200000>;
+ reg = <0x0 0x2c200000 0 0x20000>;
};
gic-its@2c400000 {
compatible = "arm,gic-v3-its";
msi-controller;
#msi-cells = <1>;
- reg = <0x0 0x2c400000 0 0x200000>;
+ reg = <0x0 0x2c400000 0 0x20000>;
};
ppi-partitions {
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] DT/arm,gic-v3: Update the ITS size in the examples
2017-10-03 14:20 [PATCH] DT/arm,gic-v3: Update the ITS size in the examples Julien Grall
@ 2017-10-03 14:53 ` Mark Rutland
2017-10-03 15:03 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Mark Rutland @ 2017-10-03 14:53 UTC (permalink / raw)
To: Julien Grall, marc.zyngier; +Cc: robh+dt, jason, tglx, linux-kernel, devicetree
On Tue, Oct 03, 2017 at 03:20:27PM +0100, Julien Grall wrote:
> Currently, the examples are using 2MB for the ITS size. Per the
> specification (section 8.18 in ARM IHI 0069D), the ITS address map is
> 128KB.
>
> Update the examples to match the specification.
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
This looks sane to me, per my reading of that section of the spec.
Marc, was there some reason we used such a large size? Or was the extra
zero unintentional?
Thanks,
Mark.
> ---
> .../devicetree/bindings/interrupt-controller/arm,gic-v3.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> index 4c29cdab0ea5..5eb108e180fa 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> @@ -99,7 +99,7 @@ Examples:
> compatible = "arm,gic-v3-its";
> msi-controller;
> #msi-cells = <1>;
> - reg = <0x0 0x2c200000 0 0x200000>;
> + reg = <0x0 0x2c200000 0 0x20000>;
> };
> };
>
> @@ -124,14 +124,14 @@ Examples:
> compatible = "arm,gic-v3-its";
> msi-controller;
> #msi-cells = <1>;
> - reg = <0x0 0x2c200000 0 0x200000>;
> + reg = <0x0 0x2c200000 0 0x20000>;
> };
>
> gic-its@2c400000 {
> compatible = "arm,gic-v3-its";
> msi-controller;
> #msi-cells = <1>;
> - reg = <0x0 0x2c400000 0 0x200000>;
> + reg = <0x0 0x2c400000 0 0x20000>;
> };
>
> ppi-partitions {
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] DT/arm,gic-v3: Update the ITS size in the examples
2017-10-03 14:53 ` Mark Rutland
@ 2017-10-03 15:03 ` Marc Zyngier
0 siblings, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2017-10-03 15:03 UTC (permalink / raw)
To: Mark Rutland, Julien Grall
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, jason-NLaQJdtUoK4Be96aLqz0jA,
tglx-hfZtesqFncYOwBW4kG4KsQ, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA
On 03/10/17 15:53, Mark Rutland wrote:
> On Tue, Oct 03, 2017 at 03:20:27PM +0100, Julien Grall wrote:
>> Currently, the examples are using 2MB for the ITS size. Per the
>> specification (section 8.18 in ARM IHI 0069D), the ITS address map is
>> 128KB.
>>
>> Update the examples to match the specification.
>>
>> Signed-off-by: Julien Grall <julien.grall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> This looks sane to me, per my reading of that section of the spec.
>
> Marc, was there some reason we used such a large size? Or was the extra
> zero unintentional?
It is just that counting zeroes is hard. I usually just type a bunch of
them and let careful people sort it out. ;-)
I'll apply that as a fix.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-03 15:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-03 14:20 [PATCH] DT/arm,gic-v3: Update the ITS size in the examples Julien Grall
2017-10-03 14:53 ` Mark Rutland
2017-10-03 15:03 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).