From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A66FAC43334 for ; Sat, 18 Jun 2022 00:38:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231921AbiFRAiZ (ORCPT ); Fri, 17 Jun 2022 20:38:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383734AbiFRAiY (ORCPT ); Fri, 17 Jun 2022 20:38:24 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C82D5E75D for ; Fri, 17 Jun 2022 17:38:23 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id i15so5148865plr.1 for ; Fri, 17 Jun 2022 17:38:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=1E2D0eIZUTntcwUwaqRwv3cDA3yOsU3BAA73sXGXA8s=; b=MLfHIHojRTDjOwB+I+zGXS1o1NsIM9WO5iTB1M1GPY0xU3GNIq9R+wHRLHbC9a95G4 zkokn+kU02Mabtm+KjtW7rHo1ThIFk4yphlnlf8NqjdDRi0hieUy8bqaPpBi+oqtuKut KYDMiTLQnK7utfmVxxUu9Ehl8qZr888LX6EGIgos7NeaFaRtk2ynkUXN7w1hhBdwRkNd T3TzfVeT0nutX6Gk6A5+KGQMXMuxnfDCab2isoT10b6mXSnXG+hli+XYUENjZ8di/ews aIVj/iJPZfemRjRpCn2kICpzjLJbcditeP+ZYeZ1L6jRZ8LsSdKbgGgd9XFw9/NKxRDW +XBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1E2D0eIZUTntcwUwaqRwv3cDA3yOsU3BAA73sXGXA8s=; b=cQPe4eVsSvkGGoKyrdEkjKZP3zlczAgg7x5eU4+2D7nP3J12620nXQnFXlLsg0Q0XK 0oeQapJXJz929WiMDGuNEsNXfWs9zGrHKdT3gIMBX7gVHpKltEFv1PTHlB6aKZ/VJV/2 oQthgsItl+XkPUDI9CdQECl2V2o5DQOxGZ5ykZxrq8dLgfyP9sO0H5t8bE8KZbaEuHu3 aJrNEtDIkQMGKd0vkFblYMdNjT7DenVvJU4sVCxCDw+Yj9sMADRRJeyqEYi57VEZuLH5 X1NjxJzulO7WE8m8HEp6Gb4AoHPff+r5GljqXevvoVJg7pUhymdPxWUkpu4UM3o8LBLU uvng== X-Gm-Message-State: AJIora/MDIJCGL29rQD3WWAttDuwi86juAYOTiTBvcYNm8Ee0mJCg1zC 91vjxBhIqt2Vct+rK3SNO1tGcg== X-Google-Smtp-Source: AGRyM1uj3Z9kxkG3CKqxNE/w7cg7parSnynzFxPvFizpC7YlhEXBA9nzGsXp6ADld7B8CujuxAUTGQ== X-Received: by 2002:a17:90b:3143:b0:1e8:64bc:f5e9 with SMTP id ip3-20020a17090b314300b001e864bcf5e9mr13484456pjb.228.1655512702811; Fri, 17 Jun 2022 17:38:22 -0700 (PDT) Received: from [172.31.235.92] ([216.9.110.6]) by smtp.gmail.com with ESMTPSA id v5-20020a63b945000000b003fadd680908sm4332528pgo.83.2022.06.17.17.38.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jun 2022 17:38:22 -0700 (PDT) Message-ID: Date: Fri, 17 Jun 2022 17:38:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH V8 1/3] dt-bindings: rtc: zynqmp: Add clock information Content-Language: en-US To: Srinivas Neeli , a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com, sgoud@xilinx.com, shubhraj@xilinx.com, srinivas.neeli@amd.com, neelisrinivas18@gmail.com Cc: devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, git@xilinx.com References: <20220613125836.523449-1-srinivas.neeli@xilinx.com> From: Krzysztof Kozlowski In-Reply-To: <20220613125836.523449-1-srinivas.neeli@xilinx.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/06/2022 05:58, Srinivas Neeli wrote: > Added clock information and deprecated calibration support. > > Signed-off-by: Srinivas Neeli > --- > Changes in V8: > -None > Changes in V7: > -None > Changes in V6: > -Removed dtc warnings. > Changes in V5: > -Removed quotes and _clk suffix from clocknames. > Changes in V4: > - Deprecated calibrtion support > Changes in V3: > - New patch > --- > .../devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > index bdb72d3ddf2a..638dd1d8bb26 100644 > --- a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > @@ -23,8 +23,15 @@ properties: > reg: > maxItems: 1 > > + clocks: > + items: > + - description: rtc_clk is the operating frequency of crystal. > + > + clock-names: > + maxItems: 1 You need to specify the name instead of maxItems. > + > interrupts: > - minItems: 2 > + maxItems: 2 > > interrupt-names: > items: > @@ -39,6 +46,7 @@ properties: > minimum: 0x1 > maximum: 0x1FFFFF > default: 0x198233 > + deprecated: true > > required: > - compatible > @@ -61,5 +69,7 @@ examples: > interrupts = <0 26 4>, <0 27 4>; > interrupt-names = "alarm", "sec"; > calibration = <0x198233>; > + clock-names = "rtc_clk"; > + clocks = <&rtc_clk>; > }; > }; Best regards, Krzysztof