From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dikshita Agarwal <quic_dikshita@quicinc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] media: iris: Add support for SM8750 (VPU v3.5)
Date: Thu, 17 Jul 2025 11:49:03 +0200 [thread overview]
Message-ID: <f06353e5-fec6-4287-9766-00b8eed89bec@kernel.org> (raw)
In-Reply-To: <1c5df071-7000-ab45-dbc6-4384d883ba24@quicinc.com>
On 17/07/2025 09:37, Dikshita Agarwal wrote:
>
>
>> mostly based on downstream sources. I think the hardware just did not
>> boot up without it.
>
>
> That shouldn’t be the case. The downstream design is different, which is
> why the driver requires the above code to move the GDSC to software control
> before enabling the clock. With HW_CTRL_TRIGGER, this step isn’t needed, so
> the above code is unnecessary.
Ack.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-07-17 9:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 13:41 [PATCH 0/3] media: iris: Add support for SM8750 (VPU v3.5) Krzysztof Kozlowski
2025-07-14 13:41 ` [PATCH 1/3] media: dt-bindings: qcom,sm8550-iris: Add SM8750 video codec Krzysztof Kozlowski
2025-07-15 3:47 ` Rob Herring
2025-07-14 13:41 ` [PATCH 2/3] media: iris: Split power on per variants Krzysztof Kozlowski
2025-07-14 13:41 ` [PATCH 3/3] media: iris: Add support for SM8750 (VPU v3.5) Krzysztof Kozlowski
2025-07-16 9:10 ` Dikshita Agarwal
2025-07-16 9:28 ` Krzysztof Kozlowski
2025-07-17 7:37 ` Dikshita Agarwal
2025-07-17 9:34 ` Krzysztof Kozlowski
2025-07-17 10:50 ` Dikshita Agarwal
2025-07-17 10:54 ` Krzysztof Kozlowski
2025-07-17 12:02 ` Vikash Garodia
2025-07-17 12:38 ` Krzysztof Kozlowski
2025-07-17 12:22 ` Dikshita Agarwal
2025-07-17 12:34 ` Krzysztof Kozlowski
2025-07-17 9:49 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f06353e5-fec6-4287-9766-00b8eed89bec@kernel.org \
--to=krzk@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).