From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C86013D8B1 for ; Sat, 19 Apr 2025 18:08:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745086104; cv=none; b=HmaA5JYsCmxLj4rpiemreBeEjfe+WR5bquckyEDVl1cvdlP8Z65dU9EFZm77r4HW9+RyTw1bgJEK0aKuH+BEm0qk89P6L55jXZEFw1b6QXkJCsRJQ4Sv2rsfcS+Pjg5Pf/ZDl05mD6q5JiqvO0ldgKiieuCKpQ6OfkOcPKT9eQY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745086104; c=relaxed/simple; bh=XFkmNHaKZxu0Tr9f+Tt5ZIay7nEoA6eFvqJrAhKD4DI=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=D5Ag25z7hryL4QWfv3XZoBBexXZV5vKKpI+MJ94JPKph2wcDCM0+XhjSz6WqLbz8Ru7ZYlnLjRTHLMFOHXs+f+RmQbGiCA4awsKV33jqKXkNSz6WeQ4//4N78U1woF8gDIvvB/N8LZvPpLWpZegJkfWH2iAlsOy+LenFNcuYtjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=QNe9hmKP; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="QNe9hmKP" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1745086093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+WBG6gJERoU5dPdlK82lG4j9FL7QWNjMaroQUSRkbeA=; b=QNe9hmKPuevMRrmgRKUphlUDwmaeL7Ua2ZsarGMIC3Sf1cIL74iG+4R/Eu2ppt+b+jejyf Wv4dmAC59Mpk2x0heNgipLKhr1+s0ok0n/GAR2c4zYRAuyVMUmkVgOsxESiPrG8n8zhYK0 UJdvwR1LVbFT8H4VN/UEha3JH+23Uz620lAjUWIb7rBJYJsw0nxhyHp8MwFhIbGt2eT6Se XERIxUKkZi6JETmW+lyB2UJ7TYINELITVoA66+YK0p3QYbjMBAhdlvijHIWHEudml5vucx JTz8mV5KAes2clOl9arSu87loYFCf8D7DFuXDY6QwRyXGwln5VFbAP4CfGl99A== Date: Sat, 19 Apr 2025 20:08:12 +0200 From: Dragan Simic To: Peter Robinson Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [RFC] arm64: dts: allwinner: a64: Add overlay for Realtek In-Reply-To: <20250419160751.678827-1-pbrobinson@gmail.com> References: <20250419160751.678827-1-pbrobinson@gmail.com> Message-ID: X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Hello Peter, On 2025-04-19 18:07, Peter Robinson wrote: > Add overlay for the Pine64 Realtek rtl8723bs WiFi > module that works on the Pine64/64+/SoPine devices. > > Signed-off-by: Peter Robinson > > I've looked at overlays for other vendors, such as available > for some of the Rockchip devices, and I believe I have this > mostly correct but would like some feedback both on if I have > everything needed for Allwinner devices, but also what's needed > to be able to use a single overlay across more than one device. > > This is dependent on the following [1] patch series. > > Peter > > [1] > https://lore.kernel.org/linux-devicetree/20250419160051.677485-3-pbrobinson@gmail.com/t/#u > > --- > arch/arm64/boot/dts/allwinner/Makefile | 6 ++++ > .../allwinner/sun50i-a64-pine64-realtek.dtso | 30 +++++++++++++++++++ > 2 files changed, 36 insertions(+) > create mode 100644 > arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile > b/arch/arm64/boot/dts/allwinner/Makefile > index 00bed412ee31..be991f8d8110 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += > sun50i-a64-olinuxino-emmc.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-plus.dtb > sun50i-a64-pine64.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-realtek.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinebook.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.0.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.1.dtb > @@ -52,3 +53,8 @@ dtb-$(CONFIG_ARCH_SUNXI) += > sun50i-h700-anbernic-rg35xx-2024.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-h.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-plus.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-sp.dtb > + > +# Overlays > +sun50i-a64-pine64-realtek-dtbs := sun50i-a64-pine64.dtb > sun50i-a64-pine64-realtek.dtbo > +sun50i-a64-pine64-lts-realtek-dtbs := sun50i-a64-pine64-lts.dtb > sun50i-a64-pine64-realtek.dtbo > +sun50i-a64-pine64-plus-realtek-dtbs := sun50i-a64-pine64-plus.dtb > sun50i-a64-pine64-realtek.dtbo Thanks for the patch, having this DT overlay makes perfectly sense to me. The only possible issues may arise from the resulting size increase of the compiled .dtb files, caused by the implicit inclusion of symbols. However, please see an earlier linux-rockchip thread [2] that shows the desired layout of the additions to the Makefile, which was determined through a few rounds of discussion. Finally, I think we should choose a slightly better name for the DT overlay, instead of "sun50i-a64-pine64-realtek.dtso", in which "-realtek" seems a bit to vague. Perhaps "-wifi-bt-addon" as the filename suffix would fit better, and it's virtually guaranteed that there will be no new version of that add-on board, so there should be no potential for name clashing. As a minor suggestion, the patch subject should also be tweaked a bit, because "Realtek" is also a bit too vague there. [2] https://lore.kernel.org/linux-rockchip/20250226140942.3825223-4-heiko@sntech.de/ > diff --git > a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso > b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso > new file mode 100644 > index 000000000000..51b57a46e23f > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso > @@ -0,0 +1,30 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +// Copyright (c) 2025 Peter Robinson > + > +/dts-v1/; > +/plugin/; > + > +#include > +#include > + > +&mmc1 { > + status = "okay"; > + > + rtl8723bs: wifi@1 { > + reg = <1>; > + interrupt-parent = <&r_pio>; > + interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */ > + interrupt-names = "host-wake"; > + }; > +}; > + > +&uart1 { > + status = "okay"; > + > + bluetooth { > + compatible = "realtek,rtl8723bs-bt"; > + device-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ > + enable-gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */ > + host-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* PL5 */ > + }; > +};