From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: devicetree@vger.kernel.org, daniel.lezcano@linaro.org,
tglx@linutronix.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: timer: add Ralink SoCs timer documentation
Date: Tue, 20 Jun 2023 11:57:37 +0200 [thread overview]
Message-ID: <f068e601-52ec-2dbf-d117-4164863d58ab@linaro.org> (raw)
In-Reply-To: <CAMhs-H9L0GybDOdmx5_RCw-=PaO3DYUOZPswiRErRRg5Fi57tQ@mail.gmail.com>
On 20/06/2023 11:51, Sergio Paracuellos wrote:
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + clocks:
>>> + maxItems: 1
>>> +
>>> + clock-names:
>>> + const: timer
>>
>> Names matching the module name are not really helpful, so drop it,
>> unless any existing user needs it.
>
> I am ok with dropping this. If you meant with an existing user
> something that is already mainlined in the kernel tree then I would
Yes.
> say there is no need for this 'clock-names'. I don't know about other
> places since these SoCs are pretty old and almost with nothing
> documented. I am doing the effort of trying to document all the stuff
> before porting some openWRT device tree files to the kernel (this
> timer driver is already included in 'arch/mips/ralink' so I am
> documenting already in-tree things). So I guess I should send v2
> removing this?
Yes, please.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-06-20 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 9:34 [PATCH] dt-bindings: timer: add Ralink SoCs timer documentation Sergio Paracuellos
2023-06-20 9:40 ` Krzysztof Kozlowski
2023-06-20 9:51 ` Sergio Paracuellos
2023-06-20 9:57 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f068e601-52ec-2dbf-d117-4164863d58ab@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox