Devicetree
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Jun Yan <jerrysteve1101@gmail.com>, Lee Jones <lee@kernel.org>,
	Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Vincent Knecht <vincent.knecht@mailoo.org>,
	Grant Feng <von81@163.com>,
	Andre Przywara <andre.przywara@arm.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Michal Simek <michal.simek@amd.com>,
	Wei Xu <xuwei5@hisilicon.com>,
	Robert Marko <robert.marko@sartura.hr>
Cc: Pavel Machek <pavel@ucw.cz>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	Jisheng Zhang <jszhang@kernel.org>,
	Enric Balletbo i Serra <eballetbo@gmail.com>,
	Romain Perier <romain.perier@gmail.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] ARM: dts: qcom: msm8974-oneplus-bacon: Fix sn3193 shutdown GPIO polarity
Date: Thu, 14 May 2026 12:58:25 +0200	[thread overview]
Message-ID: <f0738454-abd9-4a58-ab2a-df3479b78e95@oss.qualcomm.com> (raw)
In-Reply-To: <20260508152435.21389-5-jerrysteve1101@gmail.com>

On 5/8/26 5:24 PM, Jun Yan wrote:
> The sn3193 shutdown pin is active-low[1]. Correct the GPIO flags
> from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW to match the hardware.
> 
> [1] https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf
> 
> Fixes: 724ba6751532 ("ARM: dts: Move .dts files to vendor sub-directories")
> Signed-off-by: Jun Yan <jerrysteve1101@gmail.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

  reply	other threads:[~2026-05-14 10:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 15:24 [PATCH 0/5] leds: is31fl319x: Fix shutdown GPIO and update DT bindings Jun Yan
2026-05-08 15:24 ` [PATCH 1/5] dt-bindings: leds: issi,is31fl319x: Add description for the shutdown-gpios property Jun Yan
2026-05-13 23:26   ` Rob Herring (Arm)
2026-05-08 15:24 ` [PATCH 2/5] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse Jun Yan
2026-05-11  9:10   ` Linus Walleij
2026-05-13 14:44     ` Jun Yan
2026-05-13 15:54       ` Dmitry Baryshkov
2026-05-08 15:24 ` [PATCH 3/5] arm64: dts: qcom: msm8916-alcatel-idol347: Fix sn3190 shutdown GPIO polarity Jun Yan
2026-05-14 10:58   ` Konrad Dybcio
2026-05-08 15:24 ` [PATCH 4/5] ARM: dts: qcom: msm8974-oneplus-bacon: Fix sn3193 " Jun Yan
2026-05-14 10:58   ` Konrad Dybcio [this message]
2026-05-08 15:24 ` [PATCH 5/5] arm64: dts: marvell: armada-7040-mochabin: Fix is31fl3199 " Jun Yan
2026-05-13 15:56 ` [PATCH 0/5] leds: is31fl319x: Fix shutdown GPIO and update DT bindings Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0738454-abd9-4a58-ab2a-df3479b78e95@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=alexandre.torgue@st.com \
    --cc=andersson@kernel.org \
    --cc=andre.przywara@arm.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eballetbo@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregory.clement@bootlin.com \
    --cc=heiko@sntech.de \
    --cc=jerrysteve1101@gmail.com \
    --cc=jszhang@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=pavel@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robert.marko@sartura.hr \
    --cc=robh@kernel.org \
    --cc=romain.perier@gmail.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=vincent.knecht@mailoo.org \
    --cc=von81@163.com \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox