From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Xingyu Wu <xingyu.wu@starfivetech.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Maxim Kochetkov <fido_max@inbox.ru>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor.dooley@microchip.com>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: Jose Abreu <joabreu@synopsys.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Walker Chen <walker.chen@starfivetech.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v1 2/5] ASoC: dt-bindings: snps,designware-i2s: Add StarFive JH7110 SoC support
Date: Mon, 7 Aug 2023 11:17:56 +0200 [thread overview]
Message-ID: <f0744dfd-00fe-2f58-065e-6828b6bd3450@linaro.org> (raw)
In-Reply-To: <12a9bfda-9c9f-6baf-3e5f-ce7cc7d79aee@starfivetech.com>
On 07/08/2023 11:03, Xingyu Wu wrote:
>>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: snps,designware-i2s
>>> + then:
>>> + properties:
>>> + clocks:
>>> + maxItems: 1
>>> + clock-names:
>>> + maxItems: 1
>>> + resets:
>>> + maxItems: 1
>>> + else:
>>> + properties:
>>> + resets:
>>> + minItems: 2
>
> The resets of TX0/TX1/RX on JH7110 SoC are mentioned in 'else' here.
Ah, its fine. Clocks seem to be also constrained.
>
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: starfive,jh7110-i2stx0
>>> + then:
>>> + properties:
>>> + clocks:
>>> + minItems: 5
>>
>> Also maxItems
>
> Will add.
>
>>
>>> + clock-names:
>>> + minItems: 5
>>
>> Also maxItems
>
> Will add.
>
>>
>> What about resets? 1 or 2 items?
>
> Mentioned it in the 'else'.
> Or do you mean I should drop the 'else' and add the resets in here?
> And is the same for TX1 and RX?
It won't be easy to read... probably the binding should be split.
Anyway, it's fine as is, except the maxItems above.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-07 9:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 8:42 [PATCH v1 0/5] Add I2S support for the StarFive JH7110 SoC Xingyu Wu
2023-08-02 8:42 ` [PATCH v1 1/5] ASoC: dwc: Use ops to get platform data Xingyu Wu
2023-08-02 8:42 ` [PATCH v1 2/5] ASoC: dt-bindings: snps,designware-i2s: Add StarFive JH7110 SoC support Xingyu Wu
2023-08-05 21:02 ` Krzysztof Kozlowski
2023-08-07 9:03 ` Xingyu Wu
2023-08-07 9:17 ` Krzysztof Kozlowski [this message]
2023-08-07 9:33 ` Xingyu Wu
2023-08-02 8:42 ` [PATCH v1 3/5] ASoC: dwc: i2s: " Xingyu Wu
2023-08-03 5:16 ` Maxim Kochetkov
2023-08-04 9:20 ` Xingyu Wu
2023-08-02 8:43 ` [PATCH v1 4/5] riscv: dts: starfive: pinfunc: Fix the pins name of I2STX1 Xingyu Wu
2023-08-02 8:43 ` [PATCH v1 5/5] riscv: dts: starfive: Add the nodes and pins of I2Srx/I2Stx0/I2Stx1 Xingyu Wu
2023-08-05 21:04 ` Krzysztof Kozlowski
2023-08-07 9:04 ` Xingyu Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0744dfd-00fe-2f58-065e-6828b6bd3450@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=fido_max@inbox.ru \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=walker.chen@starfivetech.com \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).