From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
imx@lists.linux.dev, joy.zou@nxp.com,
krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
peng.fan@nxp.com, robh+dt@kernel.org, shenwei.wang@nxp.com,
vkoul@kernel.org
Subject: Re: [PATCH 4/4] dmaengine: fsl-edma: integrate TCD64 support for i.MX95
Date: Fri, 10 Nov 2023 15:50:18 +0100 [thread overview]
Message-ID: <f095ba95-ce76-4821-87b7-083f4162fc63@linaro.org> (raw)
In-Reply-To: <20231109212059.1894646-5-Frank.Li@nxp.com>
On 09/11/2023 22:20, Frank Li wrote:
> In i.MX95's edma version 5, the TCD structure is extended to support 64-bit
> addresses for fields like saddr and daddr. To prevent code duplication,
> employ help macros to handle the fields, as the field names remain the same
> between TCD and TCD64.
>
> Change local variables related to TCD addresses from 'u32' to 'dma_addr_t'
> to accept 64-bit DMA addresses.
>
> Change 'vtcd' type to 'void *' to avoid direct use. Use helper macros to
> access the TCD fields correctly.
>
> Call 'dma_set_mask_and_coherent(64)' when TCD64 is supported.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
Three kbuild reports with build failures.
I have impression this was never build-tested and reviewed internally
before posting. We had such talk ~month ago and I insisted on some
internal review prior submitting to mailing list. I did not insist on
internal building of patches, because it felt obvious, so please kindly
thoroughly build, review and test your patches internally, before using
the community for this. I am pretty sure NXP can build the code they send.
Thank you in advance.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-10 14:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 21:20 [PATCH 0/4] dmaengine: fsl-edma: integrate TCD64 support for 64bit physical address Frank Li
2023-11-09 21:20 ` [PATCH 1/4] dmaengine: fsl-edma: involve help macro fsl_edma_set(get)_tcd() Frank Li
2023-11-09 21:20 ` [PATCH 2/4] dmaengine: fsl-edma: add address for channel mux register in fsl_edma_chan Frank Li
2023-11-09 21:20 ` [PATCH 3/4] dt-bindings: fsl-dma: fsl-edma: add fsl,imx95-edma5 compatible string Frank Li
2023-11-10 7:56 ` Krzysztof Kozlowski
2023-11-09 21:20 ` [PATCH 4/4] dmaengine: fsl-edma: integrate TCD64 support for i.MX95 Frank Li
2023-11-10 6:09 ` kernel test robot
2023-11-10 9:16 ` kernel test robot
2023-11-10 14:28 ` kernel test robot
2023-11-10 14:50 ` Krzysztof Kozlowski [this message]
2023-11-10 14:59 ` Frank Li
2023-11-10 15:10 ` Krzysztof Kozlowski
2023-11-10 15:36 ` Frank Li
2023-11-10 15:52 ` Krzysztof Kozlowski
2023-11-10 16:08 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f095ba95-ce76-4821-87b7-083f4162fc63@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Frank.Li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=joy.zou@nxp.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shenwei.wang@nxp.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).