From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B422F302742; Fri, 13 Mar 2026 16:01:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773417684; cv=none; b=Bl/VEmday9B0+JR7UbTGo2PqijWAfB9mreSBqeWEx9fhCdkTvnWbV4tgbHG4tcAM0Xo41uYiH2yGsnzSb7QEZn92VeIjM1V3mn45OlicktsquGyPM+rj2ab7q1PbxC6nGm6oPEmkbl+NMzmYIioPuFuAOl2tCTQzZidllEuGVXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773417684; c=relaxed/simple; bh=IFmucvRLG/r//XAdIEFPyGnh5DHILaswUWm0SU0bnO8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QuyyhoXcxhm8PJ6pp+IjtjYl/7VZcLdLKNqSc+HL2EbWhk+OK2HDYV4ngvC4fieLTEqSBQxpGjv0yNDL5hYHh9XwzeQ1HGQOyWQVXxmhfGSvwulIZkGNr3/DGAHwqqzdpVSduSJmjLCYfD4R84g4vY3JdHd/CqzDSOhYe0DQBic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=skmheX5M; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="skmheX5M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1899FC19421; Fri, 13 Mar 2026 16:01:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773417684; bh=IFmucvRLG/r//XAdIEFPyGnh5DHILaswUWm0SU0bnO8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=skmheX5M+r6Y+CO1TuwFQdomWRivqhxuBfGGhKmv6UEFl83i50XMONoUgM/Ykuv8D EfKr5INalVuFomxx/x+UmF9v12XiS3S8MyY0fYGflsl9OTNdz1laOXmter669WUnxL i9RL2S7tH/5PsvdCOmondr8YRtjwWqn6Ex5bofZ6zPawXO6mXwISA8iRF2IZpOuK5h FN156XvsTH6Q6GDlBQKv/SGWji/1gcLEH1KLDKsQcrRy3rIMydz0158ubQO0CbPV9A QC7Vz/MinpDgYR2XhE68CcuCAZDHPdKaO20357vg8I5dJOYrZqAzIbLcpzuHBdYDCy pouHIGloUvDWg== Message-ID: Date: Fri, 13 Mar 2026 17:01:19 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [EXT] Re: [PATCH v6 3/7] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support To: Lakshay Piplani Cc: "linux-kernel@vger.kernel.org" , "linux-i3c@lists.infradead.org" , "alexandre.belloni@bootlin.com" , "krzk+dt@kernel.org" , "robh@kernel.org" , "conor+dt@kernel.org" , "devicetree@vger.kernel.org" , "broonie@kernel.org" , "lee@kernel.org" , Frank Li , "lgirdwood@gmail.com" , Vikash Bansal , Priyanka Jain , Aman Kumar Pandey References: <20260310065727.3759342-1-lakshay.piplani@nxp.com> <20260310065727.3759342-3-lakshay.piplani@nxp.com> <20260311-outrageous-unnatural-jerboa-53f5a8@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13/03/2026 12:09, Lakshay Piplani wrote: >>> +examples: >>> + - | >>> + i3c { >>> + #address-cells = <3>; >>> + #size-cells = <0>; >>> + >>> + hub@70,236153000c2 { >>> + reg = <0x70 0x236 0x3000c2>; >> >> Where is the compatible? >> >> So this wasn't checked/tested. Try yourself, remove required properties and >> see if there is an error. No error, right? >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > > Thanks for pointing this out. > > In this binding, compatible is not a required property by design. The P3H2x4x > hub can appear on either an I3C bus or an I2C bus. For I3C instantiations, the > device is self-discoverable via Dynamic Address Assignment (DAA) and its PID/DCR, > so, the driver does not rely on a compatible string for matching. > > The compatible = "nxp,p3h2840" entry in the schema is meant only for the legacy I2C mode. > where a standard OF match is still needed. Since we did not include an I2C example in the > examples section, the compatible property does not appear there and is therefore not > required for I3C only cases. So you just added something which was never verified/build tested. > > dt_binding_check passes because the schema intentionally does not declare compatible as > required, and the examples conform to that. Requiring compatible is kind of irrelevant, because schema would just no match without it. IOW, has no practical effect on the schema. Lack of "require" of compatible also therefore has no practical impact on the schema. Best regards, Krzysztof