* Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes
2023-02-27 17:45 [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes Marek Vasut
@ 2023-02-27 17:49 ` Fabio Estevam
2023-02-27 18:05 ` Adam Ford
2023-02-27 19:01 ` Marco Felsch
2 siblings, 0 replies; 11+ messages in thread
From: Fabio Estevam @ 2023-02-27 17:49 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Abel Vesa, Alexander Stein, Jacky Bai,
Krzysztof Kozlowski, Laurent Pinchart, Luca Ceresoli, Lucas Stach,
Marco Felsch, Michael Turquette, NXP Linux Team, Peng Fan,
Pengutronix Kernel Team, Richard Cochran, Rob Herring,
Sascha Hauer, Shawn Guo, Stephen Boyd, devicetree, linux-clk
On Mon, Feb 27, 2023 at 2:45 PM Marek Vasut <marex@denx.de> wrote:
>
> Add #sound-dai-cells properties to SAI nodes.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes
2023-02-27 17:45 [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes Marek Vasut
2023-02-27 17:49 ` Fabio Estevam
@ 2023-02-27 18:05 ` Adam Ford
2023-02-27 18:59 ` Marek Vasut
2023-02-27 19:01 ` Marco Felsch
2 siblings, 1 reply; 11+ messages in thread
From: Adam Ford @ 2023-02-27 18:05 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Abel Vesa, Alexander Stein, Fabio Estevam,
Jacky Bai, Krzysztof Kozlowski, Laurent Pinchart, Luca Ceresoli,
Lucas Stach, Marco Felsch, Michael Turquette, NXP Linux Team,
Peng Fan, Pengutronix Kernel Team, Richard Cochran, Rob Herring,
Sascha Hauer, Shawn Guo, Stephen Boyd, devicetree, linux-clk
On Mon, Feb 27, 2023 at 11:58 AM Marek Vasut <marex@denx.de> wrote:
>
> Add #sound-dai-cells properties to SAI nodes.
>
Should this have a fixes tag?
Fixes: 9e9860069725 ("arm64: dts: imx8mn: Add SAI nodes")
I don't know when these became required, and/or if this should be
back-ported or not.
Reviewed-by: Adam Ford <aford173@gmail.com>
adam
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Abel Vesa <abelvesa@kernel.org>
> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Jacky Bai <ping.bai@nxp.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Marco Felsch <m.felsch@pengutronix.de>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-clk@vger.kernel.org
> ---
> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index ed9ac6c5047c0..bbec860ef8548 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -294,6 +294,7 @@ spba2: spba-bus@30000000 {
> ranges;
>
> sai2: sai@30020000 {
> + #sound-dai-cells = <0>;
> compatible = "fsl,imx8mn-sai", "fsl,imx8mq-sai";
> reg = <0x30020000 0x10000>;
> interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
> @@ -308,6 +309,7 @@ sai2: sai@30020000 {
> };
>
> sai3: sai@30030000 {
> + #sound-dai-cells = <0>;
> compatible = "fsl,imx8mn-sai", "fsl,imx8mq-sai";
> reg = <0x30030000 0x10000>;
> interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
> @@ -322,6 +324,7 @@ sai3: sai@30030000 {
> };
>
> sai5: sai@30050000 {
> + #sound-dai-cells = <0>;
> compatible = "fsl,imx8mn-sai", "fsl,imx8mq-sai";
> reg = <0x30050000 0x10000>;
> interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> @@ -338,6 +341,7 @@ sai5: sai@30050000 {
> };
>
> sai6: sai@30060000 {
> + #sound-dai-cells = <0>;
> compatible = "fsl,imx8mn-sai", "fsl,imx8mq-sai";
> reg = <0x30060000 0x10000>;
> interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> @@ -395,6 +399,7 @@ spdif1: spdif@30090000 {
> };
>
> sai7: sai@300b0000 {
> + #sound-dai-cells = <0>;
> compatible = "fsl,imx8mn-sai", "fsl,imx8mq-sai";
> reg = <0x300b0000 0x10000>;
> interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes
2023-02-27 18:05 ` Adam Ford
@ 2023-02-27 18:59 ` Marek Vasut
0 siblings, 0 replies; 11+ messages in thread
From: Marek Vasut @ 2023-02-27 18:59 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, Abel Vesa, Alexander Stein, Fabio Estevam,
Jacky Bai, Krzysztof Kozlowski, Laurent Pinchart, Luca Ceresoli,
Lucas Stach, Marco Felsch, Michael Turquette, NXP Linux Team,
Peng Fan, Pengutronix Kernel Team, Richard Cochran, Rob Herring,
Sascha Hauer, Shawn Guo, Stephen Boyd, devicetree, linux-clk
On 2/27/23 19:05, Adam Ford wrote:
> On Mon, Feb 27, 2023 at 11:58 AM Marek Vasut <marex@denx.de> wrote:
>>
>> Add #sound-dai-cells properties to SAI nodes.
>>
>
> Should this have a fixes tag?
>
> Fixes: 9e9860069725 ("arm64: dts: imx8mn: Add SAI nodes")
>
> I don't know when these became required, and/or if this should be
> back-ported or not.
I am unsure myself, but this commit from 2020 does not have it:
ebfa8951e6cd2 ("arm64: dts: imx8mm: specify #sound-dai-cells for SAI nodes")
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes
2023-02-27 17:45 [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes Marek Vasut
2023-02-27 17:49 ` Fabio Estevam
2023-02-27 18:05 ` Adam Ford
@ 2023-02-27 19:01 ` Marco Felsch
2023-02-27 19:07 ` Marek Vasut
2 siblings, 1 reply; 11+ messages in thread
From: Marco Felsch @ 2023-02-27 19:01 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Abel Vesa, Alexander Stein, Fabio Estevam,
Jacky Bai, Krzysztof Kozlowski, Laurent Pinchart, Luca Ceresoli,
Lucas Stach, Michael Turquette, NXP Linux Team, Peng Fan,
Pengutronix Kernel Team, Richard Cochran, Rob Herring,
Sascha Hauer, Shawn Guo, Stephen Boyd, devicetree, linux-clk
Hi Marek,
On 23-02-27, Marek Vasut wrote:
> Add #sound-dai-cells properties to SAI nodes.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Abel Vesa <abelvesa@kernel.org>
> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Jacky Bai <ping.bai@nxp.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Marco Felsch <m.felsch@pengutronix.de>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-clk@vger.kernel.org
> ---
> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index ed9ac6c5047c0..bbec860ef8548 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -294,6 +294,7 @@ spba2: spba-bus@30000000 {
> ranges;
>
> sai2: sai@30020000 {
> + #sound-dai-cells = <0>;
Please don't add it in front of the compatible and the reg property.
Regards,
Marco
> compatible = "fsl,imx8mn-sai", "fsl,imx8mq-sai";
> reg = <0x30020000 0x10000>;
> interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
> @@ -308,6 +309,7 @@ sai2: sai@30020000 {
> };
>
> sai3: sai@30030000 {
> + #sound-dai-cells = <0>;
> compatible = "fsl,imx8mn-sai", "fsl,imx8mq-sai";
> reg = <0x30030000 0x10000>;
> interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
> @@ -322,6 +324,7 @@ sai3: sai@30030000 {
> };
>
> sai5: sai@30050000 {
> + #sound-dai-cells = <0>;
> compatible = "fsl,imx8mn-sai", "fsl,imx8mq-sai";
> reg = <0x30050000 0x10000>;
> interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> @@ -338,6 +341,7 @@ sai5: sai@30050000 {
> };
>
> sai6: sai@30060000 {
> + #sound-dai-cells = <0>;
> compatible = "fsl,imx8mn-sai", "fsl,imx8mq-sai";
> reg = <0x30060000 0x10000>;
> interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> @@ -395,6 +399,7 @@ spdif1: spdif@30090000 {
> };
>
> sai7: sai@300b0000 {
> + #sound-dai-cells = <0>;
> compatible = "fsl,imx8mn-sai", "fsl,imx8mq-sai";
> reg = <0x300b0000 0x10000>;
> interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
> --
> 2.39.2
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes
2023-02-27 19:01 ` Marco Felsch
@ 2023-02-27 19:07 ` Marek Vasut
2023-02-27 20:00 ` Marco Felsch
0 siblings, 1 reply; 11+ messages in thread
From: Marek Vasut @ 2023-02-27 19:07 UTC (permalink / raw)
To: Marco Felsch
Cc: linux-arm-kernel, Abel Vesa, Alexander Stein, Fabio Estevam,
Jacky Bai, Krzysztof Kozlowski, Laurent Pinchart, Luca Ceresoli,
Lucas Stach, Michael Turquette, NXP Linux Team, Peng Fan,
Pengutronix Kernel Team, Richard Cochran, Rob Herring,
Sascha Hauer, Shawn Guo, Stephen Boyd, devicetree, linux-clk
On 2/27/23 20:01, Marco Felsch wrote:
> Hi Marek,
>
> On 23-02-27, Marek Vasut wrote:
>> Add #sound-dai-cells properties to SAI nodes.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> Cc: Abel Vesa <abelvesa@kernel.org>
>> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Jacky Bai <ping.bai@nxp.com>
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>
>> Cc: Lucas Stach <l.stach@pengutronix.de>
>> Cc: Marco Felsch <m.felsch@pengutronix.de>
>> Cc: Michael Turquette <mturquette@baylibre.com>
>> Cc: NXP Linux Team <linux-imx@nxp.com>
>> Cc: Peng Fan <peng.fan@nxp.com>
>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>> Cc: Richard Cochran <richardcochran@gmail.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: Stephen Boyd <sboyd@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-clk@vger.kernel.org
>> ---
>> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
>> index ed9ac6c5047c0..bbec860ef8548 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
>> @@ -294,6 +294,7 @@ spba2: spba-bus@30000000 {
>> ranges;
>>
>> sai2: sai@30020000 {
>> + #sound-dai-cells = <0>;
>
> Please don't add it in front of the compatible and the reg property.
The #address-cells and #size-cells are also always on top, why should
the #sound-dai-cells be any different ? Where should they be ?
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes
2023-02-27 19:07 ` Marek Vasut
@ 2023-02-27 20:00 ` Marco Felsch
2023-02-27 20:11 ` Marek Vasut
2023-02-28 8:10 ` Krzysztof Kozlowski
0 siblings, 2 replies; 11+ messages in thread
From: Marco Felsch @ 2023-02-27 20:00 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Abel Vesa, Alexander Stein, Fabio Estevam,
Jacky Bai, Krzysztof Kozlowski, Laurent Pinchart, Luca Ceresoli,
Lucas Stach, Michael Turquette, NXP Linux Team, Peng Fan,
Pengutronix Kernel Team, Richard Cochran, Rob Herring,
Sascha Hauer, Shawn Guo, Stephen Boyd, devicetree, linux-clk
On 23-02-27, Marek Vasut wrote:
> On 2/27/23 20:01, Marco Felsch wrote:
> > Hi Marek,
> >
> > On 23-02-27, Marek Vasut wrote:
> > > Add #sound-dai-cells properties to SAI nodes.
> > >
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > ---
> > > Cc: Abel Vesa <abelvesa@kernel.org>
> > > Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > Cc: Fabio Estevam <festevam@gmail.com>
> > > Cc: Jacky Bai <ping.bai@nxp.com>
> > > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>
> > > Cc: Lucas Stach <l.stach@pengutronix.de>
> > > Cc: Marco Felsch <m.felsch@pengutronix.de>
> > > Cc: Michael Turquette <mturquette@baylibre.com>
> > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > Cc: Peng Fan <peng.fan@nxp.com>
> > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > > Cc: Richard Cochran <richardcochran@gmail.com>
> > > Cc: Rob Herring <robh+dt@kernel.org>
> > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Stephen Boyd <sboyd@kernel.org>
> > > Cc: devicetree@vger.kernel.org
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > Cc: linux-clk@vger.kernel.org
> > > ---
> > > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > > index ed9ac6c5047c0..bbec860ef8548 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > > @@ -294,6 +294,7 @@ spba2: spba-bus@30000000 {
> > > ranges;
> > > sai2: sai@30020000 {
> > > + #sound-dai-cells = <0>;
> >
> > Please don't add it in front of the compatible and the reg property.
>
> The #address-cells and #size-cells are also always on top, why should the
> #sound-dai-cells be any different ? Where should they be ?
As of now my understanding of specifying a devicetree node was:
node-name@reg-nr {
compatible = "";
reg = <>;
// all pending properties below
...
};
@Rob, @Krzysztof:
Is this a (unwritten) rule/policy?
Marekt please ignore my comment if this is not the case.
Regards,
Marco
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes
2023-02-27 20:00 ` Marco Felsch
@ 2023-02-27 20:11 ` Marek Vasut
2023-02-28 8:10 ` Krzysztof Kozlowski
1 sibling, 0 replies; 11+ messages in thread
From: Marek Vasut @ 2023-02-27 20:11 UTC (permalink / raw)
To: Marco Felsch
Cc: linux-arm-kernel, Abel Vesa, Alexander Stein, Fabio Estevam,
Jacky Bai, Krzysztof Kozlowski, Laurent Pinchart, Luca Ceresoli,
Lucas Stach, Michael Turquette, NXP Linux Team, Peng Fan,
Pengutronix Kernel Team, Richard Cochran, Rob Herring,
Sascha Hauer, Shawn Guo, Stephen Boyd, devicetree, linux-clk
On 2/27/23 21:00, Marco Felsch wrote:
> On 23-02-27, Marek Vasut wrote:
>> On 2/27/23 20:01, Marco Felsch wrote:
>>> Hi Marek,
>>>
>>> On 23-02-27, Marek Vasut wrote:
>>>> Add #sound-dai-cells properties to SAI nodes.
>>>>
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>> ---
>>>> Cc: Abel Vesa <abelvesa@kernel.org>
>>>> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
>>>> Cc: Fabio Estevam <festevam@gmail.com>
>>>> Cc: Jacky Bai <ping.bai@nxp.com>
>>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>>>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>>> Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>
>>>> Cc: Lucas Stach <l.stach@pengutronix.de>
>>>> Cc: Marco Felsch <m.felsch@pengutronix.de>
>>>> Cc: Michael Turquette <mturquette@baylibre.com>
>>>> Cc: NXP Linux Team <linux-imx@nxp.com>
>>>> Cc: Peng Fan <peng.fan@nxp.com>
>>>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>>>> Cc: Richard Cochran <richardcochran@gmail.com>
>>>> Cc: Rob Herring <robh+dt@kernel.org>
>>>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>>>> Cc: Shawn Guo <shawnguo@kernel.org>
>>>> Cc: Stephen Boyd <sboyd@kernel.org>
>>>> Cc: devicetree@vger.kernel.org
>>>> Cc: linux-arm-kernel@lists.infradead.org
>>>> Cc: linux-clk@vger.kernel.org
>>>> ---
>>>> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
>>>> index ed9ac6c5047c0..bbec860ef8548 100644
>>>> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
>>>> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
>>>> @@ -294,6 +294,7 @@ spba2: spba-bus@30000000 {
>>>> ranges;
>>>> sai2: sai@30020000 {
>>>> + #sound-dai-cells = <0>;
>>>
>>> Please don't add it in front of the compatible and the reg property.
>>
>> The #address-cells and #size-cells are also always on top, why should the
>> #sound-dai-cells be any different ? Where should they be ?
>
> As of now my understanding of specifying a devicetree node was:
>
> node-name@reg-nr {
> compatible = "";
> reg = <>;
> // all pending properties below
> ...
> };
>
> @Rob, @Krzysztof:
> Is this a (unwritten) rule/policy?
>
> Marekt please ignore my comment if this is not the case.
Getting input from Rob/Krysztof is a good idea, thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes
2023-02-27 20:00 ` Marco Felsch
2023-02-27 20:11 ` Marek Vasut
@ 2023-02-28 8:10 ` Krzysztof Kozlowski
2023-02-28 20:13 ` Marek Vasut
1 sibling, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-28 8:10 UTC (permalink / raw)
To: Marco Felsch, Marek Vasut
Cc: linux-arm-kernel, Abel Vesa, Alexander Stein, Fabio Estevam,
Jacky Bai, Krzysztof Kozlowski, Laurent Pinchart, Luca Ceresoli,
Lucas Stach, Michael Turquette, NXP Linux Team, Peng Fan,
Pengutronix Kernel Team, Richard Cochran, Rob Herring,
Sascha Hauer, Shawn Guo, Stephen Boyd, devicetree, linux-clk
On 27/02/2023 21:00, Marco Felsch wrote:
>>>> + #sound-dai-cells = <0>;
>>>
>>> Please don't add it in front of the compatible and the reg property.
>>
>> The #address-cells and #size-cells are also always on top, why should the
>> #sound-dai-cells be any different ? Where should they be ?
>
> As of now my understanding of specifying a devicetree node was:
>
> node-name@reg-nr {
> compatible = "";
> reg = <>;
> // all pending properties below
> ...
> };
>
> @Rob, @Krzysztof:
> Is this a (unwritten) rule/policy?
>
Each platform has its own coding style around this but I am not aware of
a coding style which puts address and size cells at the top. To me it is
really odd placement. First property is always "compatible", as the most
important. Then for most platforms second is "reg", as the one easiest
to compare with unit address. Some platforms put status as last property.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes
2023-02-28 8:10 ` Krzysztof Kozlowski
@ 2023-02-28 20:13 ` Marek Vasut
2023-03-01 9:08 ` Marco Felsch
0 siblings, 1 reply; 11+ messages in thread
From: Marek Vasut @ 2023-02-28 20:13 UTC (permalink / raw)
To: Krzysztof Kozlowski, Marco Felsch
Cc: linux-arm-kernel, Abel Vesa, Alexander Stein, Fabio Estevam,
Jacky Bai, Krzysztof Kozlowski, Laurent Pinchart, Luca Ceresoli,
Lucas Stach, Michael Turquette, NXP Linux Team, Peng Fan,
Pengutronix Kernel Team, Richard Cochran, Rob Herring,
Sascha Hauer, Shawn Guo, Stephen Boyd, devicetree, linux-clk
On 2/28/23 09:10, Krzysztof Kozlowski wrote:
> On 27/02/2023 21:00, Marco Felsch wrote:
>>>>> + #sound-dai-cells = <0>;
>>>>
>>>> Please don't add it in front of the compatible and the reg property.
>>>
>>> The #address-cells and #size-cells are also always on top, why should the
>>> #sound-dai-cells be any different ? Where should they be ?
>>
>> As of now my understanding of specifying a devicetree node was:
>>
>> node-name@reg-nr {
>> compatible = "";
>> reg = <>;
>> // all pending properties below
>> ...
>> };
>>
>> @Rob, @Krzysztof:
>> Is this a (unwritten) rule/policy?
>>
>
> Each platform has its own coding style around this but I am not aware of
> a coding style which puts address and size cells at the top.
DTspec 0.3 and 0.4-rc agrees with the below.
Linux seems to be full of counter-examples though:
$ git grep -A 1 ' {$' arch/*/boot/dts/ | grep -B 1 cells
> To me it is
> really odd placement. First property is always "compatible", as the most
> important. Then for most platforms second is "reg", as the one easiest
> to compare with unit address. Some platforms put status as last property.
All right, so:
- compatible
- reg
- #whatever-cells
- properties
- status
Does that order look right ?
[...]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes
2023-02-28 20:13 ` Marek Vasut
@ 2023-03-01 9:08 ` Marco Felsch
0 siblings, 0 replies; 11+ messages in thread
From: Marco Felsch @ 2023-03-01 9:08 UTC (permalink / raw)
To: Marek Vasut
Cc: Krzysztof Kozlowski, linux-arm-kernel, Abel Vesa, Alexander Stein,
Fabio Estevam, Jacky Bai, Krzysztof Kozlowski, Laurent Pinchart,
Luca Ceresoli, Lucas Stach, Michael Turquette, NXP Linux Team,
Peng Fan, Pengutronix Kernel Team, Richard Cochran, Rob Herring,
Sascha Hauer, Shawn Guo, Stephen Boyd, devicetree, linux-clk
On 23-02-28, Marek Vasut wrote:
> On 2/28/23 09:10, Krzysztof Kozlowski wrote:
> > On 27/02/2023 21:00, Marco Felsch wrote:
> > > > > > + #sound-dai-cells = <0>;
> > > > >
> > > > > Please don't add it in front of the compatible and the reg property.
> > > >
> > > > The #address-cells and #size-cells are also always on top, why should the
> > > > #sound-dai-cells be any different ? Where should they be ?
> > >
> > > As of now my understanding of specifying a devicetree node was:
> > >
> > > node-name@reg-nr {
> > > compatible = "";
> > > reg = <>;
> > > // all pending properties below
> > > ...
> > > };
> > >
> > > @Rob, @Krzysztof:
> > > Is this a (unwritten) rule/policy?
> > >
> >
> > Each platform has its own coding style around this but I am not aware of
> > a coding style which puts address and size cells at the top.
>
> DTspec 0.3 and 0.4-rc agrees with the below.
>
> Linux seems to be full of counter-examples though:
> $ git grep -A 1 ' {$' arch/*/boot/dts/ | grep -B 1 cells
>
> > To me it is
> > really odd placement. First property is always "compatible", as the most
> > important. Then for most platforms second is "reg", as the one easiest
> > to compare with unit address. Some platforms put status as last property.
>
> All right, so:
>
> - compatible
> - reg
> - #whatever-cells
> - properties
> - status
>
> Does that order look right ?
I would swap the #whatever-cells with the properties, but that's just my
opinion. The rest looks good to me. Thanks for the research.
Regards,
Marco
>
> [...]
>
^ permalink raw reply [flat|nested] 11+ messages in thread