Re: [PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 28/03/2025 15:28, Mukesh Kumar Savaliya wrote:
> Thanks Krzysztof for correcting !
> 
> On 3/26/2025 7:58 PM, Krzysztof Kozlowski wrote:
>> On 26/03/2025 15:16, Mukesh Kumar Savaliya wrote:
>>> +
>>> +static int i3c_geni_resources_init(struct geni_i3c_dev *gi3c, struct platform_device *pdev)
>>> +{
>>> +	int ret;
>>> +
>>> +	gi3c->se.base = devm_platform_ioremap_resource(pdev, 0);
>>> +	if (IS_ERR(gi3c->se.base))
>>> +		return PTR_ERR(gi3c->se.base);
>>> +
>>> +	gi3c->se.clk = devm_clk_get(&pdev->dev, "se-clk");
>>
>> Never tested.
>>
> sorry, i ran and i got below error now:

Please do the tests *before* you post changes You do not need community
reviewer to tell you to do static/compile time checks on your code.

> i3c@884000: Unevaluated properties are not allowed ('clock-names', 
> 'interrupts' were unexpected).
> 
> so i have made below change and ran dt_binding_check + dtbs_check, i 
> could fix the issue. Let me have this review internally specific to 
> dt-binding and will post next patch after internal review. So i can 
> avoid such misses.
> 
> yaml :
> +  clock-names:
> +    const: se
> +
> -  - interrupts-extended
> +  - interrupts
> 
> example:
> clock-names = "se";

No, drop clock names entirely, not really useful for one entry using
block's name. Just get the first clock, like most of the drivers.
> 


Best regards,
Krzysztof