From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B75621850AF for ; Sun, 23 Jun 2024 22:13:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719180820; cv=none; b=sk9lkq1JMsDZ7PnKiRq+x1kR8/4PWtWMA65Sr9Yvoha9SZYckB6K9idSq13CGKdlgRAyBVTf5WxT8Gx7oAowF+J6ET/8T0OHrEzYP7NYKJ6FHfLPlN1IRX21gwvhycq3JcC8YhW42a+icmuxAqKtz/IfmsdtGDMOFK5bnH70Pd8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719180820; c=relaxed/simple; bh=t1aJlbPrDE27weRoRSAZ+KfV03SpoBgR2r3DRxatZWw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lmcKkY+cVdr7ESTfqDelpscK1qCuTJMAtDwtf396JSCAGP3F4k5X4SRWXGzPVGJ/Gp3LO5v0DcFgzPn0eUb0o8+mH1BT2W+ufaeDKLGXV+aAc7B5NTcmtjHQB6Fv5sJo3dg/mO1U3+sLcweKmMr82gsJ7qgXeZo9keu/yxFANbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AxXDfu40; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AxXDfu40" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-424720e73e0so32724225e9.0 for ; Sun, 23 Jun 2024 15:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719180817; x=1719785617; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WfAeBdvIoKGyGbUJs+5en2LQCmL61huY76I64Cj6UXA=; b=AxXDfu401z3Nwo3aDWTYjI1ABPlW8e8R+baTPspbOm19z3Fw8klwYkPvR5FK7tVGMo eJgjzinHJv3mcMFuQYuT2839NpR4hXW0Kj50piquD8RyNs3QhVQNaWnYRk6zZjboelcB JFfAJ7aYXtL1K8y9G6x2u3jL4r/7T+UxrTTkDylQVWa8juQUhIiRklsGuHjRdEUMBt1I njVNdEfiVdFao1q51UUKshYgtemwA/RZEhJ6v6ZF2N6O4ibyM9t/ufoSFeSiCtoW8iXv 4DbVGLaSheKTcTwi8d0Q9DybgRitddgxIIPtZ3Pa79P3lA9W0iqTnyVldl3p0c39x8ga 8mhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719180817; x=1719785617; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WfAeBdvIoKGyGbUJs+5en2LQCmL61huY76I64Cj6UXA=; b=eEqXbQTvYsh8nRm4rTP7q8PZv9eFy7l3UmonoF6gA20Fi4LqAErS81tmrZ4mG1H0yn OdavPGRN7Cef8NYr00vqyN++zWs9panaNq+mshppPgHJu8/6U7ymsnotesM3MHdmoHgB 0AwXxjfIsh41dN34smJgnixmK1RsSCVFnBkIqABxL8br0kdY4Ili40c0cZCyUrNgzS4N VqcxSHaxP/xlafQYe0KJardSVXBCdNXB38yJeuBXKTRDZVJT5J4YYTdrizaYSH5reMUH /Keo9kXoWOKG75RYmQg5Llw4Fg7VJ8osfVbkmjp9CnmlGSxz5J25D+hu8T2OBwS/85wi E6CQ== X-Forwarded-Encrypted: i=1; AJvYcCVy5k52/bgzLaviGvcFQUq4yITloMRo+Ss4MXlsdL4b+tsexVerdxBROcqiNjMtEy30mnXwCfuGhYIuqjaGe6nlLofcKSM6KhxoZA== X-Gm-Message-State: AOJu0YwRswHpICoCPbRDLCchcuZ45sZbyCH+eG+j0C3DrLE0D/zmBM29 1cTsKw9ySQQe+XAdwQzj/NVYg0Ta5xMkYFQkBRRfrKkCV3GUoqvEYzEaTfMeMOw= X-Google-Smtp-Source: AGHT+IHzpd18VN3XGaaoHGuAVvQ/sKRZalYdmsgQw/7bPccPtW4ds29vx37N4ZomBsEHOO4cB0qHLQ== X-Received: by 2002:a05:600c:4b91:b0:421:de31:4e with SMTP id 5b1f17b1804b1-4248b9ca8acmr21873945e9.26.1719180816761; Sun, 23 Jun 2024 15:13:36 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d0bea1esm152045565e9.13.2024.06.23.15.13.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jun 2024 15:13:36 -0700 (PDT) Message-ID: Date: Sun, 23 Jun 2024 23:13:35 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] media: qcom: camss: csiphy-3ph: Add Gen2 v1.2.2 two-phase MIPI CSI-2 DPHY init To: george chan , Bryan O'Donoghue Cc: Konrad Dybcio , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, Bjorn Andersson , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240621-b4-sc7180-camss-v1-0-14937929f30e@gmail.com> <20240621-b4-sc7180-camss-v1-3-14937929f30e@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/06/2024 22:37, george chan wrote: > User-space tool can't tell so I made some guesses. So how are you testing ? Libcamera on your target rootfs ? # example 1 cam -c 1 --capture=10 --file Should deliver up ten frames to userpsace. For me working means either 1. Sensor data delivered to user-space or 2. Minimum test pattern generator (TPG) data delivered to userspace Here's an example of the TPG on the rb3/sdm845 # example 2 media-ctl --reset yavta --no-query -w '0x009f0903 9' /dev/v4l-subdev4 yavta --list /dev/v4l-subdev4 media-ctl -d /dev/media0 -V '"msm_csid0":0[fmt:SGRBG10_1X10/3280x2464]' media-ctl -d /dev/media0 -V '"msm_vfe0_rdi0":0[fmt:SGRBG10_1X10/3280x2464]' media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]' media-ctl -d /dev/media0 -p yavta -B capture-mplane --capture=5 -n 5 -I -f SGRBG10P -s 3280x2464 --file=TPG-SGRBG10-3280x2464-000-#.bin /dev/video2 If you can't use libcamera to do the v4l pipeline setup you can do so yourself manually again here's rb3 setting up the pipeline and reading from ov8856. # example 3 media-ctl --reset media-ctl -d /dev/media0 -V '"ov8856 '16-0010'":0[fmt:SGRBG10_1X10/3280x2464 field:none]' media-ctl -d /dev/media0 -V '"msm_csiphy0":0[fmt:SGRBG10_1X10/3280x2464]' media-ctl -d /dev/media0 -V '"msm_csid0":0[fmt:SGRBG10_1X10/3280x2464]' media-ctl -d /dev/media0 -V '"msm_vfe0_rdi0":0[fmt:SGRBG10_1X10/3280x2464]' media-ctl -l '"msm_csiphy0":1->"msm_csid0":0[1],"msm_csid0":1->"msm_vfe0_rdi0":0[1]' media-ctl -d /dev/media0 -p yavta -B capture-mplane --capture=5 -n 5 -I -f SGRBG10P -s 3280x2464 --file=ov8856-SGRBG10-3280x2464-000-#.bin /dev/video0 Maybe its an obvious question but, are you currently able to read from either 1. The sensor - thus proving the PHY init sequence you have or 2. The TPG ? as illustrated with one of the examples [1, 2, 3] above ? --- bod